Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NFC] CRM_Extension_Manager_ModuleUpgTest - use ?? instead of error-suppression operator #21214

Merged
merged 1 commit into from
Aug 22, 2021

Conversation

demeritcowboy
Copy link
Contributor

Overview

This is the same as #21206 but in another file.

Can potentially cause problems in php 8 with certain error handlers.
Note also that assertEquals() treats 0 and null as equal, so have tightened it up by using assertSame.
Addresses test fails in #21064:

not ok 1930 - Error: CRM_Extension_Manager_ModuleUpgTest::testInstallDisableUninstall
not ok 1931 - Failure: CRM_Extension_Manager_ModuleUpgTest::testInstallDisableEnable
  ---
  message: Failed asserting that true matches expected false.
  severity: fail
  data:
    got: true
    expected: false
  ...
  not ok 1932 - Error: CRM_Extension_Manager_ModuleUpgTest::testInstall_DirtyRemove_Disable_Uninstall
not ok 1933 - Error: CRM_Extension_Manager_ModuleUpgTest::testInstall_DirtyRemove_Disable_Restore

@civibot
Copy link

civibot bot commented Aug 22, 2021

(Standard links)

@civibot civibot bot added the master label Aug 22, 2021
@colemanw colemanw merged commit 9ac46ce into civicrm:master Aug 22, 2021
@demeritcowboy demeritcowboy deleted the extupg branch August 23, 2021 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants