Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NFC] - Replace deprecated function in AngularLoaderTest #21244

Merged
merged 1 commit into from
Aug 25, 2021

Conversation

demeritcowboy
Copy link
Contributor

Overview

Addresses test fail in #21064

Before

Deprecated function AngularLoader->load()

After

Technical Details

Deprecation not coming up in regular test runs because the @ was hiding it.

Comments

Is test.

@civibot
Copy link

civibot bot commented Aug 24, 2021

(Standard links)

@civibot civibot bot added the master label Aug 24, 2021
@seamuslee001
Copy link
Contributor

This seems fine to me but maybe @colemanw wanted it like the other way to confirm backwards compatibility ?

@colemanw
Copy link
Member

Looks good to me.

@colemanw colemanw merged commit 59ea49c into civicrm:master Aug 25, 2021
@demeritcowboy demeritcowboy deleted the angular-loader branch August 25, 2021 13:34
@demeritcowboy
Copy link
Contributor Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants