Do not enable custom activity search on new installs #21260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In general we want to get away from maintaining the custom searches. Reading the docs I realised this search does not do anything not done through advanced search and activity search (even before we start talking about search kit) so this is 'one down
|
(Standard links)
|
|
Big 👍 to this. Why would we enable any custom searches by default? |
|
I'm not against disabling it just adding some info: If I remember right the reason this search existed was as a workaround for the bug where Find Activities would only find activities that had a With Contact, which is still a bug in Find Activities. It also has a hidden easter egg where when you export the results it includes case id (in an unnamed column, because otherwise it's too easy). |
|
Wow @demeritcowboy you're like the Easter Bunny! |
|
@demeritcowboy ah yeah - I guess if the way to know a search is useful is to consult the encyclopedia of Dave's brain it might not be missed :-) |
agileware-justin
pushed a commit
to agileware/civicrm-end-user-guide
that referenced
this pull request
Jun 19, 2023
This search adds nothing so deprecation time civicrm/civicrm-core#21260
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
In general we want to get away from maintaining the custom searches. Reading the docs I realised
this search does not do anything not done through advanced search and activity search (even
before we start talking about search kit) so this is 'one down
Before
Search enabled on new installs but does not add to other search methods
After
Not enabled on new installs
Technical Details
Comments
Docs PR https://lab.civicrm.org/documentation/docs/user-en/-/merge_requests/493