[Ref] Deprecate Core_Error handling

[eileenmcnaughton]

Overview

[Ref] Deprecate Core_Error handling

Before

Too much code to handle something that should not happen

After

Code reduced, deprecation notice added

Technical Details

Core processors throw PaymentProcessor exceptions which is correct - but I DID find that ca.civicrm.contributionrecur returns a CRM_Core_Error object - @adixon this PR will add a deprecation notice to that (rareish) flow but you can just throw a PaymentProcessorException instead

I didn't check all of them once I'd established that at least one processor used the old pattern since I'd originally thought we could remove rather than deprecate.

Comments

@mattwire

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[eileenmcnaughton]

test this please

[seamuslee001]

test coverage should be fine here

[eileenmcnaughton]

thanks @seamuslee001