Add test to UpdateSubscription form #21282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
eileenmcnaughton
force-pushed
the
test_sub
branch
from
3cca38d
to
0d7261f
Compare
|
@seamuslee001 can I get a merge on this (& there is one other easy one I'm just hunting for) |
mattwire
reviewed
Aug 29, 2021
| @@ -323,8 +323,7 @@ public function postProcess() { | |||
| } | |||
| } | |||
|
|
|||
| $session = CRM_Core_Session::singleton(); | |||
| $userID = $session->get('userID'); | |||
| $userID = CRM_Core_Session::singleton()->get('userID'); | |||
There was a problem hiding this comment.
@eileenmcnaughton If updating this line it should be changed to:
Suggested change
| $userID = CRM_Core_Session::singleton()->get('userID'); | |
| $userID = CRM_Core_Session::getLoggedInContactID(); |
There was a problem hiding this comment.
@mattwire yeah - I won't add that to this PR thought because - the point of the PR is to add the test. I fixed 2 super obvious things in the class while I was doing it but I don't want to scope creep into cleaning up the form class in this pr
There was a problem hiding this comment.
I pulled the change out
eileenmcnaughton
force-pushed
the
test_sub
branch
from
0d7261f
to
91b773b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Add test to UpdateSubscription form
Before
Nada
After
and out of nothing....
Technical Details
Test only at this stage
Comments