Simplify ContributionView form. Always display "lineitems" #21285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Jenkins re test this please (build failure) |
|
test this please |
|
This passed 'r-run' for me and I agree with simpler @Stoob @MegaphoneJon @JoeMurray anyone have concerns? |
eileenmcnaughton
added
the
merge ready
|
I'm +1 on the concept. |
|
I put this in the dev digest and there has been no further feedback than the thumbs up from @artfulrobot & the +1 from @MegaphoneJon - so I'm not seeing any push back & hence merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
If we are using "quickconfig" the form does not display lineitems. Quickconfig is when adding amounts via a contributionpage without a priceset but it is still using pricesets/lineitems internally so there are always lineitems.
This was identified during @jaapjansma work on template contributions and I believe the reason for the two ways to display is just historical - ie. one was there already and when lineitems/quickconfig came along the other got added on but without removing the old way. This is quite a common source of confusion because it causes the detail of a contribution to be displayed in a different way.
Before
Two ways that "lineitems" can be shown.
After
Just one standard way. Simpler form.
Technical Details
Comments