Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NFC] Fix APIv4 Conformance tests on php8 #21302

Merged
merged 1 commit into from
Aug 29, 2021

Conversation

seamuslee001
Copy link
Contributor

Overview

This aims to fix the following test failure when the conformance tests are run on php8

api\v4\Entity\ConformanceTest::testConformance with data set "ACL" ('ACL')
Trying to access array offset on value of type null

/home/jenkins/bknix-max/build/build-0/web/sites/all/modules/civicrm/CRM/Member/BAO/MembershipType.php:393
/home/jenkins/bknix-max/build/build-0/web/sites/all/modules/civicrm/CRM/Member/BAO/Membership.php:286

Before

Conformance tests fail on php8 as no MembershipType is present in the database

After

Tests pass

ping @eileenmcnaughton

@civibot
Copy link

civibot bot commented Aug 29, 2021

(Standard links)

@civibot civibot bot added the master label Aug 29, 2021
@eileenmcnaughton eileenmcnaughton merged commit 715ff05 into civicrm:master Aug 29, 2021
@eileenmcnaughton eileenmcnaughton deleted the fix_conformance_tests branch August 29, 2021 03:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants