dev/core#2806 Fix accidental exposure of v4 tokens

[eileenmcnaughton]

Overview

dev/core#2806 Fix accidental exposure of v4 tokens

Before

In master (only) tokens were being displayed like '{contribution.Partner.name'} referring to custom fields. Long term we want this more portable format but we are not ready to define it yet

After

Extraneous tokens removed

Technical Details

@demeritcowboy I haven't added a test here because I'm working on tests for this stuff in CRM_Utils_TokenConsistencyTest but I already have an open test against this class - https://github.com/civicrm/civicrm-core/pull/21327/files - unfortunately that one didn't pick it up because contribution recur doesn't 'normally' have custom data - but I do intend to add more tests for this stuff in that class . The class I did the original contribution tokens test in unfortunately uses rollback which doesn't play nice with custom fields so I 'moved'

Comments

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[demeritcowboy]

Thanks this seems to run ok. I don't know enough to comment on the r-tech.

[seamuslee001]

Merging as per @demeritcowboy 's review