Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NFC] Cleanup boilerplate code in extension upgrader classes #21340

Merged
merged 1 commit into from
Sep 1, 2021
Merged

[NFC] Cleanup boilerplate code in extension upgrader classes #21340

merged 1 commit into from
Sep 1, 2021

Conversation

colemanw
Copy link
Member

@colemanw colemanw commented Sep 1, 2021

Overview

Code cleanup inspired by totten/civix#225

@civibot
Copy link

civibot bot commented Sep 1, 2021

(Standard links)

@civibot civibot bot added the master label Sep 1, 2021
@colemanw
Copy link
Member Author

colemanw commented Sep 1, 2021

Ping @totten

@totten
Copy link
Member

totten commented Sep 1, 2021

"NFC" assessment looks fair. These particular files don't need to carry that boilerplate.

@totten totten merged commit 087bb1e into civicrm:master Sep 1, 2021
@seamuslee001 seamuslee001 deleted the upgradeFunctions branch September 1, 2021 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
master
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@colemanw @totten