Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NFC/Unit test] Update flaky test CRM_Utils_TokenConsistencyTest::testCaseTokenConsistency #21341

Merged
merged 1 commit into from
Sep 1, 2021

Conversation

demeritcowboy
Copy link
Contributor

@demeritcowboy demeritcowboy commented Sep 1, 2021

Overview

Avoid flaky test because created and modified are backwards which might have a split-second difference between them, e.g. https://test.civicrm.org/job/CiviCRM-Core-PR/43516/testReport/junit/(root)/CRM_Utils_TokenConsistencyTest/testCaseTokenConsistency/

CRM_Utils_TokenConsistencyTest::testCaseTokenConsistency
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
 Ongoing\n
 No\n
 2021-09-01 02:36:47\n
-2021-09-01 02:36:47\n
+2021-09-01 02:36:48\n
 '

/home/jenkins/bknix-dfl/build/core-21328-7rs5q/web/sites/all/modules/civicrm/tests/phpunit/CRM/Utils/TokenConsistencyTest.php:57

@civibot
Copy link

civibot bot commented Sep 1, 2021

(Standard links)

@civibot civibot bot added the master label Sep 1, 2021
@colemanw
Copy link
Member

colemanw commented Sep 1, 2021

Oh! That was the problem. Good sleuthing @demeritcowboy!

@demeritcowboy
Copy link
Contributor Author

Thanks!

@demeritcowboy demeritcowboy merged commit c9fc067 into civicrm:master Sep 1, 2021
@demeritcowboy demeritcowboy deleted the token-time branch September 1, 2021 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants