Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REF] Fix Page Hook test on php8 by putting in guard into customDataB… #21344

Merged
merged 1 commit into from
Sep 2, 2021

Conversation

seamuslee001
Copy link
Contributor

…lock around the SubType variable

Overview

CRM_Core_Page_HookTest fails on php8 due to an e-notice

Before

Test fails

CRM_Core_Page_HookTest::testFormsCallBuildFormOnce
Undefined array key "customDataSubType"

/home/jenkins/bknix-edge/build/build-0/web/sites/default/files/civicrm/templates_c/en_US/%%9F/9F8/9F828591%%customDataBlock.tpl.php:18
/home/jenkins/bknix-edge/build/build-0/web/sites/all/modules/civicrm/packages/Smarty/Smarty.class.php:1914
/home/jenkins/bknix-edge/build/build-0/web/sites/default/files/civicrm/templates_c/en_US/%%4C/4C5/4C5F7411%%EntityForm.tpl.php:36
/home/jenkins/bknix-edge/build/build-0/web/sites/all/modules/civicrm/packages/Smarty/Smarty.class.php:1914
/home/jenkins/bknix-edge/build/build-0/web/sites/default/files/civicrm/templates_c/en_US/%%7A/7AF/7AF88B87%%RelationshipType.tpl.php:6

After

Test passes on php8

ping @eileenmcnaughton @demeritcowboy

@civibot
Copy link

civibot bot commented Sep 1, 2021

(Standard links)

@civibot civibot bot added the master label Sep 1, 2021
@seamuslee001 seamuslee001 merged commit ef4563c into civicrm:master Sep 2, 2021
@seamuslee001 seamuslee001 deleted the fix_page_hook_test branch September 2, 2021 01:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants