SearchKit - Fix aggregated joins #21411
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fixes a bug where adding an aggregated join will cause invalid SQL.
Before
The following search will crash:
SEARCH FOR: Activities
WITH (optional): Activity Contacts
GROUP BY: Activity ID
After
Search runs without error.
Comments
When merging this forward, the first commit is already in
master
and can be skipped over if git complains.