Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SearchKit - Fix aggregated joins #21411

Merged
merged 2 commits into from
Sep 9, 2021

Conversation

colemanw
Copy link
Member

@colemanw colemanw commented Sep 8, 2021

Overview

Fixes a bug where adding an aggregated join will cause invalid SQL.

Before

The following search will crash:
SEARCH FOR: Activities
WITH (optional): Activity Contacts
GROUP BY: Activity ID

After

Search runs without error.

Comments

When merging this forward, the first commit is already in master and can be skipped over if git complains.

@civibot
Copy link

civibot bot commented Sep 8, 2021

(Standard links)

@civibot civibot bot added the 5.42 label Sep 8, 2021
@eileenmcnaughton
Copy link
Contributor

@colemanw I'm not managing to replicate this - but @kurund if this fixes for you please merge

@kurund
Copy link
Contributor

kurund commented Sep 9, 2021

@colemanw @eileenmcnaughton

Thank you. Tested above on master and it working as expected. Did few more random tests and all good.

IMO good to merge.

@kurund
Copy link
Contributor

kurund commented Sep 9, 2021

Also tested on 5.42 branch and also working fine.

@colemanw colemanw merged commit b1b80fd into civicrm:5.42 Sep 9, 2021
@colemanw colemanw deleted the fixSearchKitAugmentSelectClause branch September 9, 2021 13:07
@colemanw
Copy link
Member Author

colemanw commented Sep 9, 2021

Thanks @kurund - can you also check this further improvement I did in master: #21420

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants