Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SearchKit - Fix search display pager when using default pager settings #21488

Merged
merged 1 commit into from
Sep 16, 2021

Conversation

colemanw
Copy link
Member

@colemanw colemanw commented Sep 15, 2021

Overview

Fixes a regression where the pager stopped working in Search Displays.
Regression was caused by #21069

Before

Create a new search display. Leave the pager settings at their default.
In the preview, notice that paging past page 1 still shows page 1 results.

After

Pager shows correct results for each page.

@civibot
Copy link

civibot bot commented Sep 15, 2021

(Standard links)

@eileenmcnaughton
Copy link
Contributor

Paging looks good on the test site in my testing

@eileenmcnaughton eileenmcnaughton merged commit b144af4 into civicrm:5.42 Sep 16, 2021
@eileenmcnaughton eileenmcnaughton deleted the fixPager branch September 16, 2021 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants