Call line item pre hook after tax amount is calculated #21731
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Call line item pre hook after tax amount is set
Before
Tax amount calculation is done after hooks are called in line item BAO
After
Tax amount calculation is done before hooks are called in line item BAO
Technical Details
@KarinG @pradpnayak we never did get to the bottom of https://lab.civicrm.org/dev/core/-/issues/2796 but it occurred to me that moving the hook call might be one easy thing we can do to allow extension writers to intervene
Comments