Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call line item pre hook after tax amount is calculated #21731

Merged
merged 1 commit into from
Oct 6, 2021

Conversation

eileenmcnaughton
Copy link
Contributor

Overview

Call line item pre hook after tax amount is set

Before

Tax amount calculation is done after hooks are called in line item BAO

After

Tax amount calculation is done before hooks are called in line item BAO

Technical Details

@KarinG @pradpnayak we never did get to the bottom of https://lab.civicrm.org/dev/core/-/issues/2796 but it occurred to me that moving the hook call might be one easy thing we can do to allow extension writers to intervene

Comments

@civibot civibot bot added the 5.42 label Oct 5, 2021
@civibot
Copy link

civibot bot commented Oct 5, 2021

(Standard links)

@eileenmcnaughton eileenmcnaughton changed the title Call line item pre hook after tax amount is set Call line item pre hook after tax amount is calculated Oct 5, 2021
@KarinG
Copy link
Contributor

KarinG commented Oct 5, 2021

I think that's a safe solution!

@eileenmcnaughton
Copy link
Contributor Author

test this please

@colemanw
Copy link
Member

colemanw commented Oct 6, 2021

Change looks safe/sensible to me as well.

@colemanw colemanw merged commit be1bc9d into civicrm:5.42 Oct 6, 2021
@colemanw colemanw deleted the linerc branch October 6, 2021 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants