CiviCRM Standalone: base classes #22227

mlutfy · 2021-12-08T20:00:47Z

Overview

As CiviCRM has evolved, and so has content management systems, and how organizations manage their CRM, it seems like a good time to bring CiviCRM Standalone back.

A lot of organizations do not expose their CRM, or they might only expose specific forms, on a sub-domain.
Managing a website and a CRM coupled together can be challenging.
CMSes have become more and more complex, with increasing conflicts between CiviCRM and the CRM. Having to install a CMS before installing a CRM is extra friction. Many people view Drupal9 as too complicated, and WordPress as risky.

More information:
https://lab.civicrm.org/dev/core/-/wikis/standalone

Technical Details

A lot more work required, obviously
Current implementation is very insecure. It copies some classes from the UnitTests, to bypass authentication, for example.

civibot · 2021-12-08T20:00:51Z

(Standard links)

If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

mlutfy · 2021-12-09T01:36:27Z

I created a repo here to help get started, and also has the web/index.php to bootstrap CiviCRM.

Edit: repo link: https://github.com/mlutfy/civicrm-standalone

Doc updated here: https://lab.civicrm.org/dev/core/-/wikis/standalone

mlutfy · 2021-12-09T21:44:39Z

odd, I don't think the test fail relates?

CRM_Core_BAO_CustomFieldTest::testFileDisplayValueNoDescription
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'              <a href="/index.php?q=civicrm/file&amp;reset=1&amp;id=1&amp;eid=3&amp;fcs=7ca559b89d9e6c1b88000a0028e7172732a600476a3670aafc4c3ce8325b31a0_1639081466_168" title="test_file.txt">\n
+'              <a href="/index.php?q=civicrm/file&amp;reset=1&amp;id=1&amp;eid=3&amp;fcs=7ca559b89d9e6c1b88000a0028e7172732a600476a3670aafc4c3ce8325b31a0_1639081467_168" title="test_file.txt">\n
                 <i class="crm-i fa-paperclip" aria-hidden="true"></i>\n
               </a>

demeritcowboy · 2021-12-09T21:47:58Z

It's a timing rollover - known issue - note 1639081466_168 vs 1639081467_168. It's a little hard to fix because it would touch on a previous security fix.

demeritcowboy · 2021-12-09T21:50:18Z

By the way where is the "repo" you mention above?

mlutfy · 2021-12-09T22:09:15Z

Here's the repo: https://github.com/mlutfy/civicrm-standalone

mlutfy · 2021-12-10T13:55:30Z

jenkins, test this please

mlutfy · 2021-12-24T15:01:08Z

jenkins, test this please

demeritcowboy · 2021-12-27T17:08:40Z

CRM/Utils/System/Standalone.php

+   */
+  public function getLoginURL($destination = '') {
+    $query = $destination ? ['destination' => $destination] : [];
+    return \Drupal\Core\Url::fromRoute('user.login', [], ['query' => $query])->toString();


This comes up as a fatal error on an entityref field if you choose e.g. the New Individual popup. Maybe for now it could be return CRM_Utils_System::url('civicrm/todo/user/login', 'reset=1'); or something like that, just so the popup works.

@demeritcowboy Thanks - I updated to civicrm/user/login, since I think that makes sense as a login URL.

…e by DaveD)

… mode

…build)

seamuslee001 · 2022-06-24T22:05:09Z

Jenkins re test this please

mlutfy · 2022-06-24T23:32:05Z

Diving back into this is hard. I had forgotten that the installer now works, but I had not committed the file.

Example:

after entering DB credentials:

However, there are shenanigans after installation - some path is not correctly set, so the menu and CSS are not loading correctly:

ah - and because of my composer.lock on civicrm-standalone, it's building on 5.44. Need to re-test on latest.

mlutfy · 2022-06-29T15:08:59Z

Fixed the linting warning.

…obile support

demeritcowboy · 2022-06-30T00:30:52Z

CRM/Utils/System/Standalone.php

+ * Standalone specific stuff goes here.
+ */
+class CRM_Utils_System_Standalone extends CRM_Utils_System_Base {
+


I see you've removed registerPathVars() in this latest update. It means that [cms.root] is now null, which kind of makes sense here, but we'll need to hunt down where it's used since it generates errors. Or perhaps it should point to web.

hmm I have to admit I don't really recall. I grepped a bit in the codebase about cms.root and it seems there more for convenience, for settings, but I'd be surprised if extensions used it? (there are better functions for generating URLs and getPaths)

I don't think I took notes but it might have been during install. And I seem to remember something about the system settings - directories page (which would make sense there).

Also I was using php 8 this time around, which is less forgiving. I didn't intend to, just it happened to be in my path from something else and then composer(👿) locked everything to php 8+ so it won't even run with a web server using 7.

mlutfy · 2022-07-07T01:23:37Z

jenkins, test this please

eileenmcnaughton · 2022-07-10T22:05:41Z

Where is this at - to the extent that it only touches stuff within the standalone subsystem I think we can have a more 'work-in-progress' attitude - but if this is exposing it as available to install then I guess the concern is we might be offering something that we are not yet delivering.

For background I think this has concept-approved in terms of 'we do want standalone to work' - so it's a question of how to support work on it without creating confusion

demeritcowboy · 2022-07-11T12:00:13Z

I see pluses and minuses to merging. There's the ones you've mentioned, and then

this one is unlikely to go stale in its current form
and also even if merged it will quickly get replaced by another one, although maybe smaller
the latest update here broke some things (in standalone only), but need to figure out what cms.root should mean in standalone anyway

After writing that out I see it leans a bit towards leaving here. But also for the concern about advertising it I don't see anything in here that makes it visible to users.

I'm 50/50 personally.

mlutfy · 2022-07-11T13:25:37Z

Personally, I'd favour merging, because the various decisions that will go into Standalone will be muddied if it's all behind a single PR. For example, cms.root could be a discussion in itself?

demeritcowboy · 2022-07-11T13:29:06Z

🚀

civibot bot added the master label Dec 8, 2021

mlutfy marked this pull request as draft December 8, 2021 20:01

mlutfy force-pushed the standalone branch from 2a7c8f1 to c10d996 Compare December 9, 2021 01:35

mlutfy force-pushed the standalone branch 5 times, most recently from 88176a3 to 6fdd01f Compare December 9, 2021 16:40

mlutfy changed the title ~~WIP: CiviCRM Standalone: base classes~~ CiviCRM Standalone: base classes Dec 9, 2021

mlutfy marked this pull request as ready for review December 9, 2021 17:08

mlutfy force-pushed the standalone branch from 6fdd01f to a1a96b0 Compare December 9, 2021 20:06

demeritcowboy reviewed Dec 27, 2021

View reviewed changes

mlutfy and others added 5 commits June 24, 2022 13:59

CiviCRM Standalone proof of concept

4d45147

Standalone: Towards Gencode support

d2763d6

Standalone: Towards Gencode support (findConfigTemplate, based on cod…

0957abf

…e by DaveD)

Standalone: fix url() fragment, and implement theme() for maintenance…

89c1009

… mode

Standalone: Add css/menubar-standalone.css (required for the menu to …

59fc125

…build)

mlutfy force-pushed the standalone branch from 9630aed to 59fc125 Compare June 24, 2022 18:00

mlutfy force-pushed the standalone branch from fb0e9c5 to 6584b20 Compare June 24, 2022 23:28

Standalone: add setup plugin so that we can install

965fb87

mlutfy force-pushed the standalone branch from 6584b20 to 965fb87 Compare June 29, 2022 15:08

Standalone: Tweak css/menubar-standalone.css for the page title and m…

0d0a914

…obile support

demeritcowboy reviewed Jun 30, 2022

View reviewed changes

demeritcowboy merged commit c36e958 into civicrm:master Jul 11, 2022

eileenmcnaughton deleted the standalone branch July 12, 2022 03:21

mlutfy added the comp:standalone label Dec 19, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

CiviCRM Standalone: base classes #22227

CiviCRM Standalone: base classes #22227

mlutfy commented Dec 8, 2021

civibot bot commented Dec 8, 2021

mlutfy commented Dec 9, 2021 •

edited

Loading

mlutfy commented Dec 9, 2021

demeritcowboy commented Dec 9, 2021

demeritcowboy commented Dec 9, 2021

mlutfy commented Dec 9, 2021

mlutfy commented Dec 10, 2021

mlutfy commented Dec 24, 2021

demeritcowboy Dec 27, 2021

mlutfy Dec 28, 2021

seamuslee001 commented Jun 24, 2022

mlutfy commented Jun 24, 2022

mlutfy commented Jun 29, 2022

demeritcowboy Jun 30, 2022

mlutfy Jul 7, 2022

demeritcowboy Jul 7, 2022

demeritcowboy Jul 7, 2022

mlutfy commented Jul 7, 2022

eileenmcnaughton commented Jul 10, 2022

demeritcowboy commented Jul 11, 2022

mlutfy commented Jul 11, 2022

demeritcowboy commented Jul 11, 2022

CiviCRM Standalone: base classes #22227

CiviCRM Standalone: base classes #22227

Conversation

mlutfy commented Dec 8, 2021

Overview

Technical Details

civibot bot commented Dec 8, 2021

mlutfy commented Dec 9, 2021 • edited Loading

mlutfy commented Dec 9, 2021

demeritcowboy commented Dec 9, 2021

demeritcowboy commented Dec 9, 2021

mlutfy commented Dec 9, 2021

mlutfy commented Dec 10, 2021

mlutfy commented Dec 24, 2021

demeritcowboy Dec 27, 2021

Choose a reason for hiding this comment

mlutfy Dec 28, 2021

Choose a reason for hiding this comment

seamuslee001 commented Jun 24, 2022

mlutfy commented Jun 24, 2022

mlutfy commented Jun 29, 2022

demeritcowboy Jun 30, 2022

Choose a reason for hiding this comment

mlutfy Jul 7, 2022

Choose a reason for hiding this comment

demeritcowboy Jul 7, 2022

Choose a reason for hiding this comment

demeritcowboy Jul 7, 2022

Choose a reason for hiding this comment

mlutfy commented Jul 7, 2022

eileenmcnaughton commented Jul 10, 2022

demeritcowboy commented Jul 11, 2022

mlutfy commented Jul 11, 2022

demeritcowboy commented Jul 11, 2022

mlutfy commented Dec 9, 2021 •

edited

Loading