Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REF][Test] Update loadMappingTest to use form flow #23286

Merged
merged 1 commit into from
Apr 25, 2022

Conversation

eileenmcnaughton
Copy link
Contributor

@eileenmcnaughton eileenmcnaughton commented Apr 22, 2022

Overview

[REF][Test] Update loadMappingTest to use form flow

Before

Test mimics parts of what the form does

After

Test tests what the form does - note the column numbers are fixed to start from 0 as they would be when submitted to avoid notices

Technical Details

Based on #23284 to avoid notices....

Comments

@civibot
Copy link

civibot bot commented Apr 22, 2022

(Standard links)

@demeritcowboy
Copy link
Contributor

jenkins retest this please

@demeritcowboy
Copy link
Contributor

Needs rebase

Applying: Extract getContactType                                                         
  Patch failed at 0001 Extract getContactType                                              
  When you have resolved this problem, run "git am --continue".                            
  If you prefer to skip this patch, run "git am --skip" instead.                           
  To restore the original branch and stop patching, run "git am --abort".                  
  [[ STDERR ]]                                                                             
  error: patch failed: CRM/Contact/Import/Form/MapField.php:89                             
  error: CRM/Contact/Import/Form/MapField.php: patch does not apply                        
  error: patch failed: CRM/Contact/Import/MetadataTrait.php:103                            
  error: CRM/Contact/Import/MetadataTrait.php: patch does not apply                        
  error: patch failed: CRM/Contact/Import/Parser/Contact.php:261                           
  error: CRM/Contact/Import/Parser/Contact.php: patch does not apply                       
  error: patch failed: CRM/Import/Forms.php:293                                            
  error: CRM/Import/Forms.php: patch does not apply                                        
  error: patch failed: tests/phpunit/CRM/Contact/Import/Form/MapFieldTest.php:50           
  error: tests/phpunit/CRM/Contact/Import/Form/MapFieldTest.php: patch does not apply      
  error: patch failed: tests/phpunit/CiviTest/CiviUnitTestCase.php:3220                    
  error: tests/phpunit/CiviTest/CiviUnitTestCase.php: patch does not apply      

This makes it test more accurately what the form is doing....
@eileenmcnaughton
Copy link
Contributor Author

Rebased

@eileenmcnaughton
Copy link
Contributor Author

thanks @demeritcowboy

@eileenmcnaughton eileenmcnaughton merged commit 6de1f67 into civicrm:master Apr 25, 2022
@eileenmcnaughton eileenmcnaughton deleted the mapping branch April 25, 2022 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants