Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AfformGui - Optional reset button for search and submit forms #23334

Merged
merged 1 commit into from
May 3, 2022

Conversation

colemanw
Copy link
Member

@colemanw colemanw commented May 1, 2022

Overview

Fixes https://lab.civicrm.org/dev/core/-/issues/3430

Allows search and submit forms to have a "Reset" button, and only allows a "Submit" button to be added to submission forms.

Technical Details

Adds some metadata about what elements belong on what form types, which will now hide the "submit" button as an option for non-submission forms.

Adds some metadata about what elements belong on what form types,
which will now hide the "submit" button as an option for non-submission forms.
@civibot
Copy link

civibot bot commented May 1, 2022

(Standard links)

@civibot civibot bot added the master label May 1, 2022
@seamuslee001
Copy link
Contributor

This seems fine to me, i presume type reset does something within angularjs to reset the form?

@colemanw
Copy link
Member Author

colemanw commented May 2, 2022

It's actually a vanilla html thing. But it works fine in Angular forms.

@seamuslee001 seamuslee001 merged commit ef72f52 into civicrm:master May 3, 2022
@seamuslee001 seamuslee001 deleted the afformResetButton branch May 3, 2022 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants