Fix WP Clean Pages check when components are disabled #24950
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
|
@christianwach @kcristiano this makes sense to me & should be ported to stable IMHO. If you are happy I will merge & try to get this & a couple of other things pushed out next week |
|
@eileenmcnaughton Code looks sensible to me. |
|
I agree. |
|
Stable port #24972 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
In CiviCRM 5.55.1, the Clean URLs check fails on WordPress with CiviContribute disabled with the error
ContributionPage API is not available because CiviContribute component is disabled. This doesn't happen on 5.54.1.Before
Error.
After
No error.
Technical Details
Previously I suppose the APIs were available even if the component was enabled - but now it's not, so we check first.