Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NFC] Don't flush someone else's ob #29426

Merged
merged 1 commit into from
Feb 18, 2024

Conversation

demeritcowboy
Copy link
Contributor

Overview

It's risky to flush someone else's ob.
Interpret that however you want.

Before

I'm hoping #29425 will make this test show up as a fail. I've been seeing it in another environment.

After

Technical Details

I'm not sure if this line was added to solve some problem at the time, but the test doesn't start its own output buffer. Even if there is another one somewhere, it shouldn't be flushed here. It doesn't seem needed locally.

Comments

Copy link

civibot bot commented Feb 18, 2024

🤖 Thank you for contributing to CiviCRM! ❤️ We will need to test and review this PR. 👷

Introduction for new contributors...
  • If this is your first PR, an admin will greenlight automated testing with the command ok to test or add to whitelist.
  • A series of tests will automatically run. You can see the results at the bottom of this page (if there are any problems, it will include a link to see what went wrong).
  • A demo site will be built where anyone can try out a version of CiviCRM that includes your changes.
  • If this process needs to be repeated, an admin will issue the command test this please to rerun tests and build a new demo site.
  • Before this PR can be merged, it needs to be reviewed. Please keep in mind that reviewers are volunteers, and their response time can vary from a few hours to a few weeks depending on their availability and their knowledge of this particular part of CiviCRM.
  • A great way to speed up this process is to "trade reviews" with someone - find an open PR that you feel able to review, and leave a comment like "I'm reviewing this now, could you please review mine?" (include a link to yours). You don't have to wait for a response to get started (and you don't have to stop at one!) the more you review, the faster this process goes for everyone 😄
  • To ensure that you are credited properly in the final release notes, please add yourself to contributor-key.yml
  • For more information about contributing, see CONTRIBUTING.md.
Quick links for reviewers...

➡️ Online demo of this PR 🔗

@civibot civibot bot added the master label Feb 18, 2024
@demeritcowboy demeritcowboy merged commit f84ae4a into civicrm:master Feb 18, 2024
3 checks passed
@demeritcowboy demeritcowboy deleted the flush-ob branch February 18, 2024 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants