[NFC] Don't flush someone else's ob #29426
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
It's risky to flush someone else's ob.
Interpret that however you want.
Before
I'm hoping #29425 will make this test show up as a fail. I've been seeing it in another environment.
After
Technical Details
I'm not sure if this line was added to solve some problem at the time, but the test doesn't start its own output buffer. Even if there is another one somewhere, it shouldn't be flushed here. It doesn't seem needed locally.
Comments