Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theming - Allow manipulation of Angular CSS #30397

Merged
merged 1 commit into from
Jun 11, 2024

Conversation

totten
Copy link
Member

@totten totten commented Jun 11, 2024

Overview

The Theming subsystem allows themes to do things like:

  • Override a CSS file (by creating an eponymous CSS file)
  • Exclude a CSS file (by declaring the excludes list in hook_civicrm_themes)

This was originally implemented when all screens used QuickForm. We now also have screens implemented as Angular modules. They have declarations like:

// FILE: ang/api4Explorer.ang.php 
return [
  ...
  'css' => [
    'css/api4-explorer.css',
  ],
  ...
];

As a themer, you would expect the CSS overrides to work the same way for QuickForm pages and Angular pages.

Steps to Reproduce

  • Take an existing theme
  • Add a file css/api4-explorer.css. Fill it with dummy content.
  • Open "APIv4 Explorer"
  • View the source. Find where includes api4-explorer.css.

Before

  • Overrides and exclusions for Angular CSS are quietly ignored.
  • The example api4-explorer.css is loaded from civicrm-core.

After

  • Overrides and exclusions for Angular CSS work.
  • The example api4-explorer.css is loaded from your theme.

Copy link

civibot bot commented Jun 11, 2024

🤖 Thank you for contributing to CiviCRM! ❤️ We will need to test and review this PR. 👷

Introduction for new contributors...
  • If this is your first PR, an admin will greenlight automated testing with the command ok to test or add to whitelist.
  • A series of tests will automatically run. You can see the results at the bottom of this page (if there are any problems, it will include a link to see what went wrong).
  • A demo site will be built where anyone can try out a version of CiviCRM that includes your changes.
  • If this process needs to be repeated, an admin will issue the command test this please to rerun tests and build a new demo site.
  • Before this PR can be merged, it needs to be reviewed. Please keep in mind that reviewers are volunteers, and their response time can vary from a few hours to a few weeks depending on their availability and their knowledge of this particular part of CiviCRM.
  • A great way to speed up this process is to "trade reviews" with someone - find an open PR that you feel able to review, and leave a comment like "I'm reviewing this now, could you please review mine?" (include a link to yours). You don't have to wait for a response to get started (and you don't have to stop at one!) the more you review, the faster this process goes for everyone 😄
  • To ensure that you are credited properly in the final release notes, please add yourself to contributor-key.yml
  • For more information about contributing, see CONTRIBUTING.md.
Quick links for reviewers...

➡️ Online demo of this PR 🔗

@civibot civibot bot added the master label Jun 11, 2024
@vingle
Copy link
Contributor

vingle commented Jun 11, 2024

This works for me. And, most !importantly, helps remove something !important, that themers are forced to use.

@mattwire mattwire merged commit 0256610 into civicrm:master Jun 11, 2024
1 check passed
@totten totten deleted the 5.75-angular-theming branch June 11, 2024 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants