Add & populate new fields on ciivcrm_mailing - start_date, end_date, status (allows deleting of completed civicrm_mailing_job records) #30458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🤖 Thank you for contributing to CiviCRM! ❤️ We will need to test and review this PR. 👷 Introduction for new contributors...
Quick links for reviewers...
|
eileenmcnaughton
force-pushed
the
mailing_up
branch
from
50ab897
to
100ba13
Compare
| public static function updateNewCiviMailFields(CRM_Queue_TaskContext $ctx): bool { | ||
| [$minId, $maxId] = CRM_Core_DAO::executeQuery("SELECT coalesce(min(id),0), coalesce(max(id),0) | ||
| FROM civicrm_mailing ")->getDatabaseResult()->fetchRow(); | ||
| for ($startId = $minId; $startId <= $maxId; $startId += self::MAILING_BATCH_SIZE) { |
There was a problem hiding this comment.
@eileenmcnaughton I think for the upgrade tests we need to handle where $minId and $maxId == 0
eileenmcnaughton
force-pushed
the
mailing_up
branch
2 times, most recently
from
f041b8e
to
065d3ef
Compare
eileenmcnaughton
force-pushed
the
mailing_up
branch
from
065d3ef
to
ba33083
Compare
|
@stesi561 - are you still up for taking a look at this |
|
Sorry too busy today but @jitendrapurohit can probably look at when he's online later today. |
|
thanks @stesi561 @jitendrapurohit |
|
@eileenmcnaughton Have tested this on a site with ~3K rows in mailing table and 13K rows in mailing_job. The upgrade ran fine and dont see any issues after the upgrade. Thanks. |
jitendrapurohit
approved these changes
Jun 28, 2024
|
thanks @jitendrapurohit - merging based on @jitendrapurohit's review |
This was referenced Jul 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Builds on #27559 but adds the upgrade script - I think the other is possibly mergeable now but the upgrade script might take a bit more
Before
What is the old user-interface or technical-contract (as appropriate)?
For optimal clarity, include a concrete example such as a screenshot, GIF (LICEcap, SilentCast), or code-snippet.
After
What changed? What is new old user-interface or technical-contract?
For optimal clarity, include a concrete example such as a screenshot, GIF (LICEcap, SilentCast), or code-snippet.
Technical Details
If the PR involves technical details/changes/considerations which would not be manifest to a casual developer skimming the above sections, please describe the details here.
Comments
Anything else you would like the reviewer to note