Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create Share the CTI Page #318

Closed
2 tasks done
kevinashworth opened this issue Feb 12, 2021 · 5 comments
Closed
2 tasks done

Create Share the CTI Page #318

kevinashworth opened this issue Feb 12, 2021 · 5 comments
Labels
p-feature: share Everything related to Share the CTI page role: front end size: missing

Comments

@kevinashworth
Copy link
Member

kevinashworth commented Feb 12, 2021 •
edited by Olivia-Chiong
Loading

Overview

The design in Figma is ready to begin building the "Share the CTI" page.

Action Items

  • Create the "Share the CTI" page using our Material-UI best practices. (Either build the whole page, or build it partially and also create additional GitHub issue(s) to complete it later.)
  • Link the new page into the site.

Resources/Instructions

https://www.figma.com/file/EFoSuj1b9G4aZ7bN8OX8tf/?node-id=4747%3A20185
@nrrao nrrao self-assigned this Feb 14, 2021
@kevinashworth kevinashworth mentioned this issue Feb 14, 2021
Open
@kevinashworth kevinashworth added the p-feature: share Everything related to Share the CTI page label Feb 15, 2021
@nrrao
Copy link
Member

nrrao commented Feb 21, 2021

progress: building the page
blocks: none
Availability: Medium
ETA: one week

@nrrao
Copy link
Member

nrrao commented Feb 25, 2021

progress: finished building desktop page
blocks: none
Availability: Medium
ETA: one week

screencapture-sharethecti

@Olivia-Chiong
Copy link
Member

Olivia-Chiong commented Feb 26, 2021 •
edited
Loading

@Olivia-Chiong will discuss with design on Tweets to be embedded

In the meantime, @nrrao please include a Google Drive link for the assets/branding kit.

@Olivia-Chiong Olivia-Chiong self-assigned this Feb 26, 2021
@nrrao
Copy link
Member

nrrao commented Mar 5, 2021 •
edited
Loading

I have made PR

Olivia-Chiong pushed a commit that referenced this issue Mar 5, 2021
@nrrao
Create Share the CTI page(#318) (#378)
833f9a1 
* added initial file

* static page

* fixed button link

* added spec page

* changed test file

* fixed duplicate code

Code climate errors are small and can be ignored. Merged as requested.
@nrrao nrrao mentioned this issue Mar 7, 2021
Merged
@nrrao
Copy link
Member

nrrao commented Mar 7, 2021

PR is merged this issue can be closed.

kevinashworth added a commit that referenced this issue Mar 7, 2021
@kevinashworth
Merge branch 'main' into add-refine-results-333
5b96fdc 
* main:
  Refactor NavBreadcrumbs with Material UI (#327) (#377)
  Create Share the CTI page(#318) (#378)
  Refactor donation page with Material UI (#372)
  move material-ui-popup-state in package.json (#376)
  Guides: unique URL per guide (#366)
  Remove non Material-UI styling packages (#365)
  Add an Effect Hook to set document title on selected Routes (#364)

# Conflicts:
#	src/App.js
#	src/pages/Projects.js
#	src/theme-mui.js
@github-project-automation github-project-automation bot moved this to New Issue Approval (All new issues should be added to this column) in CTI: Project Board Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
p-feature: share Everything related to Share the CTI page role: front end size: missing
Projects
CTI: Project Board
Status: New Issue Approval (All new issues should be added to this column)
Milestone
No milestone
Development

No branches or pull requests
5 participants
@kevinashworth @nrrao @ExperimentsInHonesty @Olivia-Chiong @mariastudnicka