Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix esri secret setting #315

Merged
merged 1 commit into from
May 3, 2024
Merged

Fix esri secret setting #315

merged 1 commit into from
May 3, 2024

Conversation

rockycodes
Copy link
Contributor

@rockycodes rockycodes commented May 3, 2024

Description

bin/setup is currently throwing an error because AWS is unable to find the secret named esri_arcgis_api_token_secret. That's because it needs to be pre-pended with civiform which is set here. This pr fixes that.

Checklist

General

  • Added the correct label
  • Assigned to a specific person or civiform/deployment-system
  • Performed manual testing (at a minimum run bin/setup without your changes and then bin/deploy with your changes to ensure your changes don't break existing deployments)
  • Extended the README / documentation, if necessary (need to extend docs on secrets, will do that as a fast follow)

Instructions for manual testing

Run bin/setup from this branch.

Issue(s) this completes

Fixes civiform/civiform#7407

@rockycodes rockycodes added the bug Something isn't working label May 3, 2024
@rockycodes rockycodes merged commit d11b616 into main May 3, 2024
5 checks passed
@rockycodes rockycodes deleted the rockycodes/secret-bug-fix branch May 3, 2024 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bin/setup is throwing an error when setting secrets
2 participants