Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH Python 2 compatibility #57

Merged
merged 9 commits into from
Aug 24, 2017
Merged

ENH Python 2 compatibility #57

merged 9 commits into from
Aug 24, 2017

Conversation

beckermr
Copy link
Contributor

@beckermr beckermr commented Aug 23, 2017

This PR adds Python 2 compatibility.

@beckermr
Copy link
Contributor Author

beckermr commented Aug 24, 2017

@mheilman This one is good to go. There are a lot of minor changes to get python 2 and 3 to play nice.

@beckermr
Copy link
Contributor Author

I am having IT turn off circleCI.

@beckermr
Copy link
Contributor Author

IT turned off Circle. It status will never report as OK. Let's go ahead with CR when you have a chance.

Copy link
Contributor

@mheilman mheilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@beckermr beckermr merged commit 0977c9a into master Aug 24, 2017
@beckermr beckermr deleted the python2 branch August 24, 2017 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants