Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed error message for deleting k8 app #293

Merged
merged 2 commits into from
Jan 5, 2023

Conversation

satakshigarg
Copy link
Contributor

Replaced the older error message for missing uninstall scripts with better error.
Signed-off-by: satakshigarg satakshi@civo.com

Signed-off-by: satakshigarg <satakshi@civo.com>
Copy link
Member

@alessandroargentieri alessandroargentieri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a change

cmd/kubernetes/kubernetes_app_remove.go Outdated Show resolved Hide resolved
Signed-off-by: satakshigarg <satakshi@civo.com>
Copy link
Member

@alessandroargentieri alessandroargentieri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alessandroargentieri alessandroargentieri merged commit edaad63 into master Jan 5, 2023
@satakshigarg satakshigarg deleted the Uninstall_Script branch January 5, 2023 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants