Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improvement] Get Volume data-source improvement #177

Merged
merged 1 commit into from
Apr 27, 2023
Merged

[Improvement] Get Volume data-source improvement #177

merged 1 commit into from
Apr 27, 2023

Conversation

pratikmota
Copy link
Contributor

Changes:

  1. Adding nil pointer check for volume data source
  2. changing spelling mistake for retrieve
  3. Adding output in data-source.tf

  • BEFORE data-source.tf file change it was not displaying any output of volume.
    image

  • AFTER data-source.tf file change it is displaying returned output- which will be useful for civo terraform users
    image

Motivation:
Improve civo terraform project for end users

@alejandrojnm alejandrojnm merged commit f1c431e into civo:master Apr 27, 2023
@pratikmota pratikmota deleted the pratik/volume-datasource-improvement branch April 27, 2023 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alejandrojnm alejandrojnm alejandrojnm approved these changes

@alessandroargentieri alessandroargentieri Awaiting requested review from alessandroargentieri alessandroargentieri is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pratikmota @alejandrojnm