Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty link can be created but not destroyed #11

Closed
lilyball opened this issue Jan 4, 2022 · 1 comment
Closed

Empty link can be created but not destroyed #11

lilyball opened this issue Jan 4, 2022 · 1 comment

Comments

@lilyball
Copy link

lilyball commented Jan 4, 2022

I can create a link with an empty name by specifying { "name": "" } as my input. this link doesn't appear to do anything (it doesn't affect the root redirection). But unfortunately I can't delete it, because I can't name it.

Expected behavior:

I expected the POST with { "name": "" } to either fail, or to behave as though "name" were not specified (i.e. generate a random name). I should not be able to create a link with no name.

My preferred behavior is "behave as though 'name' wasn't specified". That makes it a bit easier to script the API since I don't need to conditionally include the name field.

@cjdenio cjdenio closed this as completed in caa01ef Jan 4, 2022
@cjdenio
Copy link
Owner

cjdenio commented Jan 4, 2022

Thanks for catching this! { "name": "" } should now behave as if it were null (generate a random ID).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants