-
Notifications
You must be signed in to change notification settings - Fork 31
Added karma notifications #880
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works on Linux under KDE. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Possible workaround: const notifier = require( 'node-notifier' );
const isWindowsNotifier = notifier.Notification === notifier.WindowsToaster;
if ( isWindowsNotifier ) {
const originalNotify = notifier.notify;
notifier._notify = notifierOptions => originalNotify( {
...notifierOptions,
appID: 'karma-notify-reporter'
} );
} |
☝️ To avoid workarounds, we've decided to implement a custom notifier instead. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Feature (tests): Added karma notification for when the tests are completed. Notification can be enabled with
-n
/--notify
CLI option. Its enabled by default when running all tests, without the-f
/--files
option. Closes ckeditor/ckeditor5#13736.Additional information
(This happened on Windows 10)
I've encountered a small issue where the first attempt to use the notifier did not work, and only following attempts worked successfully. It happened when I've started with hard-coded value:
reporters: [ 'progress', 'notify' ]
, so it might not be an issue.Reviewers should make sure that the current setup works on first try.