Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Undo leaks one element (which should be removed when undoing but isn't) #1540

Closed
Reinmar opened this issue Feb 18, 2019 · 2 comments
Closed

Undo leaks one element (which should be removed when undoing but isn't) #1540

Reinmar opened this issue Feb 18, 2019 · 2 comments
Assignees
@scofalik
Labels
package:engine package:undo type:bug This issue reports a buggy (incorrect) behavior.
Milestone
iteration 22

Comments

@Reinmar
Copy link
Member

Reinmar commented Feb 18, 2019

feb-18-2019 09-59-41

  1. Remove all contents.
  2. Paste a couple of blocks.
  3. Press ctrl+a.
  4. Paste the same content again.
  5. Undo twice.

Expected: empty editor.

Actual: the last block is still visible.
@Reinmar Reinmar added type:bug This issue reports a buggy (incorrect) behavior. package:engine package:undo status:confirmed labels Feb 18, 2019
@Reinmar Reinmar added this to the iteration 23 milestone Feb 18, 2019
@Reinmar Reinmar mentioned this issue Feb 18, 2019
Merged
@Reinmar
Copy link
Member Author

Reinmar commented Feb 18, 2019

This is not a regression and I don't think this is causing some crashes, but it seems quite easy to reproduce.

@scofalik
Copy link
Contributor

The problem occurs just for two block elements (two paragraphs are enough).

@scofalik scofalik mentioned this issue Feb 18, 2019
Merged
Reinmar added a commit to ckeditor/ckeditor5-engine that referenced this issue Feb 19, 2019
@Reinmar
Merge pull request #1683 from ckeditor/t/ckeditor5/1540
08855d3 
Fix: All content is properly removed after undoing paste in some scenarios. Closes [ckeditor/ckeditor5#1540](ckeditor/ckeditor5#1540).
@Reinmar Reinmar modified the milestones: iteration 23, iteration 22 Feb 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@scofalik scofalik

Labels
package:engine package:undo type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Milestone
iteration 22
Development

No branches or pull requests
2 participants
@Reinmar @scofalik