Aligned the TypeScript configuration to changes in CKEditor 5 #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All the changes are needed because the updated |
psmyrek
reviewed
Aug 30, 2023
packages/ckeditor5-package-generator/lib/templates/ts/sample/index.html
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Other (generator): Aligned the produced configuration to changes in CKEditor 5. See ckeditor/ckeditor5#14173. Closes #160.
Feature (tools): Karma will use the
tsconfig.test.jsonfile as a TypeScript configuration if it exists when executing automated tests. By default, it fallbacks totsconfig.jsonfile.MINOR BREAKING CHANGE (tools): The
typescript()function exported from thewebpack-utilsmodule requires passing thecwdas the first argument. Optionally, you can pass the TypeScript configuration file name that should be used when processing TS files byts-loader.Additional information
This PR bases on ckeditor/ckeditor5#14808.
Supported scopes
generator→ https://www.npmjs.com/package/ckeditor5-package-generator*→ https://www.npmjs.com/package/@ckeditor/ckeditor5-package-*