Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correcting spelling in list throws error #9325

Closed
launchargybargy opened this issue Mar 22, 2021 · 1 comment · Fixed by #9688
Closed

Correcting spelling in list throws error #9325

launchargybargy opened this issue Mar 22, 2021 · 1 comment · Fixed by #9688
Assignees
Labels
package:list squad:core Issue to be handled by the Core team. type:bug This issue reports a buggy (incorrect) behavior.

Comments

@launchargybargy
Copy link

📝 Provide detailed reproduction steps (if any)

  1. Go to https://ckeditor.com/ckeditor-5/online-builder/
  2. Select the Balloon editor
  3. Click Remove all plugins
  4. Find and add:
  • List
  • Liststyle
  • Indent
  • Font color
  1. Click Next, add font color to the toolbar
  2. Click Next Step x 2 to finish the wizard
  3. Click Start
  4. Extract the zip

Reproduction steps:

Open sample\index.html
Clear the text in the editor
Enter 'helllo', (with the incorrect spelling)
Select 'helllo' and make a bulleted list, and set a color.
Right click 'helllo', and select the suggested spelling of hello

✔️ Expected result

No errors, spelling corrected.

❌ Actual result

ckeditor.js:5 Uncaught TypeError: Cannot read property 'getStyle' of null
at um.t.on.priority (ckeditor.js:5)
at um.fire (ckeditor.js:5)
at um._convertItem (ckeditor.js:5)
at um.convert (ckeditor.js:5)
at Object.callback (ckeditor.js:5)
at eb._runPendingChanges (ckeditor.js:5)
at eb.change (ckeditor.js:5)
at bm.toModel (ckeditor.js:5)
at WC._handleContainerChildrenMutations (ckeditor.js:5)
at WC.handle (ckeditor.js:5)

📃 Other details

  • Browser: 89.0.4389.90 (Official Build) (64-bit)
  • OS: Windows 10 - 1909
  • First affected CKEditor version: ckeditor5 v3
  • Installed CKEditor plugins: list, liststyle, indent, fontColor
@launchargybargy launchargybargy added the type:bug This issue reports a buggy (incorrect) behavior. label Mar 22, 2021
@FilipTokarski
Copy link
Member

FilipTokarski commented Mar 23, 2021

Hi, thanks for the report. I can confirm this. Here's a full stack trace:

Uncaught TypeError: Cannot read property 'getStyle' of null
    at UpcastDispatcher.dispatcher.on.priority (liststyleediting.js:215)
    at UpcastDispatcher.fire (emittermixin.js:194)
    at UpcastDispatcher._convertItem (upcastdispatcher.js:249)
    at UpcastDispatcher.convert (upcastdispatcher.js:207)
    at Object.callback (datacontroller.js:424)
    at Model._runPendingChanges (model.js:830)
    at Model.change (model.js:175)
    at DataController.toModel (datacontroller.js:423)
    at MutationHandler._handleContainerChildrenMutations (injecttypingmutationshandling.js:109)
    at MutationHandler.handle (injecttypingmutationshandling.js:64)
  • it doesn't need to have FontColor plugin. It can be reproduced in any editor with ListStyle. Instead of font color you can just apply bold
  • happens since the introduction of ListStyle

@FilipTokarski FilipTokarski added squad:core Issue to be handled by the Core team. package:list labels Mar 23, 2021
@AnnaTomanek AnnaTomanek added this to the nice-to-have milestone Mar 29, 2021
@pomek pomek self-assigned this May 13, 2021
@pomek pomek modified the milestones: nice-to-have, iteration 43 May 13, 2021
psmyrek added a commit that referenced this issue May 14, 2021
Fix (list): Fixed a crash when spelling a word inside the list item. Closes #9325.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package:list squad:core Issue to be handled by the Core team. type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants