Code

Dialogs system implementation#15285

Code

Merged

scofalik merged 206 commits intomasterckeditor/ckeditor5:masterfrom ck/14973-dialogsckeditor/ckeditor5:ck/14973-dialogsCopy head branch name to clipboardJan 9, 2024

+6,962-939

Commits

Commits on Aug 10, 2023

• Migrated the Modal plugin from the old PoC.

  oleq

  committed
  d33a7f8

  Copy full SHA for d33a7f8

• Migrated find and replace to a dialog.

  oleq

  committed
  f2f8095

  Copy full SHA for f2f8095

• Migrated special characters to a dialog.

  oleq

  committed
  156d8a8

  Copy full SHA for 156d8a8

• Migrated media embed to a dialog.

  oleq

  committed
  0ead72f

  Copy full SHA for 0ead72f

• Added PoC of an in-dialog source editing.

  oleq

  committed
  2e62786

  Copy full SHA for 2e62786

Commits on Aug 11, 2023

• Made the FocusCycler fire events when a new cycle begins.

  oleq

  committed
  13bbe25

  Copy full SHA for 13bbe25

• Code refactoring: Split the modal plugin into a plugin and separate views. Brought support for focus cycling integration with child views.

  oleq

  committed
  47057f9

  Copy full SHA for 47057f9

• Integrated find and replace, media embed, source editing, and special characters with in-modal focus tracking.

  oleq

  committed
  c9a4615

  Copy full SHA for c9a4615

• Fixed a bug with special characters info bar getting squashed on mobiles.

  oleq

  committed
  1fd180c

  Copy full SHA for 1fd180c

• Tests.

  oleq

  committed
  ac2c8ac

  Copy full SHA for ac2c8ac

Commits on Oct 30, 2023

• Merge remote-tracking branch 'origin' into ci/2326-modal-poc-revival

  oleq

  committed
  c531114

  Copy full SHA for c531114

• Aligned the prototype to the latest focus cycler API.

  oleq

  committed
  2fc7b07

  Copy full SHA for 2fc7b07

Commits on Oct 31, 2023

• Renamed modal -> dialog.

  oleq

  committed
  0a22131

  Copy full SHA for 0a22131

• Extracted the dialog draggable feature to the generic DraggableViewMixin.

  oleq

  committed
  eeb1f1f

  Copy full SHA for eeb1f1f

• Code refactoring and clean-up in dialog classes.

  oleq

  committed
  962e7ef

  Copy full SHA for 962e7ef

• Used TextareaView component in the in-dialog source editing feature.

  oleq

  committed
  6d5c4e0

  Copy full SHA for 6d5c4e0

• Code refactoring. Aligned feature dialog integration to the latest Dialog API.

  oleq

  committed
  51e5d75

  Copy full SHA for 51e5d75

• Made Dialog draggable by default. Code refactoring in the manual test.

  oleq

  committed
  4938fc6

  Copy full SHA for 4938fc6

• Code refactoring.

  oleq

  committed
  7e03dcf

  Copy full SHA for 7e03dcf

Commits on Nov 2, 2023

• Code refactoring.

  oleq

  committed
  a7de287

  Copy full SHA for a7de287

• Decoupled the dialog drag logic and the dialog header logic. Made the entire Dialog a DraggableView. Improved performance of the DraggableViewMixin.

  oleq

  committed
  59c92a6

  Copy full SHA for 59c92a6

Commits on Nov 13, 2023

• Merge branch 'master' into ck/14973-dialogs

  oleq

  committed
  d1ac32c

  Copy full SHA for d1ac32c

• Renamed --ck-z-modal to --ck-z-panel. Introduced --ck-z-dialog.

  oleq

  committed
  674cfac

  Copy full SHA for 674cfac

• Renamed the #isDraggable configuration property in Dialog#show() to #isModal.

  oleq

  committed
  f332880

  Copy full SHA for f332880

• Added extra configuration options to Dialog#show() to improve the DX and simplify dialog creation for most integrators.

  oleq

  committed
  a227ec2

  Copy full SHA for a227ec2

Commits on Nov 14, 2023

• WIP: Initial dialog position implementation.

  oleq

  committed
  458523b

  Copy full SHA for 458523b

Commits on Nov 15, 2023

• Constrained dialog position to the viewport.

  oleq

  committed
  28feff6

  Copy full SHA for 28feff6

• Code refactoring in the manual test.

  oleq

  committed
  54a12dc

  Copy full SHA for 54a12dc

Commits on Nov 16, 2023

• Integrated the ClassicEditor's sticky panel with the Dialog system to ensure dialogs don't obscure the panel if not positioned manually.

  oleq

  committed
  ae9a20b

  Copy full SHA for ae9a20b

• Tests: Extended the manual test.

  oleq

  committed
  4a8a7c0

  Copy full SHA for 4a8a7c0

• Tests: Update the manual test.

  oleq

  committed
  770a728

  Copy full SHA for 770a728

• Code refactoring.

  oleq

  committed
  d4d553c

  Copy full SHA for d4d553c

Commits on Nov 17, 2023

• Made focus cycling in various dialogs easier by moving the generic integration code to the DialogView class.

  oleq

  committed
  4cf6f39

  Copy full SHA for 4cf6f39

• Used the CSS visibility property instead of an absolute position to pre-render the dialog before it gets displayed to avoid uncontrolled viewport movement on iOS.

  oleq

  committed
  7120447

  Copy full SHA for 7120447

• Merge pull request #15348 from ckeditor/ck/14973-dialogs-initial-position

  Show description for 106b512
  scofalik

  authored
  106b512

  Copy full SHA for 106b512

Commits on Nov 18, 2023

• Merge branch 'ck/14973-dialogs' into ck/14973-dialogs-easier-focus-cycling

  scofalik

  authored
  7f73e41

  Copy full SHA for 7f73e41

• Merge pull request #15369 from ckeditor/ck/14973-dialogs-easier-focus-cycling

  Show description for 57c30ba
  scofalik

  authored
  57c30ba

  Copy full SHA for 57c30ba

Commits on Nov 20, 2023

• Undo the features integration besides the find and replace.

  Dumluregn

  committed
  2c9b3e1

  Copy full SHA for 2c9b3e1

Commits on Nov 21, 2023

• Extract DialogDefinition type.

  Dumluregn

  committed
  fbc8f1b

  Copy full SHA for fbc8f1b

• Add a comment regarding the focus cycling.

  Dumluregn

  committed
  8db4fe3

  Copy full SHA for 8db4fe3

• Renames.

  Dumluregn

  committed
  360b197

  Copy full SHA for 360b197

• Add comment about focusing.

  Dumluregn

  committed
  3f42e0e

  Copy full SHA for 3f42e0e

• Make modals draggable and ditch isDraggable prop.

  Dumluregn

  committed
  9a84e00

  Copy full SHA for 9a84e00

• Drop unnecessary CSS rule.

  Dumluregn

  committed
  017f080

  Copy full SHA for 017f080

• Rename dragging coordinates related stuff.

  Dumluregn

  committed
  c54a4b2

  Copy full SHA for c54a4b2

• Update comment.

  Dumluregn

  committed
  1fe515b

  Copy full SHA for 1fe515b

• Decorate show() and hide() dialog methods with events.

  Dumluregn

  committed
  51062c4

  Copy full SHA for 51062c4

• Small refactors.

  Dumluregn

  committed
  11de6a5

  Copy full SHA for 11de6a5

• Introduce Dialog._isOpen property.

  Dumluregn

  committed
  dbe9362

  Copy full SHA for dbe9362

• Get rid of the Dialog#setTitle method.

  Dumluregn

  committed
  f645209

  Copy full SHA for f645209

Commits on Nov 22, 2023

• Remove outdated todo.

  Dumluregn

  committed
  1bfaf51

  Copy full SHA for 1bfaf51

• Make isDragging a public observable.

  Dumluregn

  committed
  1e94152

  Copy full SHA for 1e94152

• Change some props visibility.

  Dumluregn

  committed
  eab853f

  Copy full SHA for eab853f

• Fix the dialog view parts and children.

  Dumluregn

  committed
  bebd50a

  Copy full SHA for bebd50a

Commits on Nov 23, 2023

• Make a public observable.

  Dumluregn

  committed
  c5b6af8

  Copy full SHA for c5b6af8

• Add id to the dialogDefinition.

  Dumluregn

  committed
  9b0022b

  Copy full SHA for 9b0022b

• Add more available dialog positions.

  Dumluregn

  committed
  d4918e3

  Copy full SHA for d4918e3

• Add more testing buttons.

  Dumluregn

  committed
  4832012

  Copy full SHA for 4832012

• Add bottom toolbar editor demo and fix EDITOR_TOP_SIDE position.

  Dumluregn

  committed
  2049a27

  Copy full SHA for 2049a27

• Merge branch 'master' into ck/14973-dialogs

  Dumluregn

  committed
  fba4be2

  Copy full SHA for fba4be2

Commits on Nov 24, 2023

• More or less working draft.

  Dumluregn

  committed
  99a30af

  Copy full SHA for 99a30af

• Fix communication between editors.

  Dumluregn

  committed
  d9de8a2

  Copy full SHA for d9de8a2

• Fix displaying dialogs after opening them multiple times.

  Dumluregn

  committed
  63bf891

  Copy full SHA for 63bf891

Commits on Nov 27, 2023

• Introduce the 'on' button state.

  Dumluregn

  committed
  3f63a2a

  Copy full SHA for 3f63a2a

• Fix integration with sticky toolbar.

  Dumluregn

  committed
  9261be3

  Copy full SHA for 9261be3

• Merge branch 'master' into ck/14973-dialogs

  oleq

  committed
  901d00c

  Copy full SHA for 901d00c

• Merge branch 'ck/14973-dialogs' into ck/dialogs-single-instance

  oleq

  committed
  1503736

  Copy full SHA for 1503736

• Used a static refence to the Dialog plugin to manage dialog interactions between multiple editors. Ensured the view injected into a dialog survives dialog destruction process (re-usablity). Streaml…

  Show description for b8329df
  oleq

  committed
  b8329df

  Copy full SHA for b8329df

• Add toggleability to the f&r toolbar button.

  Dumluregn

  committed
  ad356e2

  Copy full SHA for ad356e2

• Add multiroot editor to demo.

  Dumluregn

  committed
  adc53fc

  Copy full SHA for adc53fc

Commits on Nov 28, 2023

• Ensured the dialog view is removed from the body collection and the global focus tracker when it gets hidden.

  oleq

  committed
  5682e27

  Copy full SHA for 5682e27

• Code refactoring.

  oleq

  committed
  6991ebf

  Copy full SHA for 6991ebf

• Made the DialogView method to update its position public.

  oleq

  committed
  66c5bc9

  Copy full SHA for 66c5bc9

• Docs.

  oleq

  committed
  5c1b140

  Copy full SHA for 5c1b140

• Merge pull request #15417 from ckeditor/ck/dialogs-single-instance

  Show description for e874486
  oleq

  authored
  e874486

  Copy full SHA for e874486

• Merge branch 'ck/14973-dialogs' into ck/dialogs-multiroot

  Dumluregn

  committed
  04030c8

  Copy full SHA for 04030c8

• Handle root attaching/detaching.

  Dumluregn

  committed
  23a3245

  Copy full SHA for 23a3245

• Tests: Added dialog sub-class test skeletons.

  oleq

  committed
  601d99c

  Copy full SHA for 601d99c

• Moved the dialog and multi-root integration to the Dialog and built it on top of differ to avoid a direct coupling with MultiRootEditor.

  oleq

  committed
  cc3169d

  Copy full SHA for cc3169d

• Merge pull request #15421 from ckeditor/ck/dialogs-multiroot

  Show description for 479d323
  oleq

  authored
  479d323

  Copy full SHA for 479d323

• Merge branch 'ck/14973-dialogs' into ck/14973-dialogs-unit-tests

  oleq

  committed
  98b184d

  Copy full SHA for 98b184d

• Allowed configurable find and replace UI type (drop-down or dialog).

  oleq

  committed
  d139dda

  Copy full SHA for d139dda

• Merge branch 'ck/14973-dialogs' into ck/14973-dialogs-unit-tests

  oleq

  committed
  2e51f8d

  Copy full SHA for 2e51f8d

• Tests: DialogView unit tests wire frame.

  oleq

  committed
  b2e6d10

  Copy full SHA for b2e6d10

Commits on Nov 29, 2023

• Add tests for dialog.ts.

  Dumluregn

  committed
  da96e0d

  Copy full SHA for da96e0d

Commits on Nov 30, 2023

• Tests: Added DialogView tests.

  oleq

  committed
  c45d311

  Copy full SHA for c45d311

• Add coverage for draggableviewmixin.ts.

  Dumluregn

  committed
  46cd4d8

  Copy full SHA for 46cd4d8

• Tests: Added tests for the integration between the Dialog plugin and ClassicEditor's sticky panel (toolbar).

  oleq

  committed
  230417d

  Copy full SHA for 230417d

• Add focuscycler.ts coverage.

  Dumluregn

  committed
  7287369

  Copy full SHA for 7287369

• Tests: Added tests for the DialogContentView class.

  oleq

  committed
  39b03c0

  Copy full SHA for 39b03c0

• Tests: Updated StickyPanelView after StickyPanelView#_contentPanel became StickyPanelView#contentPanelElement.

  oleq

  committed
  cf4c647

  Copy full SHA for cf4c647

• Typings for event listeners.

  oleq

  committed
  abdf143

  Copy full SHA for abdf143

Commits on Dec 1, 2023

• Tests: Added a manual test for DraggableViewMixin.

  oleq

  committed
  a3bf160

  Copy full SHA for a3bf160

• Marked several DialogView methods as internal to exclude them from the public API.

  oleq

  committed
  ed28362

  Copy full SHA for ed28362

• Add coverage for DialogActionsView.

  Dumluregn

  committed
  201e66a

  Copy full SHA for 201e66a

• Add missing multiroot test.

  Dumluregn

  committed
  6ac7aee

  Copy full SHA for 6ac7aee

• Increase tooltip z-index to keep it visible over the dialog.

  Dumluregn

  committed
  a28dbd2

  Copy full SHA for a28dbd2

• Merge pull request #15438 from ckeditor/ck/14973-dialogs-unit-tests

  Show description for 3765442
  oleq

  authored
  3765442

  Copy full SHA for 3765442

• Merge branch 'master' into ck/14973-dialogs

  oleq

  committed
  10ad3ba

  Copy full SHA for 10ad3ba

• Move switchbuttons to the main view.

  Dumluregn

  committed
  b38d02b

  Copy full SHA for b38d02b

• Extract CollapsibleView to UI package.

  Dumluregn

  committed
  82bfba5

  Copy full SHA for 82bfba5

Commits on Dec 4, 2023

• Move switchbuttons to the collapsible.

  Dumluregn

  committed
  b012363

  Copy full SHA for b012363

• Improve switchbuttons styling.

  Dumluregn

  committed
  b814ac5

  Copy full SHA for b814ac5

• Cleanup.

  Dumluregn

  committed
  da22b28

  Copy full SHA for da22b28

• Fix focus cycling.

  Dumluregn

  committed
  e5897d1

  Copy full SHA for e5897d1

• Reverse the action buttons order.

  Dumluregn

  committed
  26778f8

  Copy full SHA for 26778f8

• Refactor.

  Dumluregn

  committed
  885b958

  Copy full SHA for 885b958

• Merge branch 'ck/14973-dialogs' into ck/14973-dialogs-f&r-redesigned

  Dumluregn

  committed
  db8214f

  Copy full SHA for db8214f

Commits on Dec 5, 2023

• Fix the ui-dropdown-panel-focus-child-missing-focus warning.

  Dumluregn

  committed
  e438066

  Copy full SHA for e438066

• Fix canceling the fire event if toolbar button is disabled.

  Dumluregn

  committed
  317602d

  Copy full SHA for 317602d

• Fix and add all tests besides findandreplaceformview.

  Dumluregn

  committed
  19d812a

  Copy full SHA for 19d812a

• Finish fixing the tests.

  Dumluregn

  committed
  e0fc29e

  Copy full SHA for e0fc29e

Commits on Dec 6, 2023

• Fix displaying the replace input.

  Dumluregn

  committed
  a270e56

  Copy full SHA for a270e56

• Replace the fieldset elements with divs.

  Dumluregn

  committed
  929ff29

  Copy full SHA for 929ff29

• Make focus test more stable on CI.

  Dumluregn

  committed
  519bdf6

  Copy full SHA for 519bdf6

Commits on Dec 7, 2023

• Add missing API docs in the dialog UI component [skip ci].

  Dumluregn

  committed
  6cc4475

  Copy full SHA for 6cc4475

• Merge branch 'ck/14973-dialogs' into ck/14973-dialogs-f&r-redesigned

  Dumluregn

  committed
  8d360f1

  Copy full SHA for 8d360f1

• Add missing API docs [skip ci].

  Dumluregn

  committed
  5ad0943

  Copy full SHA for 5ad0943

• Merge pull request #15441 from ckeditor/ck/14973-dialogs-tooltip-visibility

  Show description for 3fd8384
  oleq

  authored
  3fd8384

  Copy full SHA for 3fd8384

• Merge branch 'master' into ck/14973-dialogs

  oleq

  committed
  f47b89f

  Copy full SHA for f47b89f

• WIP: 9ea94d4 Merge pull request #15434 from ckeditor/ck/15298

  oleq

  committed
  8b9e0d0

  Copy full SHA for 8b9e0d0

• Resolved duplicated re-exports in the ui package.

  oleq

  committed
  b268972

  Copy full SHA for b268972

• Enabled styles in the find and replace form view styles that were missing a parent selector.

  oleq

  committed
  9f0f8c3

  Copy full SHA for 9f0f8c3

• Minor code refactoring.

  oleq

  committed
  61cf38b

  Copy full SHA for 61cf38b

• Deferred FindAndReplaceFormView creation to the moment the dialog is about to show up.

  oleq

  committed
  b47f62b

  Copy full SHA for b47f62b

• Tests: Minor code refactoring.

  oleq

  committed
  737d850

  Copy full SHA for 737d850

• Tests: Added a test that asserts deferred form creation with in-dialog configuration.

  oleq

  committed
  2d1a2d7

  Copy full SHA for 2d1a2d7

• Add a keystroke to toggle focus between the editor and the dialog.

  Dumluregn

  committed
  a034999

  Copy full SHA for a034999

• Add label for the screen readers.

  Dumluregn

  committed
  c668829

  Copy full SHA for c668829

• Add test coverage.

  Dumluregn

  committed
  d62ea90

  Copy full SHA for d62ea90

• Add missing unit test.

  Dumluregn

  committed
  ac16fb1

  Copy full SHA for ac16fb1

Commits on Dec 8, 2023

• Merge branch 'master' into ck/14973-dialogs

  oleq

  committed
  8e42a71

  Copy full SHA for 8e42a71

• Merge branch 'ck/14973-dialogs' into ck/14973-dialogs-f&r-redesigned

  oleq

  committed
  02f504f

  Copy full SHA for 02f504f

• Merge pull request #15457 from ckeditor/ck/14973-dialogs-f&r-redesigned

  Show description for dc47ad7
  oleq

  authored
  dc47ad7

  Copy full SHA for dc47ad7

• Fix failing test.

  Dumluregn

  committed
  b5e7f0f

  Copy full SHA for b5e7f0f

• Enable onCreate() callback on action buttons.

  Dumluregn

  committed
  862eb42

  Copy full SHA for 862eb42

• Add test coverage.

  Dumluregn

  committed
  3afd6ba

  Copy full SHA for 3afd6ba

• Extract styles to theme.

  Dumluregn

  committed
  141df67

  Copy full SHA for 141df67

• Split styles into files.

  Dumluregn

  committed
  34ec624

  Copy full SHA for 34ec624

• Small improvements to the manual test.

  Dumluregn

  committed
  855458a

  Copy full SHA for 855458a

Commits on Dec 13, 2023

• Merge pull request #15496 from ckeditor/ck/14973-dialogs-fix-ci

  Show description for cdd0eb0
  oleq

  authored
  cdd0eb0

  Copy full SHA for cdd0eb0

• Merge branch 'master' into ck/14973-dialogs

  oleq

  committed
  143e2d5

  Copy full SHA for 143e2d5

• Merge branch 'ck/14973-dialogs' into ck/14973-dialogs-oncreate

  oleq

  committed
  bf59b1c

  Copy full SHA for bf59b1c

• Merge pull request #15497 from ckeditor/ck/14973-dialogs-oncreate

  Show description for d6662a8
  oleq

  authored
  d6662a8

  Copy full SHA for d6662a8

• Merge branch 'ck/14973-dialogs' into ck/14973-dialogs-lark-theme

  oleq

  committed
  7c2f63e

  Copy full SHA for 7c2f63e

• Merge branch 'ck/14973-dialogs' into ck/14973-dialogs-a11y

  Dumluregn

  committed
  a74c10a

  Copy full SHA for a74c10a

• Review fixes.

  Dumluregn

  committed
  11c4303

  Copy full SHA for 11c4303

• Extracted several dialog CSS property values to custom properties to allow for easier customization.

  oleq

  committed
  c968fe5

  Copy full SHA for c968fe5

• Merge pull request #15498 from ckeditor/ck/14973-dialogs-lark-theme

  Show description for e6540de
  oleq

  authored
  e6540de

  Copy full SHA for e6540de

• Merge branch 'ck/14973-dialogs' into ck/14973-dialogs-a11y

  oleq

  committed
  f6a2b17

  Copy full SHA for f6a2b17

• Minor code refactoring.

  oleq

  committed
  1529da3

  Copy full SHA for 1529da3

• Merge pull request #15481 from ckeditor/ck/14973-dialogs-a11y

  Show description for 2075d07
  oleq

  authored
  2075d07

  Copy full SHA for 2075d07

Commits on Dec 14, 2023

• Add option for dialog header icon.

  Dumluregn

  committed
  094ba34

  Copy full SHA for 094ba34

Commits on Dec 15, 2023

• Improved TextareaView by making it update its size if its value has been change while it was invisible. Do not update DialogView's position when it is invisible.

  oleq

  committed
  9f0614c

  Copy full SHA for 9f0614c

• Merge branch 'master' into ck/14973-dialogs

  oleq

  committed
  f3c0dcc

  Copy full SHA for f3c0dcc

• Merge branch 'ck/14973-dialogs' into ck/14973-dialogs-improved-textarea-and-dialogview

  oleq

  committed
  1762466

  Copy full SHA for 1762466

• Used ResizeObserver because IntersectionObserver is acting up when it comes to absolutely positioned elements.

  oleq

  committed
  8839b41

  Copy full SHA for 8839b41

• Merge pull request #15538 from ckeditor/ck/14973-dialogs-improved-textarea-and-dialogview

  Show description for d707467
  Dumluregn

  authored
  d707467

  Copy full SHA for d707467

Commits on Dec 18, 2023

• Merge branch 'master' into ck/14973-dialogs

  Dumluregn

  committed
  8147595

  Copy full SHA for 8147595

• Unify headers.

  Dumluregn

  committed
  b10ae87

  Copy full SHA for b10ae87

• Update the find and replace ui component description.

  Dumluregn

  committed
  06ea9fd

  Copy full SHA for 06ea9fd

• Change the keystrokes handling.

  Dumluregn

  committed
  7b89d7b

  Copy full SHA for 7b89d7b

Commits on Dec 19, 2023

• Make sourceediting plugin hide the visible dialog.

  Dumluregn

  committed
  68fdd62

  Copy full SHA for 68fdd62

• Change the z-index to make ckbox dialog display over the integrated dialogs.

  Dumluregn

  committed
  57791df

  Copy full SHA for 57791df

Commits on Dec 20, 2023

• Merge pull request #15552 from ckeditor/ck/14973-dialogs-unify-headers

  Show description for d5ee1d1
  oleq

  authored
  d5ee1d1

  Copy full SHA for d5ee1d1

• Merge branch 'ck/14973-dialogs' into ck/14973-dialogs-proper-keystrokes

  oleq

  committed
  7e4395a

  Copy full SHA for 7e4395a

• Merge branch 'ck/14973-dialogs' into ck/14973-dialogs-source-mode-v2

  oleq

  committed
  3423ef8

  Copy full SHA for 3423ef8

• Restore the ctrl+f handling for dropdown from master.

  Dumluregn

  committed
  eb3a205

  Copy full SHA for eb3a205

• Tests: Added a dialog integration unit test. Code refactoring: wrapped dialog integration tests into a category.

  oleq

  committed
  070b070

  Copy full SHA for 070b070

• Merge pull request #15566 from ckeditor/ck/14973-dialogs-source-mode-v2

  Show description for f4c7f3f
  oleq

  authored
  f4c7f3f

  Copy full SHA for f4c7f3f

• Merge branch 'master' into ck/14973-dialogs

  oleq

  committed
  b379cdb

  Copy full SHA for b379cdb

• Tests: Adjusted tests to the import path changes on master.

  oleq

  committed
  f676220

  Copy full SHA for f676220

• Merge branch 'ck/14973-dialogs' into ck/14973-dialogs-proper-keystrokes

  oleq

  committed
  4117568

  Copy full SHA for 4117568

• Tests: Fixed a failing test.

  oleq

  committed
  1a29007

  Copy full SHA for 1a29007

• Code refactoring.

  oleq

  committed
  7a98e20

  Copy full SHA for 7a98e20

• Merge pull request #15553 from ckeditor/ck/14973-dialogs-proper-keystrokes

  Show description for ffe9d0b
  oleq

  authored
  ffe9d0b

  Copy full SHA for ffe9d0b

Commits on Dec 21, 2023

• Make it possible to listen on one of the close events or hide the close button.

  Dumluregn

  committed
  b39b993

  Copy full SHA for b39b993

• Merge branch 'ck/14973-dialogs' into ck/14973-dialogs-optional-close

  Dumluregn

  committed
  34bd7de

  Copy full SHA for 34bd7de

• Add short description in the manual test [skip ci].

  Dumluregn

  committed
  8ce2da1

  Copy full SHA for 8ce2da1

• Merge branch 'ck/14973-dialogs' into ck/14973-dialogs-optional-close

  oleq

  committed
  f3e8175

  Copy full SHA for f3e8175

• Add missing unit test.

  Dumluregn

  committed
  e9de3f1

  Copy full SHA for e9de3f1

Commits on Dec 22, 2023

• Merge pull request #15577 from ckeditor/ck/14973-dialogs-optional-close

  Show description for d556b9b
  oleq

  authored
  d556b9b

  Copy full SHA for d556b9b

• Fix.

  Dumluregn

  committed
  eeb0e7f

  Copy full SHA for eeb0e7f

• Improvement.

  Dumluregn

  committed
  9d6f24a

  Copy full SHA for 9d6f24a

• Add API docs.

  Dumluregn

  committed
  dee7bfd

  Copy full SHA for dee7bfd

• Merge pull request #15587 from ckeditor/ck/14973-dialogs-safari-resurrection

  Show description for aa1627c
  oleq

  authored
  aa1627c

  Copy full SHA for aa1627c

Commits on Jan 2, 2024

• Fix.

  Dumluregn

  committed
  69c5d6b

  Copy full SHA for 69c5d6b

• Enhance manual test.

  Dumluregn

  committed
  5c05756

  Copy full SHA for 5c05756

Commits on Jan 3, 2024

• Merge pull request #15614 from ckeditor/ck/14973-dialogs-cycling-fix

  Show description for d577c13
  oleq

  authored
  d577c13

  Copy full SHA for d577c13

• Docs: Fixed docs errors.

  oleq

  committed
  d84499e

  Copy full SHA for d84499e

Commits on Jan 4, 2024

• FocusCycler's focusables collection should only contain FocusableView instances.

  oleq

  committed
  0860906

  Copy full SHA for 0860906

• Merge branch 'master' into ck/14973-dialogs

  Dumluregn

  committed
  430e86a

  Copy full SHA for 430e86a

• Tests: Stabilized FocusCycler tests.

  oleq

  committed
  f0a702c

  Copy full SHA for f0a702c

• Review fixes.

  Dumluregn

  committed
  ddc7226

  Copy full SHA for ddc7226

Commits on Jan 5, 2024

• Replace the avoided operator.

  Dumluregn

  committed
  93f5fad

  Copy full SHA for 93f5fad

Commits on Jan 8, 2024

• Code refactoring.

  oleq

  committed
  607b2ad

  Copy full SHA for 607b2ad

• Docs: Migrated enums to JS objects for Umberto compatibility. Extended dialog API docs.

  

  oleq

  authored and

  Dumluregn

  committed
  4c7259c

  Copy full SHA for 4c7259c

• First batch of changes.

  Dumluregn

  committed
  6c35d6f

  Copy full SHA for 6c35d6f

• Next part of code improvements.

  Dumluregn

  committed
  eff91c8

  Copy full SHA for eff91c8

• Replace the isOpen flag with observable id.

  Dumluregn

  committed
  15d6a26

  Copy full SHA for 15d6a26

• Merge pull request #15632 from ckeditor/ck/15631-unified-focuscycler-collection

  Show description for bd80b20
  scofalik

  authored
  bd80b20

  Copy full SHA for bd80b20

• FocusCycler's #next and #previous should point to the same view even if that's the only focusable view (#15623)

  Show description for 932712a
  oleq

  authored
  932712a

  Copy full SHA for 932712a

Commits on Jan 9, 2024

• Update packages/ckeditor5-ui/src/dialog/dialog.ts

  Show description for 802c234
  

  Dumluregn

  and

  scofalik

  authored
  802c234

  Copy full SHA for 802c234

• Improve visibleDialogPlugin property.

  Dumluregn

  committed
  4420a2a

  Copy full SHA for 4420a2a

• Change the dialog plugin instance firing the event when dialog is hidden.

  Dumluregn

  committed
  2d552d3

  Copy full SHA for 2d552d3

• Enhance the test.

  Dumluregn

  committed
  142e50b

  Copy full SHA for 142e50b