Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dialogs system implementation #15285

Merged
merged 206 commits into from
Jan 9, 2024
Merged

Dialogs system implementation #15285

merged 206 commits into from
Jan 9, 2024
+6,962 −939

Commits on Aug 10, 2023

  1. Migrated the Modal plugin from the old PoC.

    @oleq
    oleq committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    d33a7f8 View commit details
    Browse the repository at this point in the history

  2. Migrated find and replace to a dialog.

    @oleq
    oleq committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    f2f8095 View commit details
    Browse the repository at this point in the history

  3. Migrated special characters to a dialog.

    @oleq
    oleq committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    156d8a8 View commit details
    Browse the repository at this point in the history

  4. Migrated media embed to a dialog.

    @oleq
    oleq committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    0ead72f View commit details
    Browse the repository at this point in the history

  5. Added PoC of an in-dialog source editing.

    @oleq
    oleq committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    2e62786 View commit details
    Browse the repository at this point in the history

Commits on Aug 11, 2023

  1. Made the FocusCycler fire events when a new cycle begins.

    @oleq
    oleq committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    13bbe25 View commit details
    Browse the repository at this point in the history

  2. Code refactoring: Split the modal plugin into a plugin and separate v… 

    …iews. Brought support for focus cycling integration with child views.
    @oleq
    oleq committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    47057f9 View commit details
    Browse the repository at this point in the history

  3. Integrated find and replace, media embed, source editing, and special… 

    … characters with in-modal focus tracking.
    @oleq
    oleq committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    c9a4615 View commit details
    Browse the repository at this point in the history

  4. Fixed a bug with special characters info bar getting squashed on mobi… 

    …les.
    @oleq
    oleq committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    1fd180c View commit details
    Browse the repository at this point in the history

  5. Tests.

    @oleq
    oleq committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    ac2c8ac View commit details
    Browse the repository at this point in the history

Commits on Oct 30, 2023

  1. Merge remote-tracking branch 'origin' into ci/2326-modal-poc-revival

    @oleq
    oleq committed Oct 30, 2023
    Configuration menu
    Copy the full SHA
    c531114 View commit details
    Browse the repository at this point in the history

  2. Aligned the prototype to the latest focus cycler API.

    @oleq
    oleq committed Oct 30, 2023
    Configuration menu
    Copy the full SHA
    2fc7b07 View commit details
    Browse the repository at this point in the history

Commits on Oct 31, 2023

  1. Renamed modal -> dialog.

    @oleq
    oleq committed Oct 31, 2023
    Configuration menu
    Copy the full SHA
    0a22131 View commit details
    Browse the repository at this point in the history

  2. Extracted the dialog draggable feature to the generic DraggableViewMi… 

    …xin.
    @oleq
    oleq committed Oct 31, 2023
    Configuration menu
    Copy the full SHA
    eeb1f1f View commit details
    Browse the repository at this point in the history

  3. Code refactoring and clean-up in dialog classes.

    @oleq
    oleq committed Oct 31, 2023
    Configuration menu
    Copy the full SHA
    962e7ef View commit details
    Browse the repository at this point in the history

  4. Used TextareaView component in the in-dialog source editing feature.

    @oleq
    oleq committed Oct 31, 2023
    Configuration menu
    Copy the full SHA
    6d5c4e0 View commit details
    Browse the repository at this point in the history

  5. Code refactoring. Aligned feature dialog integration to the latest Di… 

    …alog API.
    @oleq
    oleq committed Oct 31, 2023
    Configuration menu
    Copy the full SHA
    51e5d75 View commit details
    Browse the repository at this point in the history

  6. Made Dialog draggable by default. Code refactoring in the manual test.

    @oleq
    oleq committed Oct 31, 2023
    Configuration menu
    Copy the full SHA
    4938fc6 View commit details
    Browse the repository at this point in the history

  7. Code refactoring.

    @oleq
    oleq committed Oct 31, 2023
    Configuration menu
    Copy the full SHA
    7e03dcf View commit details
    Browse the repository at this point in the history

Commits on Nov 2, 2023

  1. Code refactoring.

    @oleq
    oleq committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    a7de287 View commit details
    Browse the repository at this point in the history

  2. Decoupled the dialog drag logic and the dialog header logic. Made the… 

    … entire Dialog a DraggableView. Improved performance of the DraggableViewMixin.
    @oleq
    oleq committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    59c92a6 View commit details
    Browse the repository at this point in the history

Commits on Nov 13, 2023

  1. Merge branch 'master' into ck/14973-dialogs

    @oleq
    oleq committed Nov 13, 2023
    Configuration menu
    Copy the full SHA
    d1ac32c View commit details
    Browse the repository at this point in the history

  2. Renamed --ck-z-modal to --ck-z-panel. Introduced --ck-z-dialog.

    @oleq
    oleq committed Nov 13, 2023
    Configuration menu
    Copy the full SHA
    674cfac View commit details
    Browse the repository at this point in the history

  3. Renamed the #isDraggable configuration property in Dialog#show() to #… 

    …isModal.
    @oleq
    oleq committed Nov 13, 2023
    Configuration menu
    Copy the full SHA
    f332880 View commit details
    Browse the repository at this point in the history

  4. Added extra configuration options to Dialog#show() to improve the DX … 

    …and simplify dialog creation for most integrators.
    @oleq
    oleq committed Nov 13, 2023
    Configuration menu
    Copy the full SHA
    a227ec2 View commit details
    Browse the repository at this point in the history

Commits on Nov 14, 2023

  1. WIP: Initial dialog position implementation.

    @oleq
    oleq committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    458523b View commit details
    Browse the repository at this point in the history

Commits on Nov 15, 2023

  1. Constrained dialog position to the viewport.

    @oleq
    oleq committed Nov 15, 2023
    Configuration menu
    Copy the full SHA
    28feff6 View commit details
    Browse the repository at this point in the history

  2. Code refactoring in the manual test.

    @oleq
    oleq committed Nov 15, 2023
    Configuration menu
    Copy the full SHA
    54a12dc View commit details
    Browse the repository at this point in the history

Commits on Nov 16, 2023

  1. Integrated the ClassicEditor's sticky panel with the Dialog system to… 

    … ensure dialogs don't obscure the panel if not positioned manually.
    @oleq
    oleq committed Nov 16, 2023
    Configuration menu
    Copy the full SHA
    ae9a20b View commit details
    Browse the repository at this point in the history

  2. Tests: Extended the manual test.

    @oleq
    oleq committed Nov 16, 2023
    Configuration menu
    Copy the full SHA
    4a8a7c0 View commit details
    Browse the repository at this point in the history

  3. Tests: Update the manual test.

    @oleq
    oleq committed Nov 16, 2023
    Configuration menu
    Copy the full SHA
    770a728 View commit details
    Browse the repository at this point in the history

  4. Code refactoring.

    @oleq
    oleq committed Nov 16, 2023
    Configuration menu
    Copy the full SHA
    d4d553c View commit details
    Browse the repository at this point in the history

Commits on Nov 17, 2023

  1. Made focus cycling in various dialogs easier by moving the generic in… 

    …tegration code to the DialogView class.
    @oleq
    oleq committed Nov 17, 2023
    Configuration menu
    Copy the full SHA
    4cf6f39 View commit details
    Browse the repository at this point in the history

  2. Used the CSS visibility property instead of an absolute position to p… 

    …re-render the dialog before it gets displayed to avoid uncontrolled viewport movement on iOS.
    @oleq
    oleq committed Nov 17, 2023
    Configuration menu
    Copy the full SHA
    7120447 View commit details
    Browse the repository at this point in the history

  3. Merge pull request #15348 from ckeditor/ck/14973-dialogs-initial-posi… 

    …tion

Internal (ui): Implemented configurable initial dialog positions. Constrained dialog positions (and drag&drop) to the viewport.
    @scofalik
    scofalik authored Nov 17, 2023
    Configuration menu
    Copy the full SHA
    106b512 View commit details
    Browse the repository at this point in the history

Commits on Nov 18, 2023

  1. Merge branch 'ck/14973-dialogs' into ck/14973-dialogs-easier-focus-cy… 

    …cling
    @scofalik
    scofalik authored Nov 18, 2023
    Configuration menu
    Copy the full SHA
    7f73e41 View commit details
    Browse the repository at this point in the history

  2. Merge pull request #15369 from ckeditor/ck/14973-dialogs-easier-focus… 

    …-cycling

Internal (ui): Made focus cycling in various dialogs easier by moving the generic integration code to the DialogView class.
    @scofalik
    scofalik authored Nov 18, 2023
    Configuration menu
    Copy the full SHA
    57c30ba View commit details
    Browse the repository at this point in the history

Commits on Nov 20, 2023

  1. Undo the features integration besides the find and replace.

    @Dumluregn
    Dumluregn committed Nov 20, 2023
    Configuration menu
    Copy the full SHA
    2c9b3e1 View commit details
    Browse the repository at this point in the history

Commits on Nov 21, 2023

  1. Extract DialogDefinition type.

    @Dumluregn
    Dumluregn committed Nov 21, 2023
    Configuration menu
    Copy the full SHA
    fbc8f1b View commit details
    Browse the repository at this point in the history

  2. Add a comment regarding the focus cycling.

    @Dumluregn
    Dumluregn committed Nov 21, 2023
    Configuration menu
    Copy the full SHA
    8db4fe3 View commit details
    Browse the repository at this point in the history

  3. Renames.

    @Dumluregn
    Dumluregn committed Nov 21, 2023
    Configuration menu
    Copy the full SHA
    360b197 View commit details
    Browse the repository at this point in the history

  4. Add comment about focusing.

    @Dumluregn
    Dumluregn committed Nov 21, 2023
    Configuration menu
    Copy the full SHA
    3f42e0e View commit details
    Browse the repository at this point in the history

  5. Make modals draggable and ditch isDraggable prop.

    @Dumluregn
    Dumluregn committed Nov 21, 2023
    Configuration menu
    Copy the full SHA
    9a84e00 View commit details
    Browse the repository at this point in the history

  6. Drop unnecessary CSS rule.

    @Dumluregn
    Dumluregn committed Nov 21, 2023
    Configuration menu
    Copy the full SHA
    017f080 View commit details
    Browse the repository at this point in the history

  7. Rename dragging coordinates related stuff.

    @Dumluregn
    Dumluregn committed Nov 21, 2023
    Configuration menu
    Copy the full SHA
    c54a4b2 View commit details
    Browse the repository at this point in the history

  8. Update comment.

    @Dumluregn
    Dumluregn committed Nov 21, 2023
    Configuration menu
    Copy the full SHA
    1fe515b View commit details
    Browse the repository at this point in the history

  9. Decorate show() and hide() dialog methods with events.

    @Dumluregn
    Dumluregn committed Nov 21, 2023
    Configuration menu
    Copy the full SHA
    51062c4 View commit details
    Browse the repository at this point in the history

  10. Small refactors.

    @Dumluregn
    Dumluregn committed Nov 21, 2023
    Configuration menu
    Copy the full SHA
    11de6a5 View commit details
    Browse the repository at this point in the history

  11. Introduce Dialog._isOpen property.

    @Dumluregn
    Dumluregn committed Nov 21, 2023
    Configuration menu
    Copy the full SHA
    dbe9362 View commit details
    Browse the repository at this point in the history

  12. Get rid of the Dialog#setTitle method.

    @Dumluregn
    Dumluregn committed Nov 21, 2023
    Configuration menu
    Copy the full SHA
    f645209 View commit details
    Browse the repository at this point in the history

Commits on Nov 22, 2023

  1. Remove outdated todo.

    @Dumluregn
    Dumluregn committed Nov 22, 2023
    Configuration menu
    Copy the full SHA
    1bfaf51 View commit details
    Browse the repository at this point in the history

  2. Make isDragging a public observable.

    @Dumluregn
    Dumluregn committed Nov 22, 2023
    Configuration menu
    Copy the full SHA
    1e94152 View commit details
    Browse the repository at this point in the history

  3. Change some props visibility.

    @Dumluregn
    Dumluregn committed Nov 22, 2023
    Configuration menu
    Copy the full SHA
    eab853f View commit details
    Browse the repository at this point in the history

  4. Fix the dialog view parts and children.

    @Dumluregn
    Dumluregn committed Nov 22, 2023
    Configuration menu
    Copy the full SHA
    bebd50a View commit details
    Browse the repository at this point in the history

Commits on Nov 23, 2023

  1. Make a public observable.

    @Dumluregn
    Dumluregn committed Nov 23, 2023
    Configuration menu
    Copy the full SHA
    c5b6af8 View commit details
    Browse the repository at this point in the history

  2. Add id to the dialogDefinition.

    @Dumluregn
    Dumluregn committed Nov 23, 2023
    Configuration menu
    Copy the full SHA
    9b0022b View commit details
    Browse the repository at this point in the history

  3. Add more available dialog positions.

    @Dumluregn
    Dumluregn committed Nov 23, 2023
    Configuration menu
    Copy the full SHA
    d4918e3 View commit details
    Browse the repository at this point in the history

  4. Add more testing buttons.

    @Dumluregn
    Dumluregn committed Nov 23, 2023
    Configuration menu
    Copy the full SHA
    4832012 View commit details
    Browse the repository at this point in the history

  5. Add bottom toolbar editor demo and fix EDITOR_TOP_SIDE position.

    @Dumluregn
    Dumluregn committed Nov 23, 2023
    Configuration menu
    Copy the full SHA
    2049a27 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'master' into ck/14973-dialogs

    @Dumluregn
    Dumluregn committed Nov 23, 2023
    Configuration menu
    Copy the full SHA
    fba4be2 View commit details
    Browse the repository at this point in the history

Commits on Nov 24, 2023

  1. More or less working draft.

    @Dumluregn
    Dumluregn committed Nov 24, 2023
    Configuration menu
    Copy the full SHA
    99a30af View commit details
    Browse the repository at this point in the history

  2. Fix communication between editors.

    @Dumluregn
    Dumluregn committed Nov 24, 2023
    Configuration menu
    Copy the full SHA
    d9de8a2 View commit details
    Browse the repository at this point in the history

  3. Fix displaying dialogs after opening them multiple times.

    @Dumluregn
    Dumluregn committed Nov 24, 2023
    Configuration menu
    Copy the full SHA
    63bf891 View commit details
    Browse the repository at this point in the history

Commits on Nov 27, 2023

  1. Introduce the 'on' button state.

    @Dumluregn
    Dumluregn committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    3f63a2a View commit details
    Browse the repository at this point in the history

  2. Fix integration with sticky toolbar.

    @Dumluregn
    Dumluregn committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    9261be3 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into ck/14973-dialogs

    @oleq
    oleq committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    901d00c View commit details
    Browse the repository at this point in the history

  4. Merge branch 'ck/14973-dialogs' into ck/dialogs-single-instance

    @oleq
    oleq committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    1503736 View commit details
    Browse the repository at this point in the history

  5. Used a static refence to the Dialog plugin to manage dialog interacti… 

    …ons between multiple editors. Ensured the view injected into a dialog survives dialog destruction process (re-usablity). Streamlined focus tracking in a dialog.
    @oleq
    oleq committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    b8329df View commit details
    Browse the repository at this point in the history

  6. Add toggleability to the f&r toolbar button.

    @Dumluregn
    Dumluregn committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    ad356e2 View commit details
    Browse the repository at this point in the history

  7. Add multiroot editor to demo.

    @Dumluregn
    Dumluregn committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    adc53fc View commit details
    Browse the repository at this point in the history

Commits on Nov 28, 2023

  1. Ensured the dialog view is removed from the body collection and the g… 

    …lobal focus tracker when it gets hidden.
    @oleq
    oleq committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    5682e27 View commit details
    Browse the repository at this point in the history

  2. Code refactoring.

    @oleq
    oleq committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    6991ebf View commit details
    Browse the repository at this point in the history

  3. Made the DialogView method to update its position public.

    @oleq
    oleq committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    66c5bc9 View commit details
    Browse the repository at this point in the history

  4. Docs.

    @oleq
    oleq committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    5c1b140 View commit details
    Browse the repository at this point in the history

  5. Merge pull request #15417 from ckeditor/ck/dialogs-single-instance 

    Internal (ui): One dialog instance across all the editor instances. Introduced `isOn` state for the find and replace button. Destroy and recreate the `DialogView` instead of resetting it. Improvements to focus tracking. Code refactoring.
    @oleq
    oleq authored Nov 28, 2023
    Configuration menu
    Copy the full SHA
    e874486 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'ck/14973-dialogs' into ck/dialogs-multiroot

    @Dumluregn
    Dumluregn committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    04030c8 View commit details
    Browse the repository at this point in the history

  7. Handle root attaching/detaching.

    @Dumluregn
    Dumluregn committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    23a3245 View commit details
    Browse the repository at this point in the history

  8. Tests: Added dialog sub-class test skeletons.

    @oleq
    oleq committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    601d99c View commit details
    Browse the repository at this point in the history

  9. Moved the dialog and multi-root integration to the Dialog and built i… 

    …t on top of differ to avoid a direct coupling with MultiRootEditor.
    @oleq
    oleq committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    cc3169d View commit details
    Browse the repository at this point in the history

  10. Merge pull request #15421 from ckeditor/ck/dialogs-multiroot 

    Internal (ui): Added the smooth integration between dialogs and multi-root editor (including root attaching/detaching).
    @oleq
    oleq authored Nov 28, 2023
    Configuration menu
    Copy the full SHA
    479d323 View commit details
    Browse the repository at this point in the history

  11. Merge branch 'ck/14973-dialogs' into ck/14973-dialogs-unit-tests

    @oleq
    oleq committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    98b184d View commit details
    Browse the repository at this point in the history

  12. Allowed configurable find and replace UI type (drop-down or dialog).

    @oleq
    oleq committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    d139dda View commit details
    Browse the repository at this point in the history

  13. Merge branch 'ck/14973-dialogs' into ck/14973-dialogs-unit-tests

    @oleq
    oleq committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    2e51f8d View commit details
    Browse the repository at this point in the history

  14. Tests: DialogView unit tests wire frame.

    @oleq
    oleq committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    b2e6d10 View commit details
    Browse the repository at this point in the history

Commits on Nov 29, 2023

  1. Add tests for dialog.ts.

    @Dumluregn
    Dumluregn committed Nov 29, 2023
    Configuration menu
    Copy the full SHA
    da96e0d View commit details
    Browse the repository at this point in the history

Commits on Nov 30, 2023

  1. Tests: Added DialogView tests.

    @oleq
    oleq committed Nov 30, 2023
    Configuration menu
    Copy the full SHA
    c45d311 View commit details
    Browse the repository at this point in the history

  2. Add coverage for draggableviewmixin.ts.

    @Dumluregn
    Dumluregn committed Nov 30, 2023
    Configuration menu
    Copy the full SHA
    46cd4d8 View commit details
    Browse the repository at this point in the history

  3. Tests: Added tests for the integration between the Dialog plugin and … 

    …ClassicEditor's sticky panel (toolbar).
    @oleq
    oleq committed Nov 30, 2023
    Configuration menu
    Copy the full SHA
    230417d View commit details
    Browse the repository at this point in the history

  4. Add focuscycler.ts coverage.

    @Dumluregn
    Dumluregn committed Nov 30, 2023
    Configuration menu
    Copy the full SHA
    7287369 View commit details
    Browse the repository at this point in the history

  5. Tests: Added tests for the DialogContentView class.

    @oleq
    oleq committed Nov 30, 2023
    Configuration menu
    Copy the full SHA
    39b03c0 View commit details
    Browse the repository at this point in the history

  6. Tests: Updated StickyPanelView after StickyPanelView#_contentPanel be… 

    …came StickyPanelView#contentPanelElement.
    @oleq
    oleq committed Nov 30, 2023
    Configuration menu
    Copy the full SHA
    cf4c647 View commit details
    Browse the repository at this point in the history

  7. Typings for event listeners.

    @oleq
    oleq committed Nov 30, 2023
    Configuration menu
    Copy the full SHA
    abdf143 View commit details
    Browse the repository at this point in the history

Commits on Dec 1, 2023

  1. Tests: Added a manual test for DraggableViewMixin.

    @oleq
    oleq committed Dec 1, 2023
    Configuration menu
    Copy the full SHA
    a3bf160 View commit details
    Browse the repository at this point in the history

  2. Marked several DialogView methods as internal to exclude them from th… 

    …e public API.
    @oleq
    oleq committed Dec 1, 2023
    Configuration menu
    Copy the full SHA
    ed28362 View commit details
    Browse the repository at this point in the history

  3. Add coverage for DialogActionsView.

    @Dumluregn
    Dumluregn committed Dec 1, 2023
    Configuration menu
    Copy the full SHA
    201e66a View commit details
    Browse the repository at this point in the history

  4. Add missing multiroot test.

    @Dumluregn
    Dumluregn committed Dec 1, 2023
    Configuration menu
    Copy the full SHA
    6ac7aee View commit details
    Browse the repository at this point in the history

  5. Increase tooltip z-index to keep it visible over the dialog.

    @Dumluregn
    Dumluregn committed Dec 1, 2023
    Configuration menu
    Copy the full SHA
    a28dbd2 View commit details
    Browse the repository at this point in the history

  6. Merge pull request #15438 from ckeditor/ck/14973-dialogs-unit-tests 

    Tests (ui): Added unit tests for the dialogs system.
    @oleq
    oleq authored Dec 1, 2023
    Configuration menu
    Copy the full SHA
    3765442 View commit details
    Browse the repository at this point in the history

  7. Merge branch 'master' into ck/14973-dialogs

    @oleq
    oleq committed Dec 1, 2023
    Configuration menu
    Copy the full SHA
    10ad3ba View commit details
    Browse the repository at this point in the history

  8. Move switchbuttons to the main view.

    @Dumluregn
    Dumluregn committed Dec 1, 2023
    Configuration menu
    Copy the full SHA
    b38d02b View commit details
    Browse the repository at this point in the history

  9. Extract CollapsibleView to UI package.

    @Dumluregn
    Dumluregn committed Dec 1, 2023
    Configuration menu
    Copy the full SHA
    82bfba5 View commit details
    Browse the repository at this point in the history

Commits on Dec 4, 2023

  1. Move switchbuttons to the collapsible.

    @Dumluregn
    Dumluregn committed Dec 4, 2023
    Configuration menu
    Copy the full SHA
    b012363 View commit details
    Browse the repository at this point in the history

  2. Improve switchbuttons styling.

    @Dumluregn
    Dumluregn committed Dec 4, 2023
    Configuration menu
    Copy the full SHA
    b814ac5 View commit details
    Browse the repository at this point in the history

  3. Cleanup.

    @Dumluregn
    Dumluregn committed Dec 4, 2023
    Configuration menu
    Copy the full SHA
    da22b28 View commit details
    Browse the repository at this point in the history

  4. Fix focus cycling.

    @Dumluregn
    Dumluregn committed Dec 4, 2023
    Configuration menu
    Copy the full SHA
    e5897d1 View commit details
    Browse the repository at this point in the history

  5. Reverse the action buttons order.

    @Dumluregn
    Dumluregn committed Dec 4, 2023
    Configuration menu
    Copy the full SHA
    26778f8 View commit details
    Browse the repository at this point in the history

  6. Refactor.

    @Dumluregn
    Dumluregn committed Dec 4, 2023
    Configuration menu
    Copy the full SHA
    885b958 View commit details
    Browse the repository at this point in the history

  7. Merge branch 'ck/14973-dialogs' into ck/14973-dialogs-f&r-redesigned

    @Dumluregn
    Dumluregn committed Dec 4, 2023
    Configuration menu
    Copy the full SHA
    db8214f View commit details
    Browse the repository at this point in the history

Commits on Dec 5, 2023

  1. Fix the ui-dropdown-panel-focus-child-missing-focus warning.

    @Dumluregn
    Dumluregn committed Dec 5, 2023
    Configuration menu
    Copy the full SHA
    e438066 View commit details
    Browse the repository at this point in the history

  2. Fix canceling the fire event if toolbar button is disabled.

    @Dumluregn
    Dumluregn committed Dec 5, 2023
    Configuration menu
    Copy the full SHA
    317602d View commit details
    Browse the repository at this point in the history

  3. Fix and add all tests besides findandreplaceformview.

    @Dumluregn
    Dumluregn committed Dec 5, 2023
    Configuration menu
    Copy the full SHA
    19d812a View commit details
    Browse the repository at this point in the history

  4. Finish fixing the tests.

    @Dumluregn
    Dumluregn committed Dec 5, 2023
    Configuration menu
    Copy the full SHA
    e0fc29e View commit details
    Browse the repository at this point in the history

Commits on Dec 6, 2023

  1. Fix displaying the replace input.

    @Dumluregn
    Dumluregn committed Dec 6, 2023
    Configuration menu
    Copy the full SHA
    a270e56 View commit details
    Browse the repository at this point in the history

  2. Replace the fieldset elements with divs.

    @Dumluregn
    Dumluregn committed Dec 6, 2023
    Configuration menu
    Copy the full SHA
    929ff29 View commit details
    Browse the repository at this point in the history

  3. Make focus test more stable on CI.

    @Dumluregn
    Dumluregn committed Dec 6, 2023
    Configuration menu
    Copy the full SHA
    519bdf6 View commit details
    Browse the repository at this point in the history

Commits on Dec 7, 2023

  1. Add missing API docs in the dialog UI component [skip ci].

    @Dumluregn
    Dumluregn committed Dec 7, 2023
    Configuration menu
    Copy the full SHA
    6cc4475 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'ck/14973-dialogs' into ck/14973-dialogs-f&r-redesigned

    @Dumluregn
    Dumluregn committed Dec 7, 2023
    Configuration menu
    Copy the full SHA
    8d360f1 View commit details
    Browse the repository at this point in the history

  3. Add missing API docs [skip ci].

    @Dumluregn
    Dumluregn committed Dec 7, 2023
    Configuration menu
    Copy the full SHA
    5ad0943 View commit details
    Browse the repository at this point in the history

  4. Merge pull request #15441 from ckeditor/ck/14973-dialogs-tooltip-visi… 

    …bility

Internal (ui): Increased tooltips' `z-index` to make them visible over the dialog element.
    @oleq
    oleq authored Dec 7, 2023
    Configuration menu
    Copy the full SHA
    3fd8384 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'master' into ck/14973-dialogs

    @oleq
    oleq committed Dec 7, 2023
    Configuration menu
    Copy the full SHA
    f47b89f View commit details
    Browse the repository at this point in the history

  6. WIP: 9ea94d4 Merge pull request #15434 from ckeditor/ck/15298

    @oleq
    oleq committed Dec 7, 2023
    Configuration menu
    Copy the full SHA
    8b9e0d0 View commit details
    Browse the repository at this point in the history

  7. Resolved duplicated re-exports in the ui package.

    @oleq
    oleq committed Dec 7, 2023
    Configuration menu
    Copy the full SHA
    b268972 View commit details
    Browse the repository at this point in the history

  8. Enabled styles in the find and replace form view styles that were mis… 

    …sing a parent selector.
    @oleq
    oleq committed Dec 7, 2023
    Configuration menu
    Copy the full SHA
    9f0f8c3 View commit details
    Browse the repository at this point in the history

  9. Minor code refactoring.

    @oleq
    oleq committed Dec 7, 2023
    Configuration menu
    Copy the full SHA
    61cf38b View commit details
    Browse the repository at this point in the history

  10. Deferred FindAndReplaceFormView creation to the moment the dialog is … 

    …about to show up.
    @oleq
    oleq committed Dec 7, 2023
    Configuration menu
    Copy the full SHA
    b47f62b View commit details
    Browse the repository at this point in the history

  11. Tests: Minor code refactoring.

    @oleq
    oleq committed Dec 7, 2023
    Configuration menu
    Copy the full SHA
    737d850 View commit details
    Browse the repository at this point in the history

  12. Tests: Added a test that asserts deferred form creation with in-dialo… 

    …g configuration.
    @oleq
    oleq committed Dec 7, 2023
    Configuration menu
    Copy the full SHA
    2d1a2d7 View commit details
    Browse the repository at this point in the history

  13. Add a keystroke to toggle focus between the editor and the dialog.

    @Dumluregn
    Dumluregn committed Dec 7, 2023
    Configuration menu
    Copy the full SHA
    a034999 View commit details
    Browse the repository at this point in the history

  14. Add label for the screen readers.

    @Dumluregn
    Dumluregn committed Dec 7, 2023
    Configuration menu
    Copy the full SHA
    c668829 View commit details
    Browse the repository at this point in the history

  15. Add test coverage.

    @Dumluregn
    Dumluregn committed Dec 7, 2023
    Configuration menu
    Copy the full SHA
    d62ea90 View commit details
    Browse the repository at this point in the history

  16. Add missing unit test.

    @Dumluregn
    Dumluregn committed Dec 7, 2023
    Configuration menu
    Copy the full SHA
    ac16fb1 View commit details
    Browse the repository at this point in the history

Commits on Dec 8, 2023

  1. Merge branch 'master' into ck/14973-dialogs

    @oleq
    oleq committed Dec 8, 2023
    Configuration menu
    Copy the full SHA
    8e42a71 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'ck/14973-dialogs' into ck/14973-dialogs-f&r-redesigned

    @oleq
    oleq committed Dec 8, 2023
    Configuration menu
    Copy the full SHA
    02f504f View commit details
    Browse the repository at this point in the history

  3. Merge pull request #15457 from ckeditor/ck/14973-dialogs-f&r-redesigned 

    Internal (find-and-replace): Changed the layout of the view. Unified the layout for use in dropdowns and dialogs.
    @oleq
    oleq authored Dec 8, 2023
    Configuration menu
    Copy the full SHA
    dc47ad7 View commit details
    Browse the repository at this point in the history

  4. Fix failing test.

    @Dumluregn
    Dumluregn committed Dec 8, 2023
    Configuration menu
    Copy the full SHA
    b5e7f0f View commit details
    Browse the repository at this point in the history

  5. Enable onCreate() callback on action buttons.

    @Dumluregn
    Dumluregn committed Dec 8, 2023
    Configuration menu
    Copy the full SHA
    862eb42 View commit details
    Browse the repository at this point in the history

  6. Add test coverage.

    @Dumluregn
    Dumluregn committed Dec 8, 2023
    Configuration menu
    Copy the full SHA
    3afd6ba View commit details
    Browse the repository at this point in the history

  7. Extract styles to theme.

    @Dumluregn
    Dumluregn committed Dec 8, 2023
    Configuration menu
    Copy the full SHA
    141df67 View commit details
    Browse the repository at this point in the history

  8. Split styles into files.

    @Dumluregn
    Dumluregn committed Dec 8, 2023
    Configuration menu
    Copy the full SHA
    34ec624 View commit details
    Browse the repository at this point in the history

  9. Small improvements to the manual test.

    @Dumluregn
    Dumluregn committed Dec 8, 2023
    Configuration menu
    Copy the full SHA
    855458a View commit details
    Browse the repository at this point in the history

Commits on Dec 13, 2023

  1. Merge pull request #15496 from ckeditor/ck/14973-dialogs-fix-ci 

    Internal (list): Fixed failing test.
    @oleq
    oleq authored Dec 13, 2023
    Configuration menu
    Copy the full SHA
    cdd0eb0 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into ck/14973-dialogs

    @oleq
    oleq committed Dec 13, 2023
    Configuration menu
    Copy the full SHA
    143e2d5 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'ck/14973-dialogs' into ck/14973-dialogs-oncreate

    @oleq
    oleq committed Dec 13, 2023
    Configuration menu
    Copy the full SHA
    bf59b1c View commit details
    Browse the repository at this point in the history

  4. Merge pull request #15497 from ckeditor/ck/14973-dialogs-oncreate 

    Internal (ui): Add the `onCreate()` callback to the definition of the dialog action buttons.
    @oleq
    oleq authored Dec 13, 2023
    Configuration menu
    Copy the full SHA
    d6662a8 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'ck/14973-dialogs' into ck/14973-dialogs-lark-theme

    @oleq
    oleq committed Dec 13, 2023
    Configuration menu
    Copy the full SHA
    7c2f63e View commit details
    Browse the repository at this point in the history

  6. Merge branch 'ck/14973-dialogs' into ck/14973-dialogs-a11y

    @Dumluregn
    Dumluregn committed Dec 13, 2023
    Configuration menu
    Copy the full SHA
    a74c10a View commit details
    Browse the repository at this point in the history

  7. Review fixes.

    @Dumluregn
    Dumluregn committed Dec 13, 2023
    Configuration menu
    Copy the full SHA
    11c4303 View commit details
    Browse the repository at this point in the history

  8. Extracted several dialog CSS property values to custom properties to … 

    …allow for easier customization.
    @oleq
    oleq committed Dec 13, 2023
    Configuration menu
    Copy the full SHA
    c968fe5 View commit details
    Browse the repository at this point in the history

  9. Merge pull request #15498 from ckeditor/ck/14973-dialogs-lark-theme 

    Internal (ui,theme-lark): Split dialog styles into proper files in proper directories.
    @oleq
    oleq authored Dec 13, 2023
    Configuration menu
    Copy the full SHA
    e6540de View commit details
    Browse the repository at this point in the history

  10. Merge branch 'ck/14973-dialogs' into ck/14973-dialogs-a11y

    @oleq
    oleq committed Dec 13, 2023
    Configuration menu
    Copy the full SHA
    f6a2b17 View commit details
    Browse the repository at this point in the history

  11. Minor code refactoring.

    @oleq
    oleq committed Dec 13, 2023
    Configuration menu
    Copy the full SHA
    1529da3 View commit details
    Browse the repository at this point in the history

  12. Merge pull request #15481 from ckeditor/ck/14973-dialogs-a11y 

    Internal (ui): Improved dialogs accessibility.
    @oleq
    oleq authored Dec 13, 2023
    Configuration menu
    Copy the full SHA
    2075d07 View commit details
    Browse the repository at this point in the history

Commits on Dec 14, 2023

  1. Add option for dialog header icon.

    @Dumluregn
    Dumluregn committed Dec 14, 2023
    Configuration menu
    Copy the full SHA
    094ba34 View commit details
    Browse the repository at this point in the history

Commits on Dec 15, 2023

  1. Improved TextareaView by making it update its size if its value has b… 

    …een change while it was invisible. Do not update DialogView's position when it is invisible.
    @oleq
    oleq committed Dec 15, 2023
    Configuration menu
    Copy the full SHA
    9f0614c View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into ck/14973-dialogs

    @oleq
    oleq committed Dec 15, 2023
    Configuration menu
    Copy the full SHA
    f3c0dcc View commit details
    Browse the repository at this point in the history

  3. Merge branch 'ck/14973-dialogs' into ck/14973-dialogs-improved-textar… 

    …ea-and-dialogview
    @oleq
    oleq committed Dec 15, 2023
    Configuration menu
    Copy the full SHA
    1762466 View commit details
    Browse the repository at this point in the history

  4. Used ResizeObserver because IntersectionObserver is acting up when it… 

    … comes to absolutely positioned elements.
    @oleq
    oleq committed Dec 15, 2023
    Configuration menu
    Copy the full SHA
    8839b41 View commit details
    Browse the repository at this point in the history

  5. Merge pull request #15538 from ckeditor/ck/14973-dialogs-improved-tex… 

    …tarea-and-dialogview

Internal (ui): Improved TextareaView by making it update its size if its value has been changed while it was invisible. Do not update DialogView's position while it stays invisible.
    @Dumluregn
    Dumluregn authored Dec 15, 2023
    Configuration menu
    Copy the full SHA
    d707467 View commit details
    Browse the repository at this point in the history

Commits on Dec 18, 2023

  1. Merge branch 'master' into ck/14973-dialogs

    @Dumluregn
    Dumluregn committed Dec 18, 2023
    Configuration menu
    Copy the full SHA
    8147595 View commit details
    Browse the repository at this point in the history

  2. Unify headers.

    @Dumluregn
    Dumluregn committed Dec 18, 2023
    Configuration menu
    Copy the full SHA
    b10ae87 View commit details
    Browse the repository at this point in the history

  3. Update the find and replace ui component description.

    @Dumluregn
    Dumluregn committed Dec 18, 2023
    Configuration menu
    Copy the full SHA
    06ea9fd View commit details
    Browse the repository at this point in the history

  4. Change the keystrokes handling.

    @Dumluregn
    Dumluregn committed Dec 18, 2023
    Configuration menu
    Copy the full SHA
    7b89d7b View commit details
    Browse the repository at this point in the history

Commits on Dec 19, 2023

  1. Make sourceediting plugin hide the visible dialog.

    @Dumluregn
    Dumluregn committed Dec 19, 2023
    Configuration menu
    Copy the full SHA
    68fdd62 View commit details
    Browse the repository at this point in the history

  2. Change the z-index to make ckbox dialog display over the integrated d… 

    …ialogs.
    @Dumluregn
    Dumluregn committed Dec 19, 2023
    Configuration menu
    Copy the full SHA
    57791df View commit details
    Browse the repository at this point in the history

Commits on Dec 20, 2023

  1. Merge pull request #15552 from ckeditor/ck/14973-dialogs-unify-headers 

    Internal (ui): Unified `FormHeaderView` height across features.
    @oleq
    oleq authored Dec 20, 2023
    Configuration menu
    Copy the full SHA
    d5ee1d1 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'ck/14973-dialogs' into ck/14973-dialogs-proper-keystrokes

    @oleq
    oleq committed Dec 20, 2023
    Configuration menu
    Copy the full SHA
    7e4395a View commit details
    Browse the repository at this point in the history

  3. Merge branch 'ck/14973-dialogs' into ck/14973-dialogs-source-mode-v2

    @oleq
    oleq committed Dec 20, 2023
    Configuration menu
    Copy the full SHA
    3423ef8 View commit details
    Browse the repository at this point in the history

  4. Restore the ctrl+f handling for dropdown from master.

    @Dumluregn
    Dumluregn committed Dec 20, 2023
    Configuration menu
    Copy the full SHA
    eb3a205 View commit details
    Browse the repository at this point in the history

  5. Tests: Added a dialog integration unit test. Code refactoring: wrappe… 

    …d dialog integration tests into a category.
    @oleq
    oleq committed Dec 20, 2023
    Configuration menu
    Copy the full SHA
    070b070 View commit details
    Browse the repository at this point in the history

  6. Merge pull request #15566 from ckeditor/ck/14973-dialogs-source-mode-v2 

    Internal (source-editing): Hide the visible dialog when switching to the source editing mode.
    @oleq
    oleq authored Dec 20, 2023
    Configuration menu
    Copy the full SHA
    f4c7f3f View commit details
    Browse the repository at this point in the history

  7. Merge branch 'master' into ck/14973-dialogs

    @oleq
    oleq committed Dec 20, 2023
    Configuration menu
    Copy the full SHA
    b379cdb View commit details
    Browse the repository at this point in the history

  8. Tests: Adjusted tests to the import path changes on master.

    @oleq
    oleq committed Dec 20, 2023
    Configuration menu
    Copy the full SHA
    f676220 View commit details
    Browse the repository at this point in the history

  9. Merge branch 'ck/14973-dialogs' into ck/14973-dialogs-proper-keystrokes

    @oleq
    oleq committed Dec 20, 2023
    Configuration menu
    Copy the full SHA
    4117568 View commit details
    Browse the repository at this point in the history

  10. Tests: Fixed a failing test.

    @oleq
    oleq committed Dec 20, 2023
    Configuration menu
    Copy the full SHA
    1a29007 View commit details
    Browse the repository at this point in the history

  11. Code refactoring.

    @oleq
    oleq committed Dec 20, 2023
    Configuration menu
    Copy the full SHA
    7a98e20 View commit details
    Browse the repository at this point in the history

  12. Merge pull request #15553 from ckeditor/ck/14973-dialogs-proper-keyst… 

    …rokes

Internal (find-and-replace): Changed the handling of the Ctrl/Cmd+F keystroke so it never closes the dialog.
    @oleq
    oleq authored Dec 20, 2023
    Configuration menu
    Copy the full SHA
    ffe9d0b View commit details
    Browse the repository at this point in the history

Commits on Dec 21, 2023

  1. Make it possible to listen on one of the close events or hide the clo… 

    …se button.
    @Dumluregn
    Dumluregn committed Dec 21, 2023
    Configuration menu
    Copy the full SHA
    b39b993 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'ck/14973-dialogs' into ck/14973-dialogs-optional-close

    @Dumluregn
    Dumluregn committed Dec 21, 2023
    Configuration menu
    Copy the full SHA
    34bd7de View commit details
    Browse the repository at this point in the history

  3. Add short description in the manual test [skip ci].

    @Dumluregn
    Dumluregn committed Dec 21, 2023
    Configuration menu
    Copy the full SHA
    8ce2da1 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'ck/14973-dialogs' into ck/14973-dialogs-optional-close

    @oleq
    oleq committed Dec 21, 2023
    Configuration menu
    Copy the full SHA
    f3e8175 View commit details
    Browse the repository at this point in the history

  5. Add missing unit test.

    @Dumluregn
    Dumluregn committed Dec 21, 2023
    Configuration menu
    Copy the full SHA
    e9de3f1 View commit details
    Browse the repository at this point in the history

Commits on Dec 22, 2023

  1. Merge pull request #15577 from ckeditor/ck/14973-dialogs-optional-close 

    Internal (ui): Made the `close` button in the header optional. Added the `source` information to the `DialogViewCloseEvent`.
    @oleq
    oleq authored Dec 22, 2023
    Configuration menu
    Copy the full SHA
    d556b9b View commit details
    Browse the repository at this point in the history

  2. Fix.

    @Dumluregn
    Dumluregn committed Dec 22, 2023
    Configuration menu
    Copy the full SHA
    eeb0e7f View commit details
    Browse the repository at this point in the history

  3. Improvement.

    @Dumluregn
    Dumluregn committed Dec 22, 2023
    Configuration menu
    Copy the full SHA
    9d6f24a View commit details
    Browse the repository at this point in the history

  4. Add API docs.

    @Dumluregn
    Dumluregn committed Dec 22, 2023
    Configuration menu
    Copy the full SHA
    dee7bfd View commit details
    Browse the repository at this point in the history

  5. Merge pull request #15587 from ckeditor/ck/14973-dialogs-safari-resur… 

    …rection

Internal (ui): Fixed quirks related to `TouchEvent` being unsupported by desktop Safari.
    @oleq
    oleq authored Dec 22, 2023
    Configuration menu
    Copy the full SHA
    aa1627c View commit details
    Browse the repository at this point in the history

Commits on Jan 2, 2024

  1. Fix.

    @Dumluregn
    Dumluregn committed Jan 2, 2024
    Configuration menu
    Copy the full SHA
    69c5d6b View commit details
    Browse the repository at this point in the history

  2. Enhance manual test.

    @Dumluregn
    Dumluregn committed Jan 2, 2024
    Configuration menu
    Copy the full SHA
    5c05756 View commit details
    Browse the repository at this point in the history

Commits on Jan 3, 2024

  1. Merge pull request #15614 from ckeditor/ck/14973-dialogs-cycling-fix 

    Internal (ui): Fixed tab key cycling in a dialog that only has action buttons (no close button).
    @oleq
    oleq authored Jan 3, 2024
    Configuration menu
    Copy the full SHA
    d577c13 View commit details
    Browse the repository at this point in the history

  2. Docs: Fixed docs errors.

    @oleq
    oleq committed Jan 3, 2024
    Configuration menu
    Copy the full SHA
    d84499e View commit details
    Browse the repository at this point in the history

Commits on Jan 4, 2024

  1. FocusCycler's focusables collection should only contain FocusableView… 

    … instances.
    @oleq
    oleq committed Jan 4, 2024
    Configuration menu
    Copy the full SHA
    0860906 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into ck/14973-dialogs

    @Dumluregn
    Dumluregn committed Jan 4, 2024
    Configuration menu
    Copy the full SHA
    430e86a View commit details
    Browse the repository at this point in the history

  3. Tests: Stabilized FocusCycler tests.

    @oleq
    oleq committed Jan 4, 2024
    Configuration menu
    Copy the full SHA
    f0a702c View commit details
    Browse the repository at this point in the history

  4. Review fixes.

    @Dumluregn
    Dumluregn committed Jan 4, 2024
    Configuration menu
    Copy the full SHA
    ddc7226 View commit details
    Browse the repository at this point in the history

Commits on Jan 5, 2024

  1. Replace the avoided operator.

    @Dumluregn
    Dumluregn committed Jan 5, 2024
    Configuration menu
    Copy the full SHA
    93f5fad View commit details
    Browse the repository at this point in the history

Commits on Jan 8, 2024

  1. Code refactoring.

    @oleq
    oleq committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    607b2ad View commit details
    Browse the repository at this point in the history

  2. Docs: Migrated enums to JS objects for Umberto compatibility. Extende… 

    …d dialog API docs.
    @oleq @Dumluregn
    oleq authored and Dumluregn committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    4c7259c View commit details
    Browse the repository at this point in the history

  3. First batch of changes.

    @Dumluregn
    Dumluregn committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    6c35d6f View commit details
    Browse the repository at this point in the history

  4. Next part of code improvements.

    @Dumluregn
    Dumluregn committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    eff91c8 View commit details
    Browse the repository at this point in the history

  5. Replace the isOpen flag with observable id.

    @Dumluregn
    Dumluregn committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    15d6a26 View commit details
    Browse the repository at this point in the history

  6. Merge pull request #15632 from ckeditor/ck/15631-unified-focuscycler-… 

    …collection

Other (ui): `FocusCycler`'s `#focusables` collection should only contain `FocusableView` instances. Closes #14973.

MINOR BREAKING CHANGE (ui): The view collection `focusables` required by [`FocusCycler#constructor()`](https://ckeditor.com/docs/ckeditor5/latest/api/module_ui_focuscycler-FocusCycler.html#function-constructor) must only contain views implementing the [`FocusableView`](https://ckeditor.com/docs/ckeditor5/latest/api/module_ui_focuscycler-FocusableView.html) interface. Failing to do so will result in a TypeScript error. If your custom code creates `FocusCycler` instances, please make sure that all views passed in `focusables` implement the `focus()` method.
    @scofalik
    scofalik authored Jan 8, 2024
    Configuration menu
    Copy the full SHA
    bd80b20 View commit details
    Browse the repository at this point in the history

  7. FocusCycler's #next and #previous should point to the same view even … 

    …if that's the only focusable view (#15623)

Internal (ui): `FocusCycler#next` and `#previous` should point to the same view even if that's the only focusable view to allow for easier nested cyclers' integration. Previously they were set to `null`.
    @oleq
    oleq authored Jan 8, 2024
    Configuration menu
    Copy the full SHA
    932712a View commit details
    Browse the repository at this point in the history

Commits on Jan 9, 2024

  1. Update packages/ckeditor5-ui/src/dialog/dialog.ts 

    Co-authored-by: Szymon Cofalik <s.cofalik@cksource.com>
    @Dumluregn @scofalik
    Dumluregn and scofalik authored Jan 9, 2024
    Configuration menu
    Copy the full SHA
    802c234 View commit details
    Browse the repository at this point in the history

  2. Improve visibleDialogPlugin property.

    @Dumluregn
    Dumluregn committed Jan 9, 2024
    Configuration menu
    Copy the full SHA
    4420a2a View commit details
    Browse the repository at this point in the history

  3. Change the dialog plugin instance firing the event when dialog is hid… 

    …den.
    @Dumluregn
    Dumluregn committed Jan 9, 2024
    Configuration menu
    Copy the full SHA
    2d552d3 View commit details
    Browse the repository at this point in the history

  4. Enhance the test.

    @Dumluregn
    Dumluregn committed Jan 9, 2024
    Configuration menu
    Copy the full SHA
    142e50b View commit details
    Browse the repository at this point in the history