BiRNNBuilder does not support saving #161
Labels
minor bug
Bugs that aren't too bad, only concern documentation, or have easy work-arounds
Comments
|
True. Create a pull request and I'll merge it. On Sat, Nov 12, 2016, 19:38 Daniel Hershcovich notifications@github.com
|
neubig
added
the
minor bug
danielhers
added a commit
to danielhers/dynet
that referenced
this issue
Nov 13, 2016
|
@yoavg I created a pull request. |
yoavg
added a commit
that referenced
this issue
Nov 17, 2016
Fix #161: support save/load BiRNNBuilder
joelgrus
added a commit
to allenai/dynet
that referenced
this issue
Jan 17, 2017
* add python3 compatibility * fix py3 compatible printing in the visualizer * clean up after myself * fix lingering python2 vs python3 compatibility issue * I broke the dynet python package. This fixes it as well the problem with extension name != filename in cython * forgot these two files in the last commit * make dynet_viz be python 3 compatible * fixed load and save to work in python 3 as well, considering the change to bytes() * copy dict properties by need in Saveable instead of copying everything and then deleting unneeded stuff * more pyt3 bytes vs p2 bytes compatibility changes * Fix clab#161: support save/load BiRNNBuilder * Documentation and standardization for arithmetic * Update python.rst * Update install.rst * Update python.rst * addad zeroes, random_normal, random_uniform, random_bernoulli to python. * Added threshold clipping to python bindings * Added support for gradient clipping disabling to python * Some more documentation for pickneglogsoftmax etc. * Added a bunch of missing functions * Fixed some linking problems? * Made it possible to do dense updates * Added some tests for sum with minibatches * Gradient clipping should be performed with respect to scale parameter * ability to get expression's dimension * Re-inputting the generated output * Fixed a bug in concatenate with batches * Added unorthodox documentation and fixed l2 name * Fixed some documentation * Explained about sparse Adam and Momentum are incorrect * Fixed references * added ability to get the "head" of an rnnpointer * Added hinge loss documentation * Add Travis CI badge to README The badge shows whether the build is currently passing. * Fixed minor typos and inconsistencies in documentation * Fixed typo in string representation of `Expression` class * Changed "errror" to "error" * Changed "with with" to "with" * Documentation for sparsemax * Update documentation following Python 3 support * Added documentation of losses * exposes logsumexp * typo * Fixed slicing in Python interface * Added support for scaling bernoulli variables * Simplified examples * Reformatted examples * Mutualize python and C++ examples * Add readme to examples * Remove garbage * Add examples to doc * bugfix * Added support for negative indices and default slice arguments * typos * Refactor rnnlm-batch example + add doc + some corrections to examples * Put rnnlm in examples to clean the root directory * Remove rnnlm from cmakelist * typo for inverted dropout in doc * Corrected a NASTY bug in expr.h with breathe Also updated the doc accordingly and fixed some warnings as well * Add doc build status * added python tutorial stub This should be helpful to people until someone gets around to writing python documentation in the official docs. * Update tutorial.rst * Update API.ipynb * Added some documentation of flow expressions * Added noising documentation * Removed some extraneous stuff in doc * Fixed rescaling of lookup parameters * Fixed warning * Removed unnecessary CPU mem alloc when using GPU * Changed pointers to references where `nullptr` is invalid * Fixed some "unused" and "reorder" warnings * Fixed some "unused" warnings * Updated documentation * Fixed missing pass of edecay * Added unimplemented function * Added coding style standards * Added coding style * Fixed bullets in doc * Added reference to inverted dropout * Added identity init * Fixed stupid bug resulting from lack of coffee * Added initializer to LookupParameter in Python * Added ability to do dense updates in Python * Create python_tutorial.rst * Add ipython notebooks to the docs * Add MNIST example Also adds a multilayer perceptron struct to the examples * fixed save example Previously, saveable contained a typo and a format for add_parameters that has been abandoned. * Add ipython notebooks to the docs (clab#212) * Add ipython notebooks to the docs * Add link to EMNLP tutorial in doc * Reorganise examples by programming language (clab#216) * Correct examples path in doxyfile * Move examples * Fix dead links causing failed doc build * Fixed bug when using Adam w/ status updates * Added info on Anaconda * Added cython to anaconda doc * Basic Python 3 support for Python examples * Added ability to print text graphviz * Speed improvements to CPU batched AffineTransform * add select_rows, select_cols to python * Fixed documentation for logistic function * Fixed inconsistent initialization in Py and C++ * Simplify LogSoftmax (clab#218) * Python 3 bugfix: builder_layers must be a list, not a zip object (clab#222) * Match original TreeLSTM paper name * Fixed const problem in expressions * Disable finite-math-only opimizations to avoid nan problems (clab#220) -Ofast enables -ffinite-math-only, which leads gcc-5 (and some earlier versions such as gcc-4.4) to produce code that produces nans in unexpected places etc. This still leaves active the math options that yield lowered precision (mostly ok for NN code). * Changed dynet module alias from pc to dy * Fixed off-by-one error in slice stop index bounds checking (clab#227) * Switch for logsumexp on GPU * Better CUDA impl of SumBatches * Efficiency improvement for SimpleRNN * Optimization of PickNegLogSoftmax on GPU * Regular malloc is faster * More efficient sum * Faster lookup on GPU * Fixed two bugs * Fix typo "Charecter" -> "Character" * Fixed bug in params * Selective pick of VanillaLSTMBuilder * Document dimension object * Add to doxygen + sphinx * Remove from minibatch.rst & change group name * Added dynet link * Added info about mailing list to main doc * fix windows compiling error by modifying the unsupported initializer_list on windows. * inline doc for inputMatrix * fixing cmake error with defined BOOST_ROOT Previously, cmake would fail if BOOST_ROOT was defined but Boost_INCLUDE_DIR was not defined, now it does not * Update dynet_viz.py mock trainers can not get arbitrary number of parameters. * Added some minibatching doc * Fixes to minibatching doc * Added doc for multiprocessing * Some fixes to doc * Updating install docs to be consistent with build * Fix mnist examples dependencies & add it to build path * More efficient colwise add * Bugfix in vanillalstm serialization vanillalstm didn't save `hid` which causes errors when loading a saved model. Couldn't test this but should be fine. * Added tech report link * Fixing MKL build for OS X * Updated name to match title of tech report * change Model* parameters to Model&
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I have a model with a
BiRNNBuilder, and when I'm trying to save it I'm getting:Looks like the builder does not support saving.
The text was updated successfully, but these errors were encountered: