Fix #161: support save/load BiRNNBuilder #163
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I implemented a separate case in
_save_one
and_load_one
for theBiRNNBuilder
, but I think it might be more elegant to make it extend theSaveable
interface instead. The problem with this is that the builder layer sub-components are saved in a list of tuples rather than directly as attributes, andSaveable
assumes that any non-picklable sub-component is a direct attribute of the object.A possible way to go around this is to replace the above assumption with a decorator that would declare an attribute as non-picklable (explicit is better than implicit), and add this decorator to the
builder_layers
attribute. TheSaveable
interface methods can be implemented like so: