Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added error handlings #76

Merged
merged 5 commits into from
Nov 10, 2020
Merged

Added error handlings #76

merged 5 commits into from
Nov 10, 2020

Conversation

tejash-jl
Copy link
Member

@tejash-jl tejash-jl commented Nov 5, 2020 •
edited
Loading

  • I have added error handlings at certain places that was been missed out earlier.
  • updated configs file which had server IP address to localhost
  • moved enabling logging of SQL query flag to the config file

@tejash-jl tejash-jl added this to the Release Thor milestone Nov 5, 2020
@tejash-jl tejash-jl self-assigned this Nov 5, 2020
lohith46
lohith46 approved these changes Nov 6, 2020
View reviewed changes
Copy link
Member

@lohith46 lohith46 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to merge

@tejash-jl tejash-jl merged commit b8f9c9b into master Nov 10, 2020
@sivachandran sivachandran mentioned this pull request Jan 19, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lohith46 lohith46 lohith46 approved these changes

@priyaaank priyaaank Awaiting requested review from priyaaank

Assignees

@tejash-jl tejash-jl

Labels
code quality
Projects
None yet
Milestone
Release Thor
Development

Successfully merging this pull request may close these issues.
2 participants
@tejash-jl @lohith46