Replace structs by-value usages with by-ref usages #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
priyaaank
approved these changes
Mar 18, 2021
sivachandran
force-pushed
the
struct-pass-by-ptr
branch
from
26ef3a7
to
0125c46
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following changeset replaces all most of the uses of struct by-value usage with by-ref usage.
Struct by-value usage incurs the cost of copying/cloning the struct data which should be avoided where it is not required.
The function
CreateWorkflowis broken. It was supposed to assign an increasing id to the primary and on-failure steps. But the existing implementation didn't work as expected. So, now I added a test case to verify the expected behaviour and also fixed theCreateWorkflowfunction.