This repository was archived by the owner on Jun 8, 2022. It is now read-only.
Support custom build command #34
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An escape hatch for use cases where the built-in build script is not usable; one example is that the Python dependencies require platform-dependent native extensions.
It supports `base64 -d` or `base64 --decode` but not `base64 -D`. Not sure where `-D` is supported but I'm hoping `--decode` works there.
When I tried this, it was creating the Lambda build files as the root user and then it failed trying to clean them up. This now does everything including setting ownership inside Docker. I also removed the default values because I'd rather it break then default to something that may not be intended.
raymondbutcher
force-pushed
the
ray/custom-build-script
branch
3 times, most recently
from
67e2c9a to
8bb3013
Compare
raymondbutcher
force-pushed
the
ray/custom-build-script
branch
from
8bb3013 to
9835cdd
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finishing #30
Thank you very much @asavoy for the original pull request.