Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare for adaptation options calculations #154

Open
7 of 9 tasks
DenoBeno opened this issue Mar 31, 2020 · 97 comments
Open
7 of 9 tasks

Prepare for adaptation options calculations #154

DenoBeno opened this issue Mar 31, 2020 · 97 comments
Labels
enhancement New feature or request

Comments

@DenoBeno
Copy link

DenoBeno commented Mar 31, 2020

  • Change the "costs" fields to free text (cost per m^2)
  • Assure that the new cost fields are shown in all relevant views
  • Implement new data model (node) for "adaptation strategy" . Each strategy is for ONE land use; three variants to be created for each land use
  • Allow user to define the "adaptation project" by choosing several adaptation strategies, one for each land use category (user explicitly has to choose "no adaptation" or one of the options.
  • TBD: can the user define more than one adaptation project or just one?
  • calculate the effects of adaptation options
  • calculate the costs of adaptation options
  • calculate the cost of hazard impact with/without adaptation options.
  • present the results to the user.
@p-a-s-c-a-l p-a-s-c-a-l added the enhancement New feature or request label Mar 31, 2020
@p-a-s-c-a-l p-a-s-c-a-l added this to the D1.4 CLARITY CSIS v2 milestone Mar 31, 2020
@DenoBeno
Copy link
Author

DenoBeno commented Apr 1, 2020

After yesterdays discussion, I have a better Idea how to proceed with this. First, we need change in the "cost" field of the adaptation options. There, the three cost fields need to be replaced with numeric fields (price pro m^2). This is easy, but we also need to change a presentation in all views to accommodate these three new fields and then drop the old ones.

@stefanon, @mattia-leone : I hope that I can change this later today.

Once the fields are available, PLINIUS will start filling in the data. All values will be in €, valid for Italy (we need to inform the user about this and also to think about transforming this to Austria or Sweden later.)

  • Considering the issue with costs of per-meter adaptation options, we can ignore these. All adaptation options will have per m^2 cost, how is up to PLINIUS.

Next is to define a new node or taxonomy type that will be used to define "adaptation strategy". Something like this:

  1. one land use category (e.g. residential middle density houses)
  2. one or or more adaptation options
  3. percentage of the land use category to apply this to (one or one for each adaptation option?)
  4. "strategy" (need another name for this) of choosing where to apply this - e.g. random or "cells with high heat hazard" or "cells with high population exposure" or "cells with high heat mortality"
  5. some text & illustrations
  6. Other?

Each adaptation strategy defines one or more adaptation options applied to one land use category. E.g. "apply cool roofs and green walls on 50% of the residential middle density houses". I am not 100% sure what exactly is needed in this node, so [I have opened a ticket for this] #155).

  • As soon as we have this covered, PLINIUS will add some strategies.

Third part is to add "Adaptation Options: Appraisal" step where user can choose one adaptation option strategy for each land use. They don't have to choose adaptation strategy for each land use category - those that aren't set are implicitly set to "no adaptation option".

I'm thinking of some table where users can choose this. The simplest solution would be to replicate what we already do for adaptation options on https://csis.myclimateservice.eu/study/25/step/3686/view/table. The problem here is that nothing prevents the user to choose several conflicting options. Better solution would be a table listing all land uses in the first column and allowing the user to choose the adaptation strategy in the second, plus having some information about this strategy shown in the third column. @patrickkaleta , @fgeyer16, do you have some bright ideas on how to do this? (I'll probably open new ticket to decide on how exactly to do this.)


@humerh : this makes it clear what EMIKAT can get from CSIS. A list of "strategies" to apply. Each strategy is linked to its description, and then to individual adaptation options. There is no explicit geometry, just the geometry of the project. The difficult part is that EMIKAT would have to choose where to apply the the "strategy". E.g., if the strategy is to apply something to 50% of the houses, preferably in the "cells with high mortality", then EMIKAT would needs to find how many houses are in the project, find the cell with highest mortality, apply this to all houses in this cell, find the next highest mortality cell, apply there and so on - until 50% mark has been reached.

This sounds too complex to me, we need to re-design this somehow. @ALL, any ideas?

As for the cost calculations, I don't know what we have at a table today, if anything. @mattia-leone , @stefanon How are we (going to) calculate the cost of the crisis? @humerh , @patrickkaleta: is anything already designed or implemented in this direction?


Finally, we will need something similar to what is already shown in risk/impact and ideally a possibility to compare a situation with/without adaptation options. Which reminds me that we'll have to calculate the cumulative costs over N years, not just costs of a single event.

Any comments/sugestions?

@mattia-leone
Copy link

Dear all, I am a bit lost. Everything was clear at the time of my last meeting with Denis about how to calculate the effect of adaptation, using "strategies" instead of single measures, and working with the land use percentages.
At this point I think that we should have a dedicated meeting to talk about this, let's not stall with this crucial step!

@mattia-leone
Copy link

about adaptation cost calculations, we have a very complete set of data about this.
we agreed that first the data model for strategies on the CSIS should be prepared, so that we can input all the data.
Also, we were waiting for someone to modify the cost field for the single adaptation measures (insted of €, €€, €€€) so that we can insert the revised cost data

@patrickkaleta
Copy link

about adaptation cost calculations, we have a very complete set of data about this.
we agreed that first the data model for strategies on the CSIS should be prepared, so that we can input all the data.
Also, we were waiting for someone to modify the cost field for the single adaptation measures (insted of €, €€, €€€) so that we can insert the revised cost data

I changed the cost fields, so you should be able to now insert specific values for development, retrofitting and maintenance costs. Remaining changes to the data structure will be done after the initial release of the CSIS, because such changes always affect the content synchronization between Development site and production site, which I want to keep at a minimum before the initial release.

Just one question, so that I can add a correct description to the cost fields. Is the maintenance cost calculated on a per-year basis or for the entire estimated lifespan of the adaptation option?

@DenoBeno
Copy link
Author

DenoBeno commented Apr 29, 2020

I see that Partrick has changed the cost fields in adaptation options, but the old fields (and not the new ones) are still shown everywhere.

I will open a new issue for this and proceed with fixing the views. (should be OK now)

@humerh
Copy link

humerh commented Jun 15, 2020

The interface to the REST interface, including adaptation options is included in the Wiki page:
https://github.com/clarity-h2020/csis/wiki/Services-endpoints-(used-by-CSIS)

The new views for cost reports will also be documented there.

@humerh humerh closed this as completed Jun 15, 2020
@patrickkaleta patrickkaleta reopened this Jun 18, 2020
@patrickkaleta
Copy link

CSIS is now able to show the results for the Adaptation option calculations in the Map and Table component. The Adaptation Strategy selected by the user is linked with the study_variant keyword ADAPTATION-01.

So, depending on the currently selected Study scenario, the Map and Table components will pull the results for either the baseline scenario or the adapted scenario from Emikat.

Example: https://csis-dev.myclimateservice.eu/study/25/step/3682/view/table (selecting either "worst case, 20y, adapted" or "worst case, 20y" will show different results.

@patrickkaleta
Copy link

Ideally, we can decouple the study_variant from the Study Scenarios, so that it could be possible to show in the Map component the differences of the Study scenario with and without Adaptation options side by side (we already have the split screen with two maps, so we should use it). @therter let's maybe discuss this in a short telco to see how feasible that would be for us in the remaining time.

@patrickkaleta
Copy link

Another thing, we need to check the plausibility of the adaptation options calculations.

I'm afraid currently it's not quite what we are looking for. For example see these two layers for the "Local effect mean radiant temperature":

  1. "No adaptation options" layer
  2. "with adaptation options" layer

Otherwise, the selected Study scenarios are the same (same time period, RCP...), so the "with adaptation options" layer should show less red squares and not more.

Also, in the Table , the adapted scenario shows higher temperatures:
baseline-temperatures
adapted-temperatures

@humerh and @mattia-leone can you please have a look at the current results produced by Emikat for the Adaptation options calculation? It seems that right now, applying our adaptation strategies only make things worse in the end.

@p-a-s-c-a-l p-a-s-c-a-l self-assigned this Jun 29, 2020
@patrickkaleta
Copy link

@mattia-leone and @stefanon FYI:
Heinrich fixed an error in the calculations. I re-triggered the calculations and the results now seem to be better, however the adapted scenario still shows sligthly higher temperatures than the baseline scenario.
BTW: Feel free to run your own adapted scenarios for your own Studies. Remember that in the development instance you cannot trigger the Emikat calculations. You can however later use the development instance to view the results if you like.

For comparison:
Table for baseline scenario temperatures
Table for adapted scenario temperatures

As can be seen in the tables, T_MRT, T_UTCI and T_A are on average slightly higher in the adapted scenario.

@DenoBeno
Copy link
Author

DenoBeno commented Jul 3, 2020

@mattia-leone has told me today that they have found some error in calculation. Didn't get it exactly, but it could be that we are multiplying the values of old parameters with new ones instead of replacing them.

@mattia-leone
Copy link

Hi @patrickkaleta , did you check Martina's email? It relates with what @DenoBeno says. Actually is the opposite, before we put "multiply value" for the Ts parameter, which is wrong (and that could explain the higher values in the adaptation), while now Martina corrected this with "replace value"
Hopefully if you run another calculation we might be happy now..
Please let us know

P.S. working on the impact stuff, hope to send what agreed in the telco over the weekend

@patrickkaleta
Copy link

Hi @patrickkaleta , did you check Martina's email? It relates with what @DenoBeno says. Actually is the opposite, before we put "multiply value" for the Ts parameter, which is wrong (and that could explain the higher values in the adaptation), while now Martina corrected this with "replace value"
Hopefully if you run another calculation we might be happy now..
Please let us know

P.S. working on the impact stuff, hope to send what agreed in the telco over the weekend

Hi @mattia-leone, yes I've read her mail. We will deploy her changes to the live CSIS soon (I'm assuming today or tomorrow) and then we can see how that affects the calculations for the adaptation options.

@patrickkaleta
Copy link

Hi @patrickkaleta , did you check Martina's email? It relates with what @DenoBeno says. Actually is the opposite, before we put "multiply value" for the Ts parameter, which is wrong (and that could explain the higher values in the adaptation), while now Martina corrected this with "replace value"
Hopefully if you run another calculation we might be happy now..
Please let us know

P.S. working on the impact stuff, hope to send what agreed in the telco over the weekend

The changes made by Martina have been synchronized onto our PROD system and I triggered the Emikat calculation again. Looking at the results, I don't see any changes. However, I noticed that the AO Effects taxonomy has some problems. Some effects are included multiple times:
AO-effects-duplicated

I double-checked with the DEV instance, to make sure that those duplicates weren't caused by a faulty synchronization into PROD, but these duplicates already existed on the DEV server before. I didn't check all of them, but for instance the Surface temperature = 1.27 effect is in the system twice and one of them still uses "multiply" instead of "replace value". Therefore, it's possible that Emikat is still supplied with wrong parameters, which lead to wrong calculation results.

@mattia-leone and @martinapizzicato please check again all the AO effects and remove unnecessary duplicates. An AO effect only needs to be included once in this taxonomy and then it can be referenced multiple times in different AOs. And make sure that the AOs then reference only the remaining (and hopefully correct) ones.

@NICDDB
Copy link

NICDDB commented Aug 4, 2020

Us example calculation was made in Naples on calata capodichino street, near the airport.
I create a new study on CSIS, called "adaptation test miano" where i've selected the same study area of the example and i've add @patrickkaleta as owner.

@DenoBeno
Copy link
Author

DenoBeno commented Aug 4, 2020 via email

@mattia-leone
Copy link

Guys hope you can fix all this. At the moment I am working in finalizing D2.4 by Friday August 7th, since after that PLINIVS team will be on vacation and won't be available anymore until the end of the project, except answering the phone and reading emails from time to time.
I don't think that given the current status of impact and adaptation calculation I will be able to integrate the CSIS output in D2.4 as requested by @DenoBeno , but it's ok since we mainly focus on expert services there, and indeed we have calculated all impact and effect of adaptation using our local version of the CSIS heat and flood models.
Please let me know if you are willing to solve this in the next three days, in this case I can support you.
I don't think we need validation, the method and calculations should work as @stefanon transferred them to @humerh , as proven by our DC1 results and already discussed in D3.3.
Wait for your considerations

@p-a-s-c-a-l
Copy link
Member

You can also check AO calculation on this map. Left is without AO, right side is with this adaptation strategy applied.

image

@mattia-leone
Copy link

I guess that the most important thing is to have our toy working for the final review. About this, you can count on our support in September of course.
@p-a-s-c-a-l one question, can I make a new study in Napoli and test the adaptation strategies?
I created a new study in the dev version (https://csis-dev.myclimateservice.eu/study/171/view/intro) and edited all the needed data but the calculation status is still on "not ready".. which is my mistake?
Already tried in re-editing the area and changing datapackage. Added you and @DenoBeno as owner, please let me know what's wrong

@p-a-s-c-a-l
Copy link
Member

p-a-s-c-a-l commented Aug 4, 2020

@mattia-leone Sorry, EMIKAT calculation is disabled on CSIS-DEV, you have to https://csis.myclimateservice.eu. But I don't know if we have already the latest version of CSIS-DEV published on CSIS @patrickkaleta ?

@mattia-leone
Copy link

ah ok, actually I supposed so, but saw Denis' study on Vienna with all the adaptation steps included, so I thought it was ready also for Napoli. Let me know if we can make it, as said I have time until Friday, then again in September to support final review preparation (which is much more important than deliverables when it comes to the CSIS!!)

@patrickkaleta
Copy link

@mattia-leone Sorry, EMIKAT calculation is disabled on CSIS-DEV, you have to https://csis.myclimateservice.eu. But I don't know if we have already the latest version of CSIS-DEV published on CSIS @patrickkaleta ?

No, not yet. I think it will be available later today or tomorrow. Currently I'm testing the updated Group module after discovering this issue yesterday. The two Views in question have already been fixed, but since the Groups module plays such a major role in the CSIS I need to check the other Views as well, which might not all be covered by the CI automated testing.

@patrickkaleta
Copy link

@mattia-leone Sorry, EMIKAT calculation is disabled on CSIS-DEV, you have to https://csis.myclimateservice.eu. But I don't know if we have already the latest version of CSIS-DEV published on CSIS @patrickkaleta ?

No, not yet. I think it will be available later today or tomorrow. Currently I'm testing the updated Group module after discovering this issue yesterday. The two Views in question have already been fixed, but since the Groups module plays such a major role in the CSIS I need to check the other Views as well, which might not all be covered by the CI automated testing.

Synchronization from DEV to PROD is done, but I wasn't able to synchronize our GL-templates and the Study types (see #184 for details).

@mattia-leone nonetheless you should now be able to check the adaptation strategies in Napoli. I created this Study on PROD and made you the owner of it. Let me know if you have any troubles working with it.

@mattia-leone
Copy link

Hi Patrick, just read the message. I have now triggered the calculation and waiting for the results.
Let you know my... feelings ;)

@mattia-leone
Copy link

Schermata 2020-08-05 alle 19 25 09

A first strange thing is the flood local effect, which has some "holes" as in the screen attached. And the right map panel does not display any local results, but only the land use layers.

@mattia-leone
Copy link

apart from the holes, I think the flood local effect is not correct. It displays red cells up on the hill, while it should be the opposite. @stefanon maybe @patrickkaleta and/or @humerh have inverted the classification of some layers?

@mattia-leone
Copy link

Schermata 2020-08-05 alle 19 30 09

also here right map panel does not display results. I see also some mismatches in the layers that are visualized here. Risk/Impact maps should be limited to: - Mortality rate increase (Heat Waves) - Outdoor discomfort (Heat Waves) - I think you named the layer "Heat Waves impact" as from the impact calculation discomfort.doc.. my mistake I think it's more clear if we name it like this - Economic impact on roads (Flood) - Economic impact on residential buildings (Flood) - Economic impact on non-residential buildings (Flood)

The layers "number of exposed persons" and "population density class" should be moved to the "Exposure" map tab.
The layers "heat damage probability" and "flood damage probability" I think can be removed, since they are not useful to end users

@patrickkaleta I hope you can easily fix this, tomorrow I will look at the Adaptation section

@p-a-s-c-a-l
Copy link
Member

p-a-s-c-a-l commented Aug 6, 2020

And the right map panel does not display any local results, but only the land use layers.

The right HC-LE map is currently configured to show the adapted scenario which has not bee calculated. I'm, aware that for the user it's not obvious where and when adaption scenarios are are shown. The new AO appraisal step introduced some inconsistencies which I don't know how to resolve even at conceptual level. Anyway, I can change that if you prefer to see on the right map the non-adapted scenario when no adapted scenario is available, otherwise it shows the adapted one.

apart from the holes, I think the flood local effect is not correct. It displays red cells up on the hill, while it should be the opposite.

The map show only the parameter PF_PROP. There are many other HC-LE PF values available, which are not yet exposed via EMIKAT GeoServer: PF_STREAMS, PF_CL_STREAMS. PF_DELTA_ELEV, PF_CL_DELTA_ELEV, PF_RUN_OFF_AVERAGE, PF_CL_RUNOFF, PF_RAIN_MM: 80, PF_CL_RAIN. Perhaps it would help to show them on the map, too? For this @humerh would have to set-up the respective styles.

I think it's more clear if we name it like this - Economic impact on roads (Flood) - Economic impact on residential buildings (Flood) - Economic impact on non-residential buildings (Flood)

Hm, ATM there is only one 'flood impacts in euro' layer.

Risk/Impact maps should be limited to: - Mortality rate increase (Heat Waves) - Outdoor discomfort (Heat Waves)

O.K. I will implement the changes in the respective resource specification on CSIS-DEV. Please be aware that we have atm some problems with the synchronisation, so it might take till the end of the week for the changes to become available on CSIS-PROD.

The layers "number of exposed persons" and "population density class" should be moved to the "Exposure" map tab.

To do this, the layers have to be made available in EMIKAT View Exposure data (Population) calculated from EMIKAT by @humerh. ATM it contains just POPULATION_TOTAL. Once this is done, I can update the respective resource specification on CSIS-DEV. Since I'm leaving the project on 12. August, I'll also tell @therter how to make these changes in the resource meta-data.

The layers "heat damage probability" and "flood damage probability" I think can be removed, since they are not useful to end users

O.K. flood damage probability is currently not available anyway.

@mattia-leone
Copy link

hi @p-a-s-c-a-l thanks for the info. now i triggered the calculation, and indeed the right panel is showing the effect of adaptation strategies.
I think it is ok, the most useful thing to display on the right panel, because it makes easy the comparisons. Maybe a text that explain that left scenario is no adaptation and the right is adaptation would increase user friendliness

this seems ok for heat waves but it should give some variation also on flood impact.. wonder why not

about the other points (sorry I don't know how to quote your sentences as you did with mine..):

  • no, let's not add other HC-LE PF layers, it cause only confusion to the users
  • in the table tab, I see that flood impacts in euro are separated (roads, res. buildings and non-res) so I guess they can be split also in the map, or not?
  • the exposure map would be really much more useful if we can move there the layers "number of exposed persons" and "population density class" (which in any case should not stay in the risk/impact), hope this can be fixed

@p-a-s-c-a-l
Copy link
Member

in the table tab, I see that flood impacts in euro are separated (roads, res. buildings and non-res) so I guess they can be split also in the map, or not?

If you are talking about PF_RESIDENTIAL_BUILDINGS;PF_NON_RESIDENTIAL_BUILDINGS;PF_ROADS_M2, I don't know if those are Economic impacts in €. Perhaps @humerh can clarify. Those columns aren't available in EMIKAT GeoServer anyway, so @humerh would have to create the respective styles first.

@mattia-leone
Copy link

ok, I ask @humerh also to double check if the classification and style of the layer "flood damage class" is correct with respect to what indicated by @stefanon and me. I see almost everything red on that layer, while the damage in euro is much more diversified and more in line with the results I would expect in terms of impact.
I really don't understand the meaning of the "flood damage class" layer, as said in the risk/impact assessment for flood we should only have damage in euro (possibly split in the three subcategories of roads, residential and non-residential buildings).

@DenoBeno
Copy link
Author

DenoBeno commented Aug 7, 2020

OK folks, we have a showstopper here: I have made new calculations in Linz and in Stockholm now and discomfort level is 5 everywhere and for every scenario. It's really silly, look at this:

image

That's UTCI. And this is discomfort (left). Heat impact (right) did not load, but it could be my connection.:

image

Discomfort level in this table is NOT five everywhere! It's ranging from 2 to 4.

https://csis.myclimateservice.eu/study/179/step/4825/view/table

This table too. From 2 to 4.

https://csis.myclimateservice.eu/study/179/step/4828/view/table

My working assumption is that the discomfort is calculated properly but then somehow wrong values are taken for the maps. Same for the heat wave impact.

@DenoBeno
Copy link
Author

DenoBeno commented Aug 7, 2020

One important question on impacts. What are these impacts that we calculate? Is it impact of a single event or cumulative impact of all events happening in 20 years (which is then nearer to risk).

When you think of it, the individual 20 year events should have much higher damage cost and mortality than 1y events. Like 10 times higher... And the sum of all 1 year events over 20 years could be both higher and lower than a single 20 y event...

@mattia-leone
Copy link

the impact calculation is on a single scenario representative of the selected reference event (frequent, rare, occasional) in the selected 30 year period. it is not the cumulative impact of all the event in the period

@p-a-s-c-a-l
Copy link
Member

p-a-s-c-a-l commented Aug 7, 2020

My working assumption is that the discomfort is calculated properly but then somehow wrong values are taken for the maps.

The map uses the style HW_DISCOMFORT_LEVEL so it should show the same values as in the table. If you click on a cell, You'll see that HW_DISCOMFORT_LEVEL also ranges from 2 to 4. So it's probably just a problem of styling.

@DenoBeno
Copy link
Author

DenoBeno commented Aug 8, 2020

Heinrich has fixed the maps now. At least the discomfort looks ok, didn't check the heat impacts part

@DenoBeno
Copy link
Author

DenoBeno commented Aug 8, 2020

Now the table and the multi criteria steps are gone from this study. That's really strange.

I looked at Linz map and here are two screenshots for past and for the worst case future scenario. Both showing discomfort and heat impact, both yearly events.

Screenshot_20200808-125006
Screenshot_20200808-124821

It would seem that impact is still wrong in the map. Discomfort changed, impact should change too...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

9 participants