valid field of TemplateFunction isn't checked for includes

[christiaanb]

The following:

{-# LANGUAGE OverloadedStrings #-}
module BBCtxIncludeCheck where

import           Clash.Annotations.Primitive  (Primitive(..), HDL(..), hasBlackBox)
import           Clash.Netlist.Types          (TemplateFunction (..))
import           Clash.Prelude

import           Data.String.Interpolate      (i)
import           Data.String.Interpolate.Util (unindent)

bb :: a -> a
bb x = x
{-# NOINLINE bb #-}
{-# ANN bb hasBlackBox #-}
{-# ANN bb (InlinePrimitive [VHDL,Verilog,SystemVerilog] $ unindent [i|
   [ { "BlackBox" :
        { "name" : "BBCtxIncludeCheck.bb",
          "kind" : "Expression",
          "template": "~ARG[0]",
          "includes" :
            [ { "extension" : "bin"
              , "name" : "mem"
              , "format" : "Haskell"
              , "templateFunction" : "BBCtxIncludeCheck.tf"}

            ]
        }
     }
   ]
   |]) #-}

tf :: TemplateFunction
tf = TemplateFunction used valid (const (pure "QQ"))
 where
  used = [0]
  valid = const False

topEntity :: Bool -> Bool
topEntity = bb

passes, but shouldn't. The context check of the TemplateFunction never succeeds, but it seems this context check is never performed.

[martijnbastiaan]

Not really relevant to this issue, but it should really return a Maybe Text so the blackbox can explain why it failed.

[alex-mckenna]

I look forward to reading bbFailure = Just "because" in bug reports