change fromJustX to use deepErrorX #2113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonfowler
force-pushed
the
fromjustx-deep
branch
from
b1e30cc
to
165ad9c
Compare
|
Could you add a changelog entry? See |
DigitalBrains1
requested changes
Mar 1, 2022
DigitalBrains1
approved these changes
Mar 2, 2022
|
I've made the changelog a bit more verbose and added a strongly related change that I had planned to include for 1.6 but ran out of time for. If another reviewer agrees with my changes, is it okay if I force push onto your branch to reorganise the commits into a form suitable for merging? I don't like to force push onto other people's work without discussing it first :-). [edit] |
DigitalBrains1
force-pushed
the
fromjustx-deep
branch
from
01afd85
to
badf8e1
Compare
|
Is that bad faith one? I have a bad feeling about this commit... ;-P |
This adds `NFDataX` constraints to those functions that did not yet have them.
DigitalBrains1
force-pushed
the
fromjustx-deep
branch
from
badf8e1
to
ee7f005
Compare
|
Thanks @jonfowler |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does what it says in the title. Issue #2112