-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add termTypePrec
to TermLiteral
to allow for TermLiteral SNat
#2329
Conversation
206e74f
to
77ff03a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is going to mention a bunch of things you already fixed... because I started the review on an older version and after pressing "Refresh" it says I have 7 comments but I can only see two.
I've deleted the outdated comments. |
4a30142
to
20cc67c
Compare
20cc67c
to
4de21fe
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just like showsPrec has show, I think it makes sense to define a simpler entry function.
So when using it you can do something like:
showTermType (Proxy @a)
Instead of having to do:
termTypePrec 0 (Proxy @a) ""
Following the naming from "Show", it would make sense to then rename termTypePrec
to showsTermTypePrec
(or showsPrecTermType
?).
I wouldn't put show
equivalent in the class, like Show
does, because I don't think it make sense to redefine it for individual instances. it can just be a standalone function.
4de21fe
to
7284d27
Compare
Done @leonschoorl |
7284d27
to
6ce0cba
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed some Haddock thingies.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a convenience function for parentheses that makes the code short and sweet
d5786ef
to
4f98e38
Compare
For #2270
Still TODO: