Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing framework #91

Merged
merged 3 commits into from
Nov 3, 2015
Merged

Testing framework #91

merged 3 commits into from
Nov 3, 2015

Conversation

rjleveque
Copy link
Member

Implemented so changes to ClawpackRegressionTest.check_gauges to work better with multiple gauges when OpenMP is used to address #89.

Some changes:

  • Assume that all gauges specified in setrun should be checked, so no need to pass in gauge number.
  • Don't bother checking sums since all gauge output is saved anyway.
  • Read in the gauges, sort by gauge number, and then compare this with the regression_data that has the same form.
  • Give a more useful message if the assertion fails.

There's a test case in dev/advection_3d_swirl. nosetests should work with the data in that directory. Try changing a gauge location in setrun.py if you want to see the error output.

I'd suggest we eventually modify the way frame comparisons are done to give a more useful error message and help figure out what might have changed if the assertion fails.

Note: if this gets merged in, Travis tests in amrclaw and geoclaw will fail until the gauge regression data is updated to match what's now expected.

@mandli
Copy link
Member

mandli commented Oct 26, 2015

This all looks good to me. I also raised an issue regarding the frame comparisons.

mandli added a commit that referenced this pull request Nov 3, 2015
@mandli mandli merged commit 53e0d96 into clawpack:master Nov 3, 2015
rjleveque added a commit to rjleveque/amrclaw that referenced this pull request Nov 6, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants