Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented so changes to
ClawpackRegressionTest.check_gauges
to work better with multiple gauges when OpenMP is used to address #89.Some changes:
There's a test case in
dev/advection_3d_swirl
. nosetests should work with the data in that directory. Try changing a gauge location in setrun.py if you want to see the error output.I'd suggest we eventually modify the way frame comparisons are done to give a more useful error message and help figure out what might have changed if the assertion fails.
Note: if this gets merged in, Travis tests in amrclaw and geoclaw will fail until the gauge regression data is updated to match what's now expected.