Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PyClaw Command Line Interface to Euler quadrants example #449

Merged
merged 2 commits into from
Jul 24, 2014

Conversation

mandli
Copy link
Member

@mandli mandli commented Jul 23, 2014

Includes a setplot function for plotting as well

Includes a setplot function for plotting as well
@mandli
Copy link
Member Author

mandli commented Jul 23, 2014

Addresses an issue that we were seeing on the mailing list.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.18%) when pulling 9bdfba6 on mandli:fix-up-quadrants-example into a94b1a6 on clawpack:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) when pulling 5648d5a on mandli:fix-up-quadrants-example into a94b1a6 on clawpack:master.

@ketch
Copy link
Member

ketch commented Jul 23, 2014

How about just importing the setplot function from one of the other Euler examples, to reduce code duplication?

@mandli
Copy link
Member Author

mandli commented Jul 23, 2014

I looked into that a bit, the color bar limits are off so it would need some modification though (still easily done though). I hesitate only that if someone were to look at the example the specification of everything is not in the single python script although the urge to not duplicate code is strong within me.

@ketch
Copy link
Member

ketch commented Jul 24, 2014

Okay, I will stop nitpicking and merge.

ketch added a commit that referenced this pull request Jul 24, 2014
Add PyClaw Command Line Interface to Euler quadrants example
@ketch ketch merged commit 6ed9a60 into clawpack:master Jul 24, 2014
@mandli mandli deleted the fix-up-quadrants-example branch July 24, 2014 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants