Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make all tests runnable from the command line. #471

Merged
merged 1 commit into from
Nov 5, 2014
Merged

Make all tests runnable from the command line. #471

merged 1 commit into from
Nov 5, 2014

Conversation

ketch
Copy link
Member

@ketch ketch commented Nov 3, 2014

Also, don't compare arrays with None. Instead, use "is"/"is not".

Fixes #470.

@ketch
Make all tests runnable from the command line.
b3ac5d2 
Also, don't compare arrays with None.
@ahmadia
Copy link
Member

ahmadia commented Nov 3, 2014

Also, don't compare arrays with None.

Good catch.

@ahmadia
Copy link
Member

ahmadia commented Nov 3, 2014

Also, see: #470 (comment)

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.18%) when pulling b3ac5d2 on ketch:runnable_tests into a1adba1 on clawpack:master.

@ahmadia
Copy link
Member

ahmadia commented Nov 3, 2014

@ketch - I can't push to your branch directly, but my suggested updates are at: https://github.com/clawpack/pyclaw/tree/ketch-runnable_tests

@ketch ketch mentioned this pull request Nov 5, 2014
Merged
@ketch ketch merged commit b3ac5d2 into clawpack:master Nov 5, 2014
@ketch ketch deleted the runnable_tests branch November 5, 2014 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make individual tests runnable
3 participants
@ketch @ahmadia @coveralls