Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shallow water HLLE solver tests #612

Merged
merged 3 commits into from
Nov 21, 2018
Merged

Shallow water HLLE solver tests #612

merged 3 commits into from
Nov 21, 2018

Conversation

ketch
Copy link
Member

@ketch ketch commented Nov 19, 2018

This PR provides tests for the solvers add in clawpack/riemann#145.

@coveralls
Copy link

Coverage Status

Coverage remained the same at ?% when pulling 3df2ffc on ketch:sw_hlle into f396ebc on clawpack:master.

@coveralls
Copy link

coveralls commented Nov 19, 2018

Coverage Status

Coverage remained the same at ?% when pulling d71832b on ketch:sw_hlle into f396ebc on clawpack:master.

@mandli
Copy link
Member

mandli commented Nov 19, 2018

I forgot we need to update clawpack/clawpack with the Riemann solver. I can do a quick update to clawpack/clawpack as long as it does not disrupt the testing of clawpack/clawpack#141.

@mandli
Copy link
Member

mandli commented Nov 20, 2018

PetClaw is failing and I am not sure why. This all works for me but there may be something that's built differently as usual.

@ketch
Copy link
Member Author

ketch commented Nov 21, 2018

I wrote the tests incorrectly; in PetClaw, get_q_global() gives the solution on process 0 but gives None on other processes. I've fixed it now.

@mandli mandli merged commit 7715edb into clawpack:master Nov 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants