Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added variable coefficient traffic Rimann solver. #49

Merged
merged 4 commits into from
Aug 27, 2013

Conversation

BrisaDavis
Copy link
Contributor

No description provided.

@mandli
Copy link
Member

mandli commented Aug 19, 2013

Can you add the changes needed to make this callable by PyClaw as well? There are some instructions in the Readme.md at the top level of this repository.

@mandli
Copy link
Member

mandli commented Aug 20, 2013

I think the build is failing of a naming mistake somewhere. The build is looking for rp1_traffic_vc.f90 rather than rp1_trafficvc.f90.

@rjleveque
Copy link
Member

I think rp1_traffic_vc.f90 would be preferable, with the underscore.

I notice we're not very consistent in naming convention, e.g. riemann/src contains
rp1_acoustics_variable.f90
rpn2_vc_acoustics.f90

If we were doing it over I'd prefer rpn2_acoustics_vc.f90 so it would show up with rpn2_acoustics.f90 but not worth redoing things.

@mandli
Copy link
Member

mandli commented Aug 20, 2013

@rjleveque that makes sense to me, if we are going to do this we should do it before the release.

@ketch
Copy link
Member

ketch commented Aug 21, 2013

I agree with the renaming. Any others that ought to be renamed, while we're at it?

@mandli
Copy link
Member

mandli commented Aug 21, 2013

Maybe we should have the basic equations first and any specific version second such as these:

  • rp1_layered_shallow_water.f90 to rp1_shallow_water_layered.f90
  • rp1_nonlinear_elasticity_fwave.f90 to rp1_elasticity_nonlinear_fwave.f90
  • rp1_reactive_euler_with_efix.f90 to rp1_euler_reactive_with_efix.f90

@ketch ketch mentioned this pull request Aug 22, 2013
@rjleveque
Copy link
Member

I like Kyle's suggestion.

@ketch
Copy link
Member

ketch commented Aug 22, 2013

Me too. Since it's a bit confusing to discuss here, I've opened a new issue:

#50

mandli added a commit that referenced this pull request Aug 27, 2013
Added variable coefficient traffic reimann solver.
@mandli mandli merged commit cceab7d into clawpack:master Aug 27, 2013
@ketch ketch changed the title Added variable coefficient traffic reimann solver. Added variable coefficient traffic Rimann solver. Jul 12, 2014
mandli added a commit to mandli/riemann that referenced this pull request Mar 19, 2015
maojrs pushed a commit to maojrs/riemann that referenced this pull request Mar 19, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants