-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added variable coefficient traffic Rimann solver. #49
Conversation
Can you add the changes needed to make this callable by PyClaw as well? There are some instructions in the Readme.md at the top level of this repository. |
…ver to be callable by PyClaw.
I think the build is failing of a naming mistake somewhere. The build is looking for |
I think rp1_traffic_vc.f90 would be preferable, with the underscore. I notice we're not very consistent in naming convention, e.g. riemann/src contains If we were doing it over I'd prefer rpn2_acoustics_vc.f90 so it would show up with rpn2_acoustics.f90 but not worth redoing things. |
@rjleveque that makes sense to me, if we are going to do this we should do it before the release. |
I agree with the renaming. Any others that ought to be renamed, while we're at it? |
Maybe we should have the basic equations first and any specific version second such as these:
|
I like Kyle's suggestion. |
Me too. Since it's a bit confusing to discuss here, I've opened a new issue: |
Added variable coefficient traffic reimann solver.
deleted duplicated setup.py
v5.2.2 release candidate
No description provided.