Parse Bootstrap JSON #87
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zonika
approved these changes
Aug 22, 2018
rmfarrell
reviewed
Aug 22, 2018
| return h.of(obj) | ||
| .flatMap(obj => formatting.toDispatch(h.of(obj))) | ||
| .flatMap(dispatch => prefixes.add(dispatch, prefix)); | ||
| } |
There was a problem hiding this comment.
this function doesn't do what its name implies. It looks like it converts an object literal (not JSON) and converts it to an array of dispatches
There was a problem hiding this comment.
Good point, renamed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A function to do the same thing as
parseBootstrapbut doesn't assume Yaml input. The currentparseBootstrapfunction doesn't allow for memoization of the yaml parsing which can be CPU intensive, like during amphora startup where the number of parses for NYMag exceeds 8k reads