GPUActions are ignored on first stop-reply packet fix

[barsolo2000]

GPUActions were not handled on the first stop-reply packed that is returned when we launch a process.

Modified the LaunchProcess method to capture and return the first stop-reply packet from the vRun command instead of discarding it. In ProcessGDBRemote::DoLaunch, we now use this captured launch response directly if it's a valid stop-reply packet, so GPU actions in the launch response are processed instead of ignored..

NOTE: It's just fixing the launch case, we also need to follow up and fix the attach and connect cases.

[dmpots]

I don't think we need to create a separate vrun_response here. We can just pass down the response we take as a parameter to LaunchProcess.

[dmpots]

Maybe we should add all the packets listed here (e.g. W, X): https://sourceware.org/gdb/current/onlinedocs/gdb.html/Stop-Reply-Packets.html#Stop-Reply-Packets

[dmpots]

Would be nice to expand this check a bit to show that we have hit the breakpoint

[dmpots]

Please run clang-format on this change to make sure it is formatted correctly.

[dmpots]

LGTM

[clayborg]

We might want to change the return value to:

llvm::Expected<StringExtractorGDBRemote> GDBRemoteCommunicationClient::LaunchProcess(const Args &args);

Then we don't need to pass the StringExtractorGDBRemote &response in as a parameter.

[clayborg]

I would check for 'T' or 'S' only here. 'W' is for exited, 'X' is for terminated, 'w' is for thread exited, 'N' is for non stop debugging, and 'O' is for output and 'F' is for calling syscalls.

So for using this in a launch scenario, we want to only check for a few. Maybe modifying this to be something like:

FLAGS_ENUM(StopReplyMask) {
  Signal =  (1u << 0),
  Exited = (1u << 1),
  Terminated = (1u << 2),
  Output = (1u << 3),
  NoResumed = (1u << 4),
  Syscall = (1u << 5),
  Any = ((Syscall << 1) - 1u),
};

bool StringExtractorGDBRemote::IsStopReply(uint32_t mask) const {
  if (!IsNormalResponse())
    return false;

  if (mask & Signal && (first_char == 'T' || first_char == 'S'))
    return true;
  if (mask & Exited && (first_char == 'w' || first_char == 'W'))
    return true;
  if (mask & Terminated && first_char == 'X')
    return true;
  if (mask & Output && first_char == 'O')
    return true;
  if (mask & NoResumed && first_char == 'N')
    return true;
  if (mask & Syscall && first_char == 'F')
    return true;
  return false;
}

[clayborg]

Thanks for the changes, looks good!