Enable sort function by registered time on the search page #119

otegami · 2023-12-21T12:25:33Z

GitHub: fix #115
Related PR: #118

What I did

Deprecated the date parameter and ensured backward compatibility in the process
Changed to use registered_time or last_modified_time instead of date parameter
Changed the icons for registered time and last modified time to make them more easily distinguishable.
Display the registered time and last modified time on the search page
Added sort option by the registered time on the search page
- ref: http://localhost:3000/search
Added test cases for order by registered_time

Before	After

What I checked

I checked whether the pgroonga command include registered_at in sort_key or not. And it does.

`'slices[type_filtered].sort_keys', '-registered_at'`

Steps
- I access to the search page
  - http://localhost:3000/search
- I sort the News by using registered time and check the logs rails generated.

SELECT pgroonga_command('select',
  ARRAY[
    'table', pgroonga_table_name('fts_targets_index_pgroonga'),
    'match_columns', 'title * 100 || scorer_tf_at_most(content, 5)', 'query_flags', 'ALLOW_COLUMN|ALLOW_LEADING_NOT|QUERY_NO_SYNTAX_ERROR', 'filter', 'in_values(project_id, 1, 2, 3, 4, 5, 6) &! is_private == true &! ( in_values(project_id, 3, 4, 5, 6) && ( source_type_id == 6 || container_type_id == 6 ) ) && pgroonga_tuple_is_alive(ctid)', 'output_columns', '_id', 'limit', '0', 'drilldowns[source_type].keys', 'source_type_id', 'drilldowns[source_type].limit', '-1', 'drilldowns[container_type].keys', 'container_type_id', 'drilldowns[container_type].limit', '-1', 'slices[type_filtered].filter', 'all_records() &! source_type_id == 2 &! container_type_id == 2 &! source_type_id == 7 &! container_type_id == 7 &! source_type_id == 10 &! container_type_id == 10 &! source_type_id == 3 &! container_type_id == 3 &! source_type_id == 8 &! container_type_id == 8 &! source_type_id == 5 &! container_type_id == 5 &! source_type_id == 11 &! container_type_id == 11', 'slices[type_filtered].columns[highlighted_title].stage', 'output', 'slices[type_filtered].columns[highlighted_title].type', 'ShortText', 'slices[type_filtered].columns[highlighted_title].flags', 'COLUMN_SCALAR', 'slices[type_filtered].columns[highlighted_title].value', 'highlight_html(title)', 'slices[type_filtered].columns[content_snippets].stage', 'output', 'slices[type_filtered].columns[content_snippets].type', 'ShortText', 'slices[type_filtered].columns[content_snippets].flags', 'COLUMN_VECTOR', 'slices[type_filtered].columns[content_snippets].value', 'snippet_html(content)', 'slices[type_filtered].drilldowns[tag].keys', 'tag_ids', 'slices[type_filtered].drilldowns[tag].limit', '-1', 'slices[type_filtered].drilldowns[tag].sort_keys', '-_nsubrecs', 'slices[type_filtered].output_columns', '_score, content_snippets, id, last_modified_at, registered_at, project_id, source_id, source_type_id, title, highlighted_title, tag_ids', 'slices[type_filtered].sort_keys', '-registered_at', 'slices[type_filtered].offset', '0', 'slices[type_filtered].limit', '10'
  ]
)

…ed_at

kou · 2023-12-22T01:14:35Z

app/views/search/index.html.erb

+                             url_for(@search_request.to_params(order_target: "last_modified_at"))) %>
+        </li>
+        <li>
+          <%= link_to_unless(@search_request.order_target == "registered_at",
                             tag.i(class: "fas fa-clock") + " " +


Can we use different icon?

fix: 4e22729 Thanks. I changed the icon like the following.

Before After

Hmm. They may be difficult to understand the difference of them...
Can we find a better icon to distinct them...?
https://fontawesome.com/search?q=clock&o=r&m=free

fix: dbcb629
I couldn't find suitable icons in the clock icon list and the other lists like history or date. I chose the following icons instead:

Pen icon: Represents 'last_modified_at' as an edit.

Calendar icon: Symbolizes 'registered_at' as a date-related event.

They will be better than the current icons.

Sorry, I've forgotten to add the sample image.

kou · 2023-12-22T01:15:45Z

config/locales/en.yml

+  label_full_text_search_order_target_last_modified_at: updated at
+  label_full_text_search_order_target_registered_at: created at


How about using last modified time and registered time (or something)?
I'm not sure "XXX at" is a natural label for English speaker.

fix: 21c083d

I have aligned the verbs in the past tense, referencing the services mentioned below.

Example 1 (GitHub) Example 2(Google Drive)

Or using updated or created simply might also be a good idea because some pages use the Created or Updated.

kou · 2023-12-22T01:17:03Z

lib/full_text_search/searcher.rb

@@ -226,6 +226,7 @@ def output_columns
        "content_snippets",
        "id",
        "last_modified_at",
+        "registered_at",


How about showing this too in search result list?

@kou
May I ask you the use-case about it? I guess we will use it the following place?

redmine_full_text_search/app/views/search/index.html.erb

Line 182 in 3c14ef3

<%= format_time(e.event_datetime) %></dd>

Do you mean we will include record.registered_at in the following search result list?
If so, I'm thinking about how I should return it.

Return the different fields

Add the following fields to the response fields

api.last_modified_at: record.registered_at

api.registered_at: record.registered_at

Return it as the api.datetime

Change the value depending on the order_target field although I haven't had any image to implement it.

if order_target is registered_at, api.datetime: record.registered_at

if order_target is last_modified_at, api.datetime: record.last_modified_at

redmine_full_text_search/app/views/search/index.api.rsb

Lines 4 to 14 in 3c14ef3

@result_set.each do |record|

api.result do

api.id record.event_id

api.title record.event_highlighted_title

api.type record.event_type

api.url url_for(record.event_url(:only_path => false))

api.description record.event_content_snippets.join("\n")

api.datetime record.event_datetime

api.rank record.rank

end

end

Return the different fields

Add the following fields to the response fields

api.last_modified_at: record.registered_at

api.registered_at: record.registered_at

@kou
In this case, I expect it to be displayed on the screen as follows. What do you think of it?

Before After

diff --git a/app/views/search/index.api.rsb b/app/views/search/index.api.rsb index e61693c..40943cc 100644 --- a/app/views/search/index.api.rsb +++ b/app/views/search/index.api.rsb @@ -3,13 +3,15 @@ api.array :results, api_meta(:total_count => @result_set.n_hits, :limit => @search_request.limit) do @result_set.each do |record| api.result do - api.id record.event_id - api.title record.event_highlighted_title - api.type record.event_type - api.url url_for(record.event_url(:only_path => false)) - api.description record.event_content_snippets.join("\n") - api.datetime record.event_datetime - api.rank record.rank + api.id record.event_id + api.title record.event_highlighted_title + api.type record.event_type + api.url url_for(record.event_url(:only_path => false)) + api.description record.event_content_snippets.join("\n") + api.datetime record.event_datetime + api.last_modified_at record.last_modified_at + api.registered_at record.registered_at + api.rank record.rank end end end diff --git a/app/views/search/index.html.erb b/app/views/search/index.html.erb index b9a46b3..3071fbe 100644 --- a/app/views/search/index.html.erb +++ b/app/views/search/index.html.erb @@ -189,7 +189,13 @@ <li><%= snippet %></li> <% end %> </ol> - <%= format_time(e.event_datetime) %></dd> + + <%= "#{l(:label_full_text_search_order_target_last_modified_time)}: #{format_time(e.last_modified_at)}" %> + + + <%= "#{l(:label_full_text_search_order_target_registered_time)}: #{format_time(e.registered_at)}" %> + + </dd> <% end %> </dl> (END)

I just thought app/views/search/index.html.erb but outputting in index.api.erb too is better. Good catch.

I feel that it's difficult to distinct last_modified_at value and registered_at value because we don't have any separator between them.

How about using icon instead of l(:label_full_text_search_order_target_XXX)?

fix: 8ba3f0a Thanks!

otegami · 2023-12-22T07:18:41Z

@kou
Thank you for reviewing.
Could you give me the advice about the following comment?

ref: Enable sort function by registered time on the search page #119 (comment)

kou · 2023-12-22T08:59:16Z

I'll re-review and reply after 2023-12-26...

kou · 2023-12-27T02:26:41Z

app/views/search/index.html.erb

@@ -55,8 +55,12 @@
              <%= l(:label_full_text_search_order_target_score) %>
            </label>
            <label>
-              <%= form.radio_button "order_target", "date", name: "order_target" %>
-              <%= l(:label_full_text_search_order_target_date) %>
+              <%= form.radio_button "order_target", "last_modified_at", name: "order_target" %>


How about using the same term for i18n label?

Suggested change

<%= form.radio_button "order_target", "last_modified_at", name: "order_target" %>

<%= form.radio_button "order_target", "last_modified_time", name: "order_target" %>

fix: 177a642

app/views/search/index.html.erb

kou · 2023-12-27T02:30:52Z

app/views/search/index.html.erb

+                             url_for(@search_request.to_params(order_target: "last_modified_at"))) %>
+        </li>
+        <li>
+          <%= link_to_unless(@search_request.order_target == "registered_at",
                             tag.i(class: "fas fa-clock") + " " +


Hmm. They may be difficult to understand the difference of them...
Can we find a better icon to distinct them...?
https://fontawesome.com/search?q=clock&o=r&m=free

kou · 2023-12-27T02:59:55Z

lib/full_text_search/searcher.rb

@@ -242,10 +243,14 @@ def sort_keys
        direction = ""
      end
      case @request.order_target
-      when "date"
+      when "last_modified_at"


Can we keep supporting date for a backward compatibility?

Suggested change

when "last_modified_at"

# TODO: Add a comment why "data" exists here

when "data", "last_modified_at"

fix: 3063733

kou · 2023-12-27T03:17:10Z

lib/full_text_search/searcher.rb

@@ -226,6 +226,7 @@ def output_columns
        "content_snippets",
        "id",
        "last_modified_at",
+        "registered_at",


I just thought app/views/search/index.html.erb but outputting in index.api.erb too is better. Good catch.

I feel that it's difficult to distinct last_modified_at value and registered_at value because we don't have any separator between them.

How about using icon instead of l(:label_full_text_search_order_target_XXX)?

…ed dates

…ate it later

otegami · 2023-12-28T00:35:41Z

@kou
Thank you for reviewing. I've just fixed what you mentioned.

kou

Do you know why CI isn't run for this PR...?

kou · 2023-12-28T00:38:27Z

app/views/search/index.api.rsb

+      api.type             record.event_type
+      api.url              url_for(record.event_url(:only_path => false))
+      api.description      record.event_content_snippets.join("\n")
+      api.datetime         record.event_datetime


Could you add a comment that this is deprecated but still exists for backward compatibility and using last_modified_at or registered_at explicitly is recommended?

fix: 61f2096 Thanks!

kou · 2023-12-28T00:39:38Z

app/views/search/index.html.erb

-                             tag.i(class: "fas fa-clock") + " " +
-                               l(:label_full_text_search_order_target_date),
-                             url_for(@search_request.to_params(order_target: "date"))) %>
+          <%= link_to_unless(@search_request.order_target == "last_modified_time",


Suggested change

<%= link_to_unless(@search_request.order_target == "last_modified_time",

<%# TODO: Add a comment why "date" is here %>

<%= link_to_unless(@search_request.order_target.include?(["date", "last_modified_time"],

fix: 61f2096
Thanks, I missed it.

kou · 2023-12-28T00:40:25Z

app/views/search/index.html.erb

@@ -179,7 +189,15 @@
              <li><%= snippet %></li>
            <% end %>
          </ol>
-        <span class="author"><%= format_time(e.event_datetime) %></span></dd>
+          <span class="last-modified">
+            <i class="fas fa-pen"></i>:


We may not need : here.
Could you share screenshot?

Sure!
I made a change thinking it would be more user-friendly, but do you think it's better without it?

Thanks.
We may need a separator by CSS (something like " 🖊️: 12/26/2023 05:50 PM | 📆: 12/26/2023 05:50 PM") between last modified time and registered time.
If we have a separator, I don't care with/without :.

fix: 6f01fbb

Thank you for your suggestion. The visibility of content gets much better!

kou · 2023-12-28T00:41:05Z

lib/full_text_search/searcher.rb

@@ -242,10 +243,16 @@ def sort_keys
        direction = ""
      end
      case @request.order_target
-      when "date"
+      # TODO: Supporting the `date` parameter for backward compatibility,
+      # but it will be deprecated in the future. Use `last_modified_time` instead.


We can make it deprecated right now.

fix: 61f2096

kou · 2023-12-28T00:43:38Z

test/functional/full_text_search/search_controller_test.rb

+        if item.respond_to?(:created_on)
+          datetime ||= item.created_on
+          registered_at = item.created_on
+        end


This will simplify the following code (registered_at&.iso8601 || datetime&.iso8601 -> registered_at*.iso8601):

Suggested change

end

else

registered_at = datetime

end

fix: f9fbeb0

kou · 2023-12-28T00:44:06Z

test/functional/full_text_search/search_controller_test.rb

@@ -215,13 +215,18 @@ def format_api_results(items, total_count: nil)
          datetime ||= changeset.committed_on
        end
        datetime ||= item.updated_on if item.respond_to?(:updated_on)
-        datetime ||= item.created_on if item.respond_to?(:created_on)
+        if item.respond_to?(:created_on)
+          datetime ||= item.created_on


Could you rename the local varialble name to last_modified_at from datetime?

fix: 3bd7a5e

kou · 2023-12-28T00:48:31Z

Ah, the workflow is disabled by scheduled workflow.
I've enabled it.

Because the datetime(date) is deprecated now.

otegami · 2023-12-28T07:09:02Z

@kou
Thank you for reviewing and enabling CI. I've just fixed what you mentioned.

kou · 2023-12-28T07:12:03Z

app/views/search/index.api.rsb

+      api.type             record.event_type
+      api.url              url_for(record.event_url(:only_path => false))
+      api.description      record.event_content_snippets.join("\n")
+      # TODO: 'datetime' is deprecated but maintained for backward compatibility. Use 'last_modified_at' or 'registered_at' explicitly.


Could you remove TODO?
Could you fold a long line?

Suggested change

# TODO: 'datetime' is deprecated but maintained for backward compatibility. Use 'last_modified_at' or 'registered_at' explicitly.

# 'datetime' is deprecated but maintained for backward compatibility.

# Use 'last_modified_at' or 'registered_at' explicitly.

fix: 846e1ac

kou · 2023-12-28T07:13:32Z

app/views/search/index.html.erb

@@ -55,8 +55,14 @@
              <%= l(:label_full_text_search_order_target_score) %>
            </label>
            <label>
-              <%= form.radio_button "order_target", "date", name: "order_target" %>
-              <%= l(:label_full_text_search_order_target_date) %>
+              <!-- TODO: 'date' is deprecated but maintained for backward compatibility. -->


Could you use ERB comment instead of HTML comment because this comment will be meaningless in rendered HTML?

Suggested change

fix: cbf714b

kou · 2023-12-28T07:14:37Z

app/views/search/index.html.erb

-              <%= l(:label_full_text_search_order_target_date) %>
+              <!-- TODO: 'date' is deprecated but maintained for backward compatibility. -->
+              <!-- Use 'last_modified_time' or 'registered_time' explicitly. -->
+              <%= form.radio_button "order_target", "last_modified_time", checked: ["date", "last_modified_time"].include?(@search_request.order_target), name: "order_target" %>


Could you fold a long line for readability?

Suggested change

<%= form.radio_button "order_target", "last_modified_time", checked: ["date", "last_modified_time"].include?(@search_request.order_target), name: "order_target" %>

<%= form.radio_button "order_target",

"last_modified_time",

checked: ["date", "last_modified_time"].include?(@search_request.order_target),

name: "order_target" %>

fix: afb81f1

kou · 2023-12-28T07:18:22Z

app/views/search/index.html.erb

@@ -179,7 +189,15 @@
              <li><%= snippet %></li>
            <% end %>
          </ol>
-        <span class="author"><%= format_time(e.event_datetime) %></span></dd>
+          <span class="last-modified">
+            <i class="fas fa-pen"></i>:


Thanks.
We may need a separator by CSS (something like " 🖊️: 12/26/2023 05:50 PM | 📆: 12/26/2023 05:50 PM") between last modified time and registered time.
If we have a separator, I don't care with/without :.

lib/full_text_search/searcher.rb

Because this comment will be meaningless in rendered HTML

…readability

otegami · 2023-12-28T09:52:19Z

@kou
Thank you for reviewing. I've just fixed what you mentioned.

kou · 2023-12-28T20:53:57Z

assets/stylesheets/search.css

@@ -82,6 +82,11 @@ ol.search-snippets li {
  padding: 0.25em 0;
 }

+.last-modified::after {


Could you limit this style only in search result something like the following?

Suggested change

.last-modified::after {

#search-result .last-modified::after {

fix: b66f956

otegami · 2023-12-29T00:37:28Z

@kou
Thank you for reviewing. I've just fixed what you mentioned.

kou · 2023-12-29T01:00:43Z

Could you update the PR title and description before we merge this?
We use them for commit message.

otegami · 2023-12-29T01:30:14Z

@kou
Sure. I've just updated the title and description.

kou

Ah, one more thing.
Could you add a test for order by registered time?

otegami · 2023-12-29T06:44:31Z

test/unit/full_text_search/searcher_test.rb

+        order_type: "desc",
+        search_id: @project.id,
+        news: "1",
+        attachments: "0",


I couldn't understand why the value of attachments parameter is '1' at first.
So if I don't use this parameter, the searched result includes targets related to attachments.

otegami · 2023-12-29T06:47:47Z

Could you add a test for order by registered time?

fix: 7703bb5
@kou
Sure, I've just added the test case for the order.
Should I add the test case for the other orders like 'last_modified_time' or 'score'?
If so, should I do it in the other issue?

kou · 2023-12-29T13:09:03Z

test/unit/full_text_search/searcher_test.rb

+      parameters = {
+        order_target: "registered_time",
+        order_type: "desc",
+        search_id: @project.id,


Why do we need this?
If we need this, is @project.id a suitable value?

fix: cc5d0ec
I took request.project for the search_id parameter.
And it has already been defined in the following.

redmine_full_text_search/test/unit/full_text_search/searcher_test.rb

Line 44 in 3c14ef3

request.project = @project

kou · 2023-12-29T13:15:19Z

test/unit/full_text_search/searcher_test.rb

+        limit: "-1"
+      }
+      targets = search(parameters).records
+      searched_news_ids = targets.collect(&:source_id)


How about compare records instead of only record IDs?
If this test is failed, we can only know record IDs. But we want to know created_on value for each record. If we use records instead of record IDs, failure message includes created_on values too.

Suggested change

searched_news_ids = targets.collect(&:source_id)

searched_news = targets.collect(&:source_record)

fix: a59d128
Thanks, I think I couldn't have this viewpoint when I wrote tests...

test/unit/full_text_search/searcher_test.rb

kou · 2023-12-29T13:17:03Z

test/unit/full_text_search/searcher_test.rb

@@ -82,5 +82,41 @@ def test_syntax_error_query
      assert_equal([issue],
                   targets.collect(&:source_record).sort_by(&:id))
    end
+
+    def test_results_ordered_by_descending_registered_time


Can we simplify this name?

Suggested change

def test_results_ordered_by_descending_registered_time

def test_order_registered_time_desc

fix: 8fcf70f

kou · 2023-12-29T13:25:03Z

Should I add the test case for the other orders like 'last_modified_time' or 'score'?

It's better.

If so, should I do it in the other issue?

Yes.

If we use records instead of record IDs, failure message show instance information which includes created_on values too.

otegami · 2023-12-29T14:23:42Z

@kou
Thank you for reviewing. I've just fixed what you mentioned.

Should I add the test case for the other orders like 'last_modified_time' or 'score'?

It's better.

Added: I created the issue about it

Add test cases for order by last modified time or score #120

kou · 2023-12-29T14:50:49Z

Thanks!

otegami added 2 commits December 21, 2023 20:04

Rename order_type parameter about updated_at from date to last_modifi…

ee780c7

…ed_at

Add the logic to filter the items by registered_at

b1cf36a

otegami mentioned this pull request Dec 21, 2023

検索結果のソートにチケット番号を追加してほしい #115

Closed

kou reviewed Dec 22, 2023

View reviewed changes

otegami added 2 commits December 22, 2023 14:37

Use the different icon for soring linnk by registered_at

4e22729

Change label names to more user-friendly values in English

21c083d

Fix the test for changed labels

a8a31d7

kou reviewed Dec 27, 2023

View reviewed changes

otegami added 4 commits December 28, 2023 07:13

Updated icons to better show the difference between updated and creat…

dbcb629

…ed dates

Modified to display last_modified_at and registered_at in search page

8ba3f0a

Use the same term as in i18n label

177a642

Added data parameter for backward compatibility, planning to deprec…

3063733

…ate it later

kou reviewed Dec 28, 2023

View reviewed changes

otegami added 3 commits December 28, 2023 14:53

Applied 'date' parameter for backward compatibility to search interface

61f2096

Rename the local variable name from datetime to last_modified_at

3bd7a5e

Because the datetime(date) is deprecated now.

Simplify the test logic

f9fbeb0

kou reviewed Dec 28, 2023

View reviewed changes

otegami added 4 commits December 28, 2023 17:33

Remove unnecessary TODOs

846e1ac

Use ERB comment instead of HTML comment

cbf714b

Because this comment will be meaningless in rendered HTML

Fold a long line for readability

afb81f1

Added a separator between last-modified time and registered time for …

6f01fbb

…readability

kou reviewed Dec 28, 2023

View reviewed changes

Restrict the sccope of css style to .last-modified in #search-results

b66f956

otegami changed the title ~~Enable sort function by creation time~~ Enable sort function by registered time on the search page Dec 29, 2023

kou reviewed Dec 29, 2023

View reviewed changes

otegami commented Dec 29, 2023

View reviewed changes

otegami requested a review from kou December 29, 2023 07:57

Added test cases for order by registered time

7703bb5

otegami force-pushed the add-filter-function-by-creation-time branch from 7fd2370 to 7703bb5 Compare December 29, 2023 08:54

kou reviewed Dec 29, 2023

View reviewed changes

otegami added 3 commits December 29, 2023 22:07

Enhanced test output by comparing full records instead of just ids

a59d128

If we use records instead of record IDs, failure message show instance information which includes created_on values too.

Simplify the test case names

8fcf70f

Removed unnecessary parameters

cc5d0ec

otegami requested a review from kou December 29, 2023 14:23

otegami mentioned this pull request Dec 29, 2023

Add test cases for order by last modified time or score #120

Closed

kou merged commit 288b667 into clear-code:master Dec 29, 2023
8 of 10 checks passed

otegami deleted the add-filter-function-by-creation-time branch December 29, 2023 15:17

		label_full_text_search_order_target_last_modified_at: updated at
		label_full_text_search_order_target_registered_at: created at

	@result_set.each do \|record\|
	api.result do
	api.id record.event_id
	api.title record.event_highlighted_title
	api.type record.event_type
	api.url url_for(record.event_url(:only_path => false))
	api.description record.event_content_snippets.join("\n")
	api.datetime record.event_datetime
	api.rank record.rank
	end
	end

	<%= form.radio_button "order_target", "last_modified_at", name: "order_target" %>
	<%= form.radio_button "order_target", "last_modified_time", name: "order_target" %>

	when "last_modified_at"
	# TODO: Add a comment why "data" exists here
	when "data", "last_modified_at"

	<%= link_to_unless(@search_request.order_target == "last_modified_time",
	<%# TODO: Add a comment why "date" is here %>
	<%= link_to_unless(@search_request.order_target.include?(["date", "last_modified_time"],

-        end
+        else
+          registered_at = datetime
+        end

	# TODO: 'datetime' is deprecated but maintained for backward compatibility. Use 'last_modified_at' or 'registered_at' explicitly.
	# 'datetime' is deprecated but maintained for backward compatibility.
	# Use 'last_modified_at' or 'registered_at' explicitly.

	<!-- TODO: 'date' is deprecated but maintained for backward compatibility. -->
	<!-- 'date' is deprecated but maintained for backward compatibility. -->

	.last-modified::after {
	#search-result .last-modified::after {

	searched_news_ids = targets.collect(&:source_id)
	searched_news = targets.collect(&:source_record)

	def test_results_ordered_by_descending_registered_time
	def test_order_registered_time_desc

Enable sort function by registered time on the search page #119

Enable sort function by registered time on the search page #119

Conversation

otegami commented Dec 21, 2023 • edited Loading

What I did

What I checked

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

otegami Dec 28, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

otegami commented Dec 22, 2023

kou commented Dec 22, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

otegami commented Dec 28, 2023

kou left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kou commented Dec 28, 2023

otegami commented Dec 28, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

otegami commented Dec 28, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

otegami commented Dec 29, 2023

kou commented Dec 29, 2023

otegami commented Dec 29, 2023

kou left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

otegami commented Dec 29, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kou commented Dec 29, 2023

otegami commented Dec 29, 2023 • edited Loading

kou commented Dec 29, 2023

otegami commented Dec 21, 2023 •

edited

Loading

otegami Dec 28, 2023 •

edited

Loading

otegami commented Dec 29, 2023 •

edited

Loading

otegami commented Dec 29, 2023 •

edited

Loading