-
Notifications
You must be signed in to change notification settings - Fork 676
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clementine doesn't work on macOS Mojave #6148
Comments
@slallum I also experienced this, so thanks for posting the workaround. However, since it's a workaround and not a bugfix (the bug still exists), it might be worth leaving the issue open? |
@edwardgalligan I agree, I'll reopen. |
Why does Clementine need accessibility control? |
it is not just clementine all (third party?) apps need it now in mojave. and new now apple requires you to say yes to letting app have privilages the first time it is opened in mojave, apples new way of checking malware?!?! |
IIRC, it's because Apple doesn't let you use the media keys any other way. |
That dialog is indeed intended to prevent apps adding themselves automatically to accessibility control, but no, not all third party apps require accessibility. Cantata works fine without it and since Clementine also defines it's own keyboard shortcuts it shouldn't crash if I don't grant it permission for such control. |
This definitely isn't true or there'd be a similar issue to this on every macOS app bugtracker out there. As @hatstand pointed out, Clementine (and I guess most music players) do use explicit accessibility features. However, it probably shouldn't crash the entire app when that one feature isn't available. |
Yeah, clementine is supposed to check if it's enabled and if not, open the accessibility dialog for you. But I'm guessing Apple's API changed in Mojave. I don't really have time to look into it but the code if you're interested is here: https://github.com/clementine-player/Clementine/blob/master/src/core/mac_startup.mm and we use https://github.com/nevyn/SPMediaKeyTap which hasn't been updated since 2015... |
I'll do a bit of digging to see if I can get this working. |
@hatstand seems like the crash occurs because |
For newer versions of OSX, https://developer.apple.com/documentation/mediaplayer/mpremotecommandcenter provides access to the media player actions. |
Shouldn't be too hard to update Clementine to use that here instead then: https://github.com/clementine-player/Clementine/blob/master/src/core/macglobalshortcutbackend.mm I'd do it but I don't have a mac anymore. |
Same here. Mojave 10.14.3. I just downloaded official version 1.3.1 and got that crash. |
I am wondering why this bug is closed as clearly this is a deal breaker. That is the first MacOS that is effectively instanly crashign when Accesibility access is not enabled, clearly a very bad first time user experience. |
As an outsider, this bug appears to be closed because:
People are wondering why this issue is closed when the bug still occurs because:
|
https://builds.clementine-player.org/mac/ - work for me now. used latest 1.3.1 build and the issue is indeed resolved. Would have been nice to have an "official" release w/ the fixes since 2016 on the main website though. If anyone w/ sufficient access has time to put the required effort is a different question though 😏 |
Sorry for going semi-off-topic, but it's kind of true what @DarthVaderx99 says, considering you're using some services based on AppleScript from the services menu. You need to add every single application to the accessibility list then. |
after upgrade High Sierra to Mojave clementine crashes.. removed.. downloaded 1.3.1.. install.. crash.. |
Before posting
Please follow the steps below and check the boxes with [x] once you did the step.
System information
Please provide information about your system and the version of Clementine used.
Expected behaviour / actual behaviour
Clementine is opening, showing the main window for a split second and then quits.
Steps to reproduce the problem (only for bugs)
Upgrade to Mojave and open Clementine.
The text was updated successfully, but these errors were encountered: