Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clementine doesn't work on macOS Mojave #6148

Closed
3 tasks done
slallum opened this issue Sep 27, 2018 · 19 comments
Closed
3 tasks done

Clementine doesn't work on macOS Mojave #6148

slallum opened this issue Sep 27, 2018 · 19 comments

Comments

@slallum
Copy link

slallum commented Sep 27, 2018

Before posting

Please follow the steps below and check the boxes with [x] once you did the step.

  • I checked the issue tracker for similar issues
  • I checked the changelog if the issue is already resolved
  • I tried the latest Clementine build from here

System information

Please provide information about your system and the version of Clementine used.

  • Operating System: macOS Mojave, MacBook Pro (15-inch, 2017).
  • Clementine version: 1.3.1, also tried 1.3.2rc1.

Expected behaviour / actual behaviour

Clementine is opening, showing the main window for a split second and then quits.

Steps to reproduce the problem (only for bugs)

Upgrade to Mojave and open Clementine.

@slallum
Copy link
Author

slallum commented Sep 27, 2018

Solved it.
Turns out I need to give accessibility control to Clementine under "Security and Privacy" preferences:

image

@slallum slallum closed this as completed Sep 27, 2018
@edwardgalligan
Copy link

@slallum I also experienced this, so thanks for posting the workaround. However, since it's a workaround and not a bugfix (the bug still exists), it might be worth leaving the issue open?

@slallum
Copy link
Author

slallum commented Oct 15, 2018

@edwardgalligan I agree, I'll reopen.

@slallum slallum reopened this Oct 15, 2018
@ovichiro
Copy link

Why does Clementine need accessibility control?

@DarthVaderx99
Copy link

DarthVaderx99 commented Oct 18, 2018

it is not just clementine all (third party?) apps need it now in mojave. and new now apple requires you to say yes to letting app have privilages the first time it is opened in mojave, apples new way of checking malware?!?!

@hatstand
Copy link
Contributor

IIRC, it's because Apple doesn't let you use the media keys any other way.

@ovichiro
Copy link

it is not just clementine all (third party?) apps need it now in mojave. and new now apple requires you to say yes to letting app have privilages the first time it is opened in mojave, apples new way of checking malware?!?!

That dialog is indeed intended to prevent apps adding themselves automatically to accessibility control, but no, not all third party apps require accessibility. Cantata works fine without it and since Clementine also defines it's own keyboard shortcuts it shouldn't crash if I don't grant it permission for such control.
@hatstand is probably right. Thanks.

@edwardgalligan
Copy link

it is not just clementine all (third party?) apps need it now in mojave

This definitely isn't true or there'd be a similar issue to this on every macOS app bugtracker out there.

As @hatstand pointed out, Clementine (and I guess most music players) do use explicit accessibility features. However, it probably shouldn't crash the entire app when that one feature isn't available.

@hatstand
Copy link
Contributor

Yeah, clementine is supposed to check if it's enabled and if not, open the accessibility dialog for you. But I'm guessing Apple's API changed in Mojave. I don't really have time to look into it but the code if you're interested is here:

https://github.com/clementine-player/Clementine/blob/master/src/core/mac_startup.mm
https://github.com/clementine-player/Clementine/blob/master/src/core/macglobalshortcutbackend.mm#L130

and we use https://github.com/nevyn/SPMediaKeyTap which hasn't been updated since 2015...

@jrkong
Copy link
Contributor

jrkong commented Nov 5, 2018

I'll do a bit of digging to see if I can get this working.

@jrkong
Copy link
Contributor

jrkong commented Nov 24, 2018

@hatstand seems like the crash occurs because AXAPIEnabled() has been depreciated since Mavericks (macOS 10.9). I updated the code to fallback to the call used by Mavericks and later if the AXAPIEnabled() call fails in my PR so the crash doesn't occur anymore.

@benlk
Copy link

benlk commented Dec 3, 2018

For newer versions of OSX, https://developer.apple.com/documentation/mediaplayer/mpremotecommandcenter provides access to the media player actions.

@hatstand
Copy link
Contributor

hatstand commented Dec 3, 2018

Shouldn't be too hard to update Clementine to use that here instead then: https://github.com/clementine-player/Clementine/blob/master/src/core/macglobalshortcutbackend.mm

I'd do it but I don't have a mac anymore.

@hatstand hatstand closed this as completed Dec 6, 2018
@Volodymyr-13
Copy link

Same here. Mojave 10.14.3.

I just downloaded official version 1.3.1 and got that crash.
However when I downloaded version from latest builds, it was Jan 28 and it's runs ok, but problem was - I can't import any files, nothing happens.

@ssbarnea
Copy link

ssbarnea commented May 1, 2019

I am wondering why this bug is closed as clearly this is a deal breaker. That is the first MacOS that is effectively instanly crashign when Accesibility access is not enabled, clearly a very bad first time user experience.

@benlk
Copy link

benlk commented May 3, 2019

As an outsider, this bug appears to be closed because:

People are wondering why this issue is closed when the bug still occurs because:

@grnadav
Copy link

grnadav commented Aug 6, 2019

As an outsider, this bug appears to be closed because:

People are wondering why this issue is closed when the bug still occurs because:

https://builds.clementine-player.org/mac/ - work for me now. used latest 1.3.1 build and the issue is indeed resolved.

Would have been nice to have an "official" release w/ the fixes since 2016 on the main website though. If anyone w/ sufficient access has time to put the required effort is a different question though 😏

@hipunk
Copy link

hipunk commented Oct 24, 2019

Sorry for going semi-off-topic, but it's kind of true what @DarthVaderx99 says, considering you're using some services based on AppleScript from the services menu. You need to add every single application to the accessibility list then.

@MrSmiths
Copy link

after upgrade High Sierra to Mojave clementine crashes.. removed.. downloaded 1.3.1.. install.. crash..
permiting accessibility control solved the issue.. Thanks @slallum

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests